From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails
Date: Sun, 02 Nov 2014 00:42:15 +0200 [thread overview]
Message-ID: <7950903.uMzjEJkf7Q@avalon> (raw)
In-Reply-To: <1414813532.4855.0.camel@phoenix>
Hi Axel,
Thank you for the patch.
On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Joerg, could you please pick this patch up ?
> ---
> drivers/iommu/ipmmu-vmsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 7dab5cb..d25fa12 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
> dev_name(&pdev->dev), mmu);
> if (ret < 0) {
> dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
> - return irq;
> + return ret;
> }
>
> ipmmu_device_reset(mmu);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-11-01 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 3:45 [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails Axel Lin
2014-11-01 22:42 ` Laurent Pinchart [this message]
2014-11-04 14:09 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7950903.uMzjEJkf7Q@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.