From: Jan Beulich <jbeulich@suse.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: xen-devel@lists.xenproject.org, roger.pau@citrix.com, wl@xen.org,
andrew.cooper3@citrix.com
Subject: Re: [Xen-devel] [PATCH] x86/time: update TSC stamp on restore from deep C-state
Date: Wed, 15 Jan 2020 13:39:05 +0100 [thread overview]
Message-ID: <7951674e-1b8a-03b0-00b9-e7d7fe7eb10c@suse.com> (raw)
In-Reply-To: <6f6064f9-5400-3d85-75c5-b63ca460383d@citrix.com>
On 15.01.2020 13:28, Igor Druzhinin wrote:
> On 15/01/2020 11:32, Jan Beulich wrote:
>> On 14.01.2020 20:36, Igor Druzhinin wrote:
>>> If ITSC is not available on CPU (e.g if running nested as PV shim)
>>> then X86_FEATURE_NONSTOP_TSC is not advertised in certain cases, i.e.
>>> all AMD and some old Intel processors. In which case TSC would need to
>>> be restored on CPU from platform time by Xen upon exiting deep C-states.
>>
>> How does waking from deep C states correspond to the PV shim? I notice
>> that cstate_restore_tsc() gets called irrespective of the C state being
>> exited, so I wonder whether there's room for improvement there
>> independent of the issue at hand. As far as this change is concerned,
>> I think you want to drop the notion of "deep" from the description.
>
> I'm not familiar with what to call "deep C-state" so for me it was anything
> higher than C1. If you prefer "deep" to be dropped - so be it.
"Higher than C1" may be fine (albeit I vaguely recall TSC issues
starting with C3 only), but at least mwait_idle() calls the
function even for C1. As to the PV shim - does it know about any
C-states at all (beyond HLT-invoked C1)?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-15 12:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 19:36 [Xen-devel] [PATCH] x86/time: update TSC stamp on restore from deep C-state Igor Druzhinin
2020-01-15 9:47 ` Roger Pau Monné
2020-01-15 11:40 ` Jan Beulich
2020-01-15 11:53 ` Roger Pau Monné
2020-01-15 12:49 ` Jan Beulich
2020-01-15 13:44 ` Roger Pau Monné
2020-01-15 16:21 ` Jan Beulich
2020-01-16 9:33 ` Roger Pau Monné
2020-01-16 9:38 ` Jan Beulich
2020-01-16 12:09 ` Igor Druzhinin
2020-01-16 12:25 ` Roger Pau Monné
2020-01-15 12:25 ` Igor Druzhinin
2020-01-15 12:31 ` Igor Druzhinin
2020-01-15 12:41 ` Jan Beulich
2020-01-15 12:36 ` Igor Druzhinin
2020-01-15 13:23 ` Roger Pau Monné
2020-01-15 14:45 ` Igor Druzhinin
2020-01-15 11:32 ` Jan Beulich
2020-01-15 12:28 ` Igor Druzhinin
2020-01-15 12:39 ` Jan Beulich [this message]
2020-01-15 12:47 ` Igor Druzhinin
2020-01-15 12:54 ` Jan Beulich
2020-01-15 14:55 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7951674e-1b8a-03b0-00b9-e7d7fe7eb10c@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.