From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49EDDC83F18 for ; Thu, 10 Jul 2025 07:55:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FDB110E898; Thu, 10 Jul 2025 07:55:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FM6534TB"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22D3310E898 for ; Thu, 10 Jul 2025 07:55:02 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ACA6C5C6BBC; Thu, 10 Jul 2025 07:55:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CAE0C4CEE3; Thu, 10 Jul 2025 07:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752134101; bh=miC9ULvehpVK+bWFsSxBlt+WLo0btkBVIubocwNZI6o=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=FM6534TBp/dZa+q1OJNW4Nfhqqvrf4xMtLZBGTv3Ry0Jl93UewiIybj0RNGTC7Tjf 6PR/Z4yFlQ9Vsu+/HHZH3S76dnwUCSg15QDJC5USE1gVNi10tvR7iq36U9sIzKyBbK hPoQc6yDrBoIcC3BYVbDOjZVwkaW+6H2/I1KFAoXAWaO0h8qyum8U1UsGC/fuo8gqh XN4nD8by+RJm5LhS7Udy48izYkaRohq+FOpPbpyJDPx4TyLhZZ/nibwTKtFio824bX rzVizmL95en6GlXrHfJ8zf5DCIvaf/A28ljlilXFaLcl8IrY+mOLGaxmum0BEaCRbw SbnPmttCneE3g== Message-ID: <79541d9510b217170c8f66d6e3fefc22@kernel.org> Date: Thu, 10 Jul 2025 07:54:58 +0000 From: "Maxime Ripard" To: "Luca Ceresoli" Subject: Re: [PATCH 3/3] drm/bridge: display-connector: put the bridge obtained by drm_bridge_get_prev_bridge() In-Reply-To: <20250709-drm-bridge-alloc-getput-drm_bridge_get_prev_bridge-v1-3-34ba6f395aaa@bootlin.com> References: <20250709-drm-bridge-alloc-getput-drm_bridge_get_prev_bridge-v1-3-34ba6f395aaa@bootlin.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Andrzej Hajda" , "David Airlie" , "Hui Pu" , "Jernej Skrabec" , "Jonas Karlman" , "Laurent Pinchart" , "Maarten Lankhorst" , "Maxime Ripard" , "Neil Armstrong" , "Robert Foss" , "Simona Vetter" , "Thomas Petazzoni" , "Thomas Zimmermann" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 9 Jul 2025 17:59:39 +0200, Luca Ceresoli wrote: > The bridge returned by drm_bridge_get_prev_bridge() is refcounted. Put it > when done. >=20 > To keep the code clean and future-proof use a scope-based free. >=20 >=20 > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime