Re: [PATCH] rtnetlink: add needed_{head,tail}room attributes

[Alasdair McWilliam <alasdair@mcwilliam.dev>]

Hi Daniel,

On 15/09/2025 17:49, Daniel Borkmann wrote:
> Hi Alasdair,
> 

>> @@ -2243,6 +2249,8 @@ static const struct nla_policy
>> ifla_policy[IFLA_MAX+1] = {
>>       [IFLA_GSO_IPV4_MAX_SIZE]    = NLA_POLICY_MIN(NLA_U32,
>> MAX_TCP_HEADER + 1),
>>       [IFLA_GRO_IPV4_MAX_SIZE]    = { .type = NLA_U32 },
>>       [IFLA_NETNS_IMMUTABLE]    = { .type = NLA_REJECT },
>> +    [IFLA_HEADROOM]        = { .type = NLA_U16 },
>> +    [IFLA_TAILROOM]        = { .type = NLA_U16 },
> 
> Given this is for dumping only, we'd need to replace NLA_U16 above with
> NLA_REJECT
> like in case of IFLA_NETNS_IMMUTABLE.
> 
> Also the Documentation/netlink/specs/rt_link.yaml needs an extension,
> otherwise lgtm.
> $subj should have [PATCH net-next] to indicate the target tree.
> 

Acknowledged. I will revise and re-submit. I will also include
additional context in the commit log as per your later email in this thread.

> Thanks,
> Daniel

Thanks!
Alasdair