All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: ben.magistro@trinitycyber.com, Ben Magistro <koncept1@gmail.com>
Cc: stephen@networkplumber.org,
	Reshma Pattan <reshma.pattan@intel.com>,
	dev@dpdk.org
Subject: Re: [PATCH] app/dumpcap: allow help/version without primary process
Date: Tue, 08 Mar 2022 09:32:52 +0100	[thread overview]
Message-ID: <7966787.UjTJXf6HLC@thomas> (raw)
In-Reply-To: <21942374.BlLV05Wm1B@thomas>

22/02/2022 11:03, Thomas Monjalon:
> 25/01/2022 04:25, Ben Magistro:
> > Currently dumpcap tries to initialize dpdk before parsing command line
> > arguments, this makes it impossible to check version or help without
> > having the primary process running already.
> > 
> > Signed-off-by: Ben Magistro <koncept1@gmail.com>
> > ---
> > --- a/app/dumpcap/main.c
> > +++ b/app/dumpcap/main.c
> > @@ -781,8 +781,8 @@ int main(int argc, char **argv)
> >  
> >  	progname = argv[0];
> >  
> > -	dpdk_init();
> >  	parse_opts(argc, argv);
> > +	dpdk_init();
> 
> Stephen, Reshma, any comment?

Applied, thanks.



      reply	other threads:[~2022-03-08  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  3:25 [PATCH] app/dumpcap: allow help/version without primary process Ben Magistro
2022-02-22 10:03 ` Thomas Monjalon
2022-03-08  8:32   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7966787.UjTJXf6HLC@thomas \
    --to=thomas@monjalon.net \
    --cc=ben.magistro@trinitycyber.com \
    --cc=dev@dpdk.org \
    --cc=koncept1@gmail.com \
    --cc=reshma.pattan@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.