All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Olaf Hering" <olaf@aepfle.de>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Fam Zheng" <famz@redhat.com>,
	"QEMU Trivial" <qemu-trivial@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] configure: require glib-2.24
Date: Thu, 26 Apr 2018 14:42:12 +0200	[thread overview]
Message-ID: <79669d21-8f20-dff2-83c3-c3fd95dfe179@redhat.com> (raw)
In-Reply-To: <b976e072-78c5-e12a-ba72-2075b8b635e3@redhat.com>

On 26/04/2018 14:39, Paolo Bonzini wrote:
> On 26/04/2018 14:11, Olaf Hering wrote:
>> Am Thu, 26 Apr 2018 13:10:02 +0100
>> schrieb Daniel P. Berrangé <berrange@redhat.com>:
>>
>>> Presumably the min-glib docker job didn't enable the vfio feature, which
>>> is what contained the bad code.
>>
>> It is Linux=y, every following commit would have failed too.
>> I suggest to revisit that testcase.
> 
> That's because Red Hat backported g_realloc_n into RHEL6 :) probably
> because it's used for security reasons and they expected users to appear
> in the next 10-ish years.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=573966

Almost.  It's because the g_*alloc_n was introduced in order to fix
overflows in g_*new.  When Red Hat fixed the overflows, that implicitly
added those functions.

Paolo


  reply	other threads:[~2018-04-26 12:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 12:38 [Qemu-trivial] [PATCH v1] configure: require glib-2.24 Olaf Hering
2018-04-18 12:45 ` [Qemu-trivial] [Qemu-devel] " Cornelia Huck
2018-04-18 12:55   ` Daniel P. Berrangé
2018-04-18 14:41     ` Cornelia Huck
2018-04-18 14:43       ` Daniel P. Berrangé
2018-04-19  7:19     ` Markus Armbruster
2018-04-19  7:30       ` Olaf Hering
2018-04-19  7:59         ` Daniel P. Berrangé
2018-04-19  8:54           ` Peter Maydell
2018-04-19  9:01             ` Kamil Rytarowski
2018-04-19  9:20             ` Gerd Hoffmann
2018-04-19  9:23               ` Daniel P. Berrangé
2018-04-18 14:45   ` Olaf Hering
2018-04-18 12:47 ` Daniel P. Berrangé
2018-04-18 13:00   ` Olaf Hering
2018-04-18 13:29   ` Peter Maydell
2018-04-18 14:44     ` Daniel P. Berrangé
2018-04-26  8:17       ` Peter Maydell
2018-04-26  9:19         ` Thomas Huth
2018-04-26  9:54           ` Peter Maydell
2018-04-26 11:52         ` Paolo Bonzini
2018-04-26 12:08           ` Olaf Hering
2018-04-26 12:10             ` Daniel P. Berrangé
2018-04-26 12:11               ` Olaf Hering
2018-04-26 12:39                 ` Paolo Bonzini
2018-04-26 12:42                   ` Paolo Bonzini [this message]
2018-04-26 12:42                   ` Olaf Hering
2018-04-26 12:12             ` Peter Maydell
2018-04-18 13:34   ` Eric Blake
2018-04-18 12:53 ` no-reply
2018-04-18 13:04   ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79669d21-8f20-dff2-83c3-c3fd95dfe179@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=olaf@aepfle.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.