From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Date: Wed, 3 Nov 2021 10:26:57 -0700 Subject: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property In-Reply-To: References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> <8db279c9-4c76-91a5-3617-a17effb2d103@linux.intel.com> Message-ID: <796e0c02-5bca-e8a9-a17f-898aafec237f@linux.intel.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/3/2021 9:29 AM, Rob Herring wrote: > On Wed, Nov 3, 2021 at 11:08 AM Jae Hyun Yoo > wrote: >> >> Hi Rob, >> >> On 11/2/2021 6:20 PM, Rob Herring wrote: >>> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo at intel.com wrote: >>>> From: Jae Hyun Yoo >>>> >>>> Add 'clocks' as a required property. >>>> >>>> Signed-off-by: Jae Hyun Yoo >>>> --- >>>> v1 -> v2: >>>> Changes sinve v1: >>>> - Added 'clocks' property into kcs-bmc bindings using >>>> 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into >>>> 'aspeed-lpc.yaml' yet. The bindings merging could be done using a >>>> separate patch later. >>>> >>>> .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >>> >>> Full log is available here: https://patchwork.ozlabs.org/patch/1549943 >>> >>> >>> kcs at 114: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >>> kcs at 24: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> >>> kcs at 28: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> >>> kcs at 2c: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >> >> #4/6 in this patch adds 'clocks' into aspeed-g5.dtsi and aspeed-g6.dtsi >> as a default property and all above dts files include the dtsi file so >> these warning shouldn't be seen. Is it a result after applying all >> changes in this series or just after cherry picking #5/6 patch only? > > Only patch 5 is applied. > >> I tested 'dtbs_check' before submitting this series I tested it again >> and got the same good result like below. >> >> Aren't the above warnings false positive? Or did I miss something? > > What you missed is this is an ABI. You cannot make something required > that was not required before. If the driver follows the schema and > makes 'clocks' required, then old DTBs with a new kernel will break. Okay. I got it clearly and understand that it could introduce a problem in that case. Thanks for your clarification. > It's possible that 'clocks' was always required or that it never > worked without clocks, then this change is okay. Looking at this > patch, I have no way to know that. The commit message has to explain > that. A commit message needs to answer WHY are you making the change. > You don't really need WHAT the change is as anyone can read the diff. Then what would be better? Would it be good enough if I add more detail commit message including a note that dtb recompiling is required? Or, should I change this series to treat the 'clocks' as an optional property? Can you please share your thought? Thanks, Jae > Rob > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCFAC433EF for ; Wed, 3 Nov 2021 17:28:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 038FB61073 for ; Wed, 3 Nov 2021 17:28:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 038FB61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GOzoWbKz29GSmOhcwe22vB3QmLvClmlEqr1SKx8rBXo=; b=zWoyNNOr3NQcxb 1deh/6SLnJVN/clqtSxT1X8Dn6SZeWOuleWoboeg1CWNfJhrJTOfE7zGTvEY1f7OCXOroN57y6c1w 8WgMFzblExeoC9ZQ2X4Wo5Pif1u19IpCD05z7dAePhQmuN92sgoWwQBAhqQq9CDkQCCf7EC+wqmgh YezzbRTBAmUYZ/QS84pLqyEokzvPB9k9AFWjNmigkmWV8leNLgkLmQklGHrjwLiefWBUtoMlVJSus 2rsaQGWf85i5xhlTdgk+1VX6X26r6nANOwdDc2UhR/EbyY2HL+ahpD5N2BxVKH1sGgPiYfEmn1ndX 6yct9rC1H4LGrpikwuRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miK2Y-005x65-6P; Wed, 03 Nov 2021 17:27:10 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miK2U-005x55-LT for linux-arm-kernel@lists.infradead.org; Wed, 03 Nov 2021 17:27:08 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231400838" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="231400838" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 10:27:03 -0700 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="501179871" Received: from yoojae-mobl.amr.corp.intel.com (HELO [10.212.171.79]) ([10.212.171.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 10:27:02 -0700 Message-ID: <796e0c02-5bca-e8a9-a17f-898aafec237f@linux.intel.com> Date: Wed, 3 Nov 2021 10:26:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property Content-Language: en-US To: Rob Herring Cc: jae.hyun.yoo@intel.com, Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-aspeed , Haiyue Wang , linux-arm-kernel , devicetree@vger.kernel.org, Cedric Le Goater , Corey Minyard , ChiaWei Wang References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> <8db279c9-4c76-91a5-3617-a17effb2d103@linux.intel.com> From: Jae Hyun Yoo In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_102706_781265_C97BBD9E X-CRM114-Status: GOOD ( 24.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/3/2021 9:29 AM, Rob Herring wrote: > On Wed, Nov 3, 2021 at 11:08 AM Jae Hyun Yoo > wrote: >> >> Hi Rob, >> >> On 11/2/2021 6:20 PM, Rob Herring wrote: >>> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote: >>>> From: Jae Hyun Yoo >>>> >>>> Add 'clocks' as a required property. >>>> >>>> Signed-off-by: Jae Hyun Yoo >>>> --- >>>> v1 -> v2: >>>> Changes sinve v1: >>>> - Added 'clocks' property into kcs-bmc bindings using >>>> 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into >>>> 'aspeed-lpc.yaml' yet. The bindings merging could be done using a >>>> separate patch later. >>>> >>>> .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >>> >>> Full log is available here: https://patchwork.ozlabs.org/patch/1549943 >>> >>> >>> kcs@114: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >>> kcs@24: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> >>> kcs@28: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> >>> kcs@2c: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >> >> #4/6 in this patch adds 'clocks' into aspeed-g5.dtsi and aspeed-g6.dtsi >> as a default property and all above dts files include the dtsi file so >> these warning shouldn't be seen. Is it a result after applying all >> changes in this series or just after cherry picking #5/6 patch only? > > Only patch 5 is applied. > >> I tested 'dtbs_check' before submitting this series I tested it again >> and got the same good result like below. >> >> Aren't the above warnings false positive? Or did I miss something? > > What you missed is this is an ABI. You cannot make something required > that was not required before. If the driver follows the schema and > makes 'clocks' required, then old DTBs with a new kernel will break. Okay. I got it clearly and understand that it could introduce a problem in that case. Thanks for your clarification. > It's possible that 'clocks' was always required or that it never > worked without clocks, then this change is okay. Looking at this > patch, I have no way to know that. The commit message has to explain > that. A commit message needs to answer WHY are you making the change. > You don't really need WHAT the change is as anyone can read the diff. Then what would be better? Would it be good enough if I add more detail commit message including a note that dtb recompiling is required? Or, should I change this series to treat the 'clocks' as an optional property? Can you please share your thought? Thanks, Jae > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E24BC433F5 for ; Wed, 3 Nov 2021 17:27:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3338F60E9B for ; Wed, 3 Nov 2021 17:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbhKCR3k (ORCPT ); Wed, 3 Nov 2021 13:29:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:44357 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbhKCR3j (ORCPT ); Wed, 3 Nov 2021 13:29:39 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="218747101" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="218747101" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 10:27:03 -0700 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="501179871" Received: from yoojae-mobl.amr.corp.intel.com (HELO [10.212.171.79]) ([10.212.171.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 10:27:02 -0700 Message-ID: <796e0c02-5bca-e8a9-a17f-898aafec237f@linux.intel.com> Date: Wed, 3 Nov 2021 10:26:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property Content-Language: en-US To: Rob Herring Cc: jae.hyun.yoo@intel.com, Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-aspeed , Haiyue Wang , linux-arm-kernel , devicetree@vger.kernel.org, Cedric Le Goater , Corey Minyard , ChiaWei Wang References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> <8db279c9-4c76-91a5-3617-a17effb2d103@linux.intel.com> From: Jae Hyun Yoo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/3/2021 9:29 AM, Rob Herring wrote: > On Wed, Nov 3, 2021 at 11:08 AM Jae Hyun Yoo > wrote: >> >> Hi Rob, >> >> On 11/2/2021 6:20 PM, Rob Herring wrote: >>> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote: >>>> From: Jae Hyun Yoo >>>> >>>> Add 'clocks' as a required property. >>>> >>>> Signed-off-by: Jae Hyun Yoo >>>> --- >>>> v1 -> v2: >>>> Changes sinve v1: >>>> - Added 'clocks' property into kcs-bmc bindings using >>>> 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into >>>> 'aspeed-lpc.yaml' yet. The bindings merging could be done using a >>>> separate patch later. >>>> >>>> .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >>> >>> Full log is available here: https://patchwork.ozlabs.org/patch/1549943 >>> >>> >>> kcs@114: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >>> kcs@24: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> >>> kcs@28: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> >>> kcs@2c: 'clocks' is a required property >>> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml >>> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >>> >> >> #4/6 in this patch adds 'clocks' into aspeed-g5.dtsi and aspeed-g6.dtsi >> as a default property and all above dts files include the dtsi file so >> these warning shouldn't be seen. Is it a result after applying all >> changes in this series or just after cherry picking #5/6 patch only? > > Only patch 5 is applied. > >> I tested 'dtbs_check' before submitting this series I tested it again >> and got the same good result like below. >> >> Aren't the above warnings false positive? Or did I miss something? > > What you missed is this is an ABI. You cannot make something required > that was not required before. If the driver follows the schema and > makes 'clocks' required, then old DTBs with a new kernel will break. Okay. I got it clearly and understand that it could introduce a problem in that case. Thanks for your clarification. > It's possible that 'clocks' was always required or that it never > worked without clocks, then this change is okay. Looking at this > patch, I have no way to know that. The commit message has to explain > that. A commit message needs to answer WHY are you making the change. > You don't really need WHAT the change is as anyone can read the diff. Then what would be better? Would it be good enough if I add more detail commit message including a note that dtb recompiling is required? Or, should I change this series to treat the 'clocks' as an optional property? Can you please share your thought? Thanks, Jae > Rob >