From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.126.130]:52442 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbcGBV20 convert rfc822-to-8bit (ORCPT ); Sat, 2 Jul 2016 17:28:26 -0400 From: Arnd Bergmann To: Arend Van Spriel Cc: Jonas Gorski , Hans de Goede , Kalle Valo , Priit Laes , "John W . Linville" , Arend van Spriel , Maxime Ripard , Chen-Yu Tsai , "linux-wireless@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , devicetree , linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property Date: Sat, 02 Jul 2016 23:30:21 +0200 Message-ID: <7975990.MvNRQ06u39@wuerfel> (sfid-20160702_232836_120708_3824B47B) In-Reply-To: References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote: > > If you want a separate property, then I repeat my very first > > suggestion, the well defined model property. > > e.g. > > > > brcmf@0 { > > model = "ampak,ap6210"; > > compatible = "brcm,bcm4329-fmac"; > > ... > > }; > > > > All device nodes may have a model property, not just the top "machine" one. > > I heard you the first time I just was not sure what the implications > would be to use it. Hence I suggested a vendor specific property. > However, looking up and reading the definition in ePAPRv1.1 I suppose it > is fine to use the model property: > > Property: model > Value type: > Description: > The model property value is a that specifies the manufacturer’s > model number of the device. > > The recommended format is: “manufacturer,model”, where manufacturer is a > string describing the name of the manufacturer (such as a stock ticker > symbol), and model specifies the model number. The model property is very similar to compatible, except that there is only one entry rather than a list of entries from most specific to most generic. I think by writing the above example as compatible = "ampak,ap6210", "brcm,bcm4329-fmac"; we can provide the same functionality in a slightly simpler way, the driver then just goes on to look for the nvram file for each entry in sequence until it finds one. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 02 Jul 2016 23:30:21 +0200 Subject: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name dt property In-Reply-To: References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> Message-ID: <7975990.MvNRQ06u39@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote: > > If you want a separate property, then I repeat my very first > > suggestion, the well defined model property. > > e.g. > > > > brcmf at 0 { > > model = "ampak,ap6210"; > > compatible = "brcm,bcm4329-fmac"; > > ... > > }; > > > > All device nodes may have a model property, not just the top "machine" one. > > I heard you the first time I just was not sure what the implications > would be to use it. Hence I suggested a vendor specific property. > However, looking up and reading the definition in ePAPRv1.1 I suppose it > is fine to use the model property: > > Property: model > Value type: > Description: > The model property value is a that specifies the manufacturer?s > model number of the device. > > The recommended format is: ?manufacturer,model?, where manufacturer is a > string describing the name of the manufacturer (such as a stock ticker > symbol), and model specifies the model number. The model property is very similar to compatible, except that there is only one entry rather than a list of entries from most specific to most generic. I think by writing the above example as compatible = "ampak,ap6210", "brcm,bcm4329-fmac"; we can provide the same functionality in a slightly simpler way, the driver then just goes on to look for the nvram file for each entry in sequence until it finds one. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property Date: Sat, 02 Jul 2016 23:30:21 +0200 Message-ID: <7975990.MvNRQ06u39@wuerfel> References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> Reply-To: arnd-r2nGTMty4D4@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Arend Van Spriel Cc: Jonas Gorski , Hans de Goede , Kalle Valo , Priit Laes , "John W . Linville" , Arend van Spriel , Maxime Ripard , Chen-Yu Tsai , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote: > > If you want a separate property, then I repeat my very first > > suggestion, the well defined model property. > > e.g. > >=20 > > brcmf@0 { > > model =3D "ampak,ap6210"; > > compatible =3D "brcm,bcm4329-fmac"; > > ... > > }; > >=20 > > All device nodes may have a model property, not just the top "machine" = one. >=20 > I heard you the first time I just was not sure what the implications > would be to use it. Hence I suggested a vendor specific property. > However, looking up and reading the definition in ePAPRv1.1 I suppose it > is fine to use the model property: >=20 > Property: model > Value type: > Description: > The model property value is a that specifies the manufacturer=E2= =80=99s > model number of the device. >=20 > The recommended format is: =E2=80=9Cmanufacturer,model=E2=80=9D, where ma= nufacturer is a > string describing the name of the manufacturer (such as a stock ticker > symbol), and model specifies the model number. The model property is very similar to compatible, except that there is only one entry rather than a list of entries from most specific to most generic. I think by writing the above example as compatible =3D "ampak,ap6210", "brcm,bcm4329-fmac"; we can provide the same functionality in a slightly simpler way, the driver then just goes on to look for the nvram file for each entry in sequence unt= il it finds one. Arnd --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.