From: "Xu, Baojun" <baojun.xu@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Yi, Ken" <k-yi@ti.com>, "Lo, Henry" <henry.lo@ti.com>,
"Chen, Robin" <robinchen@ti.com>, "Wang, Will" <will-wang@ti.com>,
"jim.shil@goertek.com" <jim.shil@goertek.com>,
"toastcheng@google.com" <toastcheng@google.com>,
"chinkaiting@google.com" <chinkaiting@google.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support
Date: Tue, 11 Nov 2025 08:21:00 +0000 [thread overview]
Message-ID: <7981d64728994bb9bb495af5d4631d61@ti.com> (raw)
In-Reply-To: <d6ba62ec-25b2-4c51-8915-8e69d76b610e@kernel.org>
________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 November 2025 15:17
> To: Xu, Baojun
> Cc: broonie@kernel.org; tiwai@suse.de; andriy.shevchenko@linux.intel.com; 13916275206@139.com; Ding, Shenghao; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Wang, Will; jim.shil@goertek.com; toastcheng@google.com; chinkaiting@google.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support
> >
> > Hi Krzysztof,
> >
> > Thanks for your review.
> > Do you mean I need to add an rst file in Documentation\sound\codecs?
>
> Where anything like that is explained in the docs I linked? Do you
> understand what patch I commented on and what documented I linked?
>
Hi Krzysztof,
Thanks for your review.
From your link, it write:
5) The Documentation/ portion of the patch should come in the series before
the code implementing the binding.
Do you mean I need move compatible to above, like below:
properties:
compatible:
- enum:
- ti,tas2020
- ti,tas2118
- ti,tas2120
... ...
> Best regards,
> Krzysztof
>
>
Best Regards
Jim
prev parent reply other threads:[~2025-11-11 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 11:07 [PATCH v1 1/2] ASoC: tas2781: Add tas2568/5806m/5806md/5830 support Baojun Xu
2025-11-08 11:07 ` [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support Baojun Xu
2025-11-09 17:17 ` Krzysztof Kozlowski
2025-11-10 5:29 ` [EXTERNAL] " Xu, Baojun
2025-11-10 7:11 ` Krzysztof Kozlowski
2025-11-10 12:24 ` Mark Brown
2025-11-11 7:12 ` Xu, Baojun
2025-11-11 7:17 ` Krzysztof Kozlowski
2025-11-11 8:21 ` Xu, Baojun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7981d64728994bb9bb495af5d4631d61@ti.com \
--to=baojun.xu@ti.com \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=chinkaiting@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henry.lo@ti.com \
--cc=jim.shil@goertek.com \
--cc=k-yi@ti.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=toastcheng@google.com \
--cc=will-wang@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.