From: David Howells <dhowells@redhat.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: dhowells@redhat.com, James Morris <james.l.morris@oracle.com>,
Andreea-Cristina Bernat <bernat.ada@gmail.com>,
Stephen Hemminger <shemming@brocade.com>,
Don Zickus <dzickus@redhat.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] assoc_array: Include rcupdate.h for call_rcu() definition
Date: Mon, 05 Jan 2015 16:01:42 +0000 [thread overview]
Message-ID: <799.1420473702@warthog.procyon.org.uk> (raw)
In-Reply-To: <1419918382-4758-1-git-send-email-bobby.prani@gmail.com>
Pranith Kumar <bobby.prani@gmail.com> wrote:
> Include rcupdate.h header to provide call_rcu() definition. This was implicitly
> being provided by slab.h file which include srcu.h somewhere in its include
> hierarchy which in-turn included rcupdate.h.
>
> Lately, tinification effort added support to remove srcu entirely because of
> which we are encountering build errors like
>
> lib/assoc_array.c: In function 'assoc_array_apply_edit':
> lib/assoc_array.c:1426:2: error: implicit declaration of function 'call_rcu' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> Fix these by including rcupdate.h explicitly.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reported-by: Scott Wood <scottwood@freescale.com>
Applied.
prev parent reply other threads:[~2015-01-05 16:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 5:46 [PATCH] assoc_array: Include rcupdate.h for call_rcu() definition Pranith Kumar
2014-12-30 5:46 ` [PATCH v2] srcu: Isolate srcu sections using CONFIG_SRCU Pranith Kumar
2014-12-30 5:46 ` Pranith Kumar
2014-12-30 18:50 ` Peter Zijlstra
2014-12-30 18:50 ` Peter Zijlstra
2014-12-30 18:54 ` Pranith Kumar
2014-12-30 18:54 ` Pranith Kumar
2014-12-30 19:07 ` Peter Zijlstra
2014-12-30 19:07 ` Peter Zijlstra
2014-12-31 13:19 ` Paul E. McKenney
2014-12-31 13:19 ` Paul E. McKenney
2015-01-04 9:35 ` Michael Ellerman
2015-01-04 9:35 ` Michael Ellerman
2015-01-04 16:14 ` Paul E. McKenney
2015-01-04 16:14 ` Paul E. McKenney
2015-01-05 4:57 ` Josh Triplett
2015-01-05 4:57 ` Josh Triplett
2015-01-05 16:01 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799.1420473702@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bernat.ada@gmail.com \
--cc=bobby.prani@gmail.com \
--cc=dzickus@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.