From: Thomas Monjalon <thomas@monjalon.net>
To: Yanglong Wu <yanglong.wu@intel.com>
Cc: dev@dpdk.org, shahafs@mellanox.com, wenzhuo.lu@intel.com
Subject: Re: [PATCH] app/testpmd:vlan filter fail
Date: Thu, 01 Feb 2018 03:07:03 +0100 [thread overview]
Message-ID: <7990034.yJyxX93kgV@xps> (raw)
In-Reply-To: <20180201012653.173890-1-yanglong.wu@intel.com>
01/02/2018 02:26, Yanglong Wu:
> And-operartion with a constant will
> always lead to fail for vlan filter.
>
> fix:0074d02fc(convert to new Rx offloads API)
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
[...]
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -2288,7 +2288,7 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on)
>
> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> dev = &rte_eth_devices[port_id];
> - if (!(dev->data->dev_conf.rxmode.offloads &
> + if (!(dev->data->dev_conf.rxmode.offloads ||
> DEV_RX_OFFLOAD_VLAN_FILTER)) {
> RTE_PMD_DEBUG_TRACE("port %d: vlan-filtering disabled\n", port_id);
> return -ENOSYS;
This patch is wrong.
If you are trying to use VLAN filtering with testpmd,
you must enable it with --enable-hw-vlan-filter.
next prev parent reply other threads:[~2018-02-01 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 1:26 [PATCH] app/testpmd:vlan filter fail Yanglong Wu
2018-02-01 2:07 ` Thomas Monjalon [this message]
2018-02-01 5:57 ` Shahaf Shuler
2018-02-02 3:37 ` Wu, Yanglong
-- strict thread matches above, loose matches on Subject: below --
2018-02-02 5:09 Yanglong Wu
2018-02-04 6:27 ` Shahaf Shuler
2018-02-05 1:51 ` Wu, Yanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7990034.yJyxX93kgV@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.