Re: [PATCH] ALSA: pcm: reinvent the stream synchronization ID API

[Jaroslav Kysela <perex@perex.cz>]

On 02. 05. 24 17:27, Takashi Iwai wrote:

>>>> --- a/include/uapi/sound/asound.h
>>>> +++ b/include/uapi/sound/asound.h
>>> (snip)
>>>> @@ -334,6 +334,7 @@ union snd_pcm_sync_id {
>>>>    	unsigned char id[16];
>>>>    	unsigned short id16[8];
>>>>    	unsigned int id32[4];
>>>> +	__u64 id64[2];
>>>>    };
>>>
>>> What's the reason for this __u64 addition?  For the easiness of
>>> zero-compare?
>>
>> Basically yes, but this extensions is aligned with other fields. Also,
>> I think that it may be usable to work with 64-bit words here. Perhaps,
>> other fields may use __uXX declarations, too.
> 
> IMO, if we are allowed to redesign, it'd be better to avoid a union
> for an API call.  It's a nightmare if one needs a conversion of API
> (e.g. between different endianess for emulator).

It makes sense. I'll keep only unsigned char id then.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.