From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] doc: announce kvargs API change
Date: Sat, 24 Nov 2018 18:12:51 +0100
Message-ID: <7996667.p2u7l4RVcM@xps>
References: <20181121154545.14261-1-thomas@monjalon.net>
 <ba382836-0647-2f1d-8693-9e346fcdd335@intel.com>
 <20181123163058.GA11828@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 644641B5E9
 for <dev@dpdk.org>; Sat, 24 Nov 2018 18:12:56 +0100 (CET)
In-Reply-To: <20181123163058.GA11828@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/11/2018 17:31, Jerin Jacob:
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> > On 11/22/2018 1:22 PM, Olivier Matz wrote:
> > > On Thu, Nov 22, 2018 at 11:32:23AM +0100, Thomas Monjalon wrote:
> > >> After processing a kvlist in rte_kvargs_process(),
> > >> it may be needed to loop again over kvlist in order to know
> > >> whether the key is matched or not.
> > >> In order to simplify implementation of kvargs checks,
> > >> a new pointer parameter may be used to get the match count.
> > >>
> > >> The change of the function prototype would be as below:
> > >>
> > >>  int
> > >>  rte_kvargs_process(const struct rte_kvargs *kvlist,
> > >>              const char *key_match,
> > >> +            int *match_count,
> > >>              arg_handler_t handler,
> > >>              void *opaque_arg)
> > >>
> > >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > Maybe "unsigned int" instead of "int".
> > >
> > > Apart from this,
> > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > >
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied