From: Bart Van Assche <bvanassche@acm.org>
To: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
Cc: stable@vger.kernel.org,
"kernel test robot" <oliver.sang@intel.com>,
"Hagar Hemdan" <hagarhem@amazon.com>,
"Shaoying Xu" <shaoyi@amazon.com>, "Jens Axboe" <axboe@kernel.dk>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] Revert "block: don't reorder requests in blk_add_rq_to_plug"
Date: Wed, 11 Jun 2025 08:24:45 -0700 [thread overview]
Message-ID: <79d40bb9-ec40-415d-80eb-4ae8ab150737@acm.org> (raw)
In-Reply-To: <20250611121626.7252-1-abuehaze@amazon.com>
On 6/11/25 5:14 AM, Hazem Mohamed Abuelfotoh wrote:
> Given that moving plug list to a single linked list was mainly for
> performance reason then let's revert commit <e70c301faece> ("block: don't
> reorder requests in blk_add_rq_to_plug") for now to mitigate the
> reported performance regression.
Reverting that commit would break zoned storage support and hence is not
an option.
Bart.
prev parent reply other threads:[~2025-06-11 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 12:14 [PATCH] Revert "block: don't reorder requests in blk_add_rq_to_plug" Hazem Mohamed Abuelfotoh
2025-06-11 12:56 ` Jens Axboe
2025-06-11 15:15 ` Mohamed Abuelfotoh, Hazem
2025-06-11 15:10 ` Ming Lei
2025-06-11 15:24 ` Mohamed Abuelfotoh, Hazem
2025-06-11 15:26 ` Jens Axboe
2025-06-11 15:24 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d40bb9-ec40-415d-80eb-4ae8ab150737@acm.org \
--to=bvanassche@acm.org \
--cc=abuehaze@amazon.com \
--cc=axboe@kernel.dk \
--cc=eperezma@redhat.com \
--cc=hagarhem@amazon.com \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mst@redhat.com \
--cc=oliver.sang@intel.com \
--cc=pbonzini@redhat.com \
--cc=sagi@grimberg.me \
--cc=shaoyi@amazon.com \
--cc=stable@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.