From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: adrian.freihofer@siemens.com, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/7] cooker: fix bitbake -b silently ignoring bbappends
Date: Sat, 15 Aug 2026 22:39:47 +0100 [thread overview]
Message-ID: <79d9178d92f476b3571cc8038b2ebbf7583a03aa.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260815134722.497586-2-adrian.freihofer@siemens.com>
On Sat, 2026-08-15 at 15:46 +0200, Adrian Freihofer via lists.openembedded.org wrote:
> From: Adrian Freihofer <adrian.freihofer@siemens.com>
>
> "bitbake -b <recipe.bb>" builds the recipe without applying any of its
> .bbappend files.
>
> buildFileInternal() resolves appends via
> self.collections[mc].get_file_appends(fn), but self.collections[mc] is
> only ever filled in by collect_bbfiles(), called from updateCache() -
> a path -b deliberately skips. matchFiles(), the one -b-path function
> that does call collect_bbfiles(), built a fresh CookerCollectFiles into
> a throwaway local instead of self.collections[mc], so the append list
> stayed empty (or, on a memory-resident server, stale from the last
> full parse - e.g. missing a devtool/externalsrc workspace .bbappend
> added since). Nothing warns that the built metadata differs from disk.
>
> Make matchFiles() refresh self.collections[mc] itself so the later
> append lookup for the same fn sees the same fresh collection.
>
> AI-Generated: Uses GitHub Copilot
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
> lib/bb/cooker.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
I've not checked but doesn't this only add limited collections data so
whilst it fixes -b, it potentially corrupts the cache for the non -b
cases?
This is definitely something we should fix, I just want to make sure
this doesn't corrupt something else. I suspect it deliberately doesn't
write to self...
Cheers,
Richard
next prev parent reply other threads:[~2026-08-15 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 13:46 [PATCH 0/7] cooker/tinfoil: fix -b bbappend handling and add single-task prepared-task API AdrianF
2026-08-15 13:46 ` [PATCH 1/7] cooker: fix bitbake -b silently ignoring bbappends AdrianF
2026-08-15 21:39 ` Richard Purdie [this message]
2026-08-15 13:46 ` [PATCH 2/7] tests/cooker: add a bitbake -b bbappend test AdrianF
2026-08-15 13:46 ` [PATCH 3/7] command: fix setConfig coercing bool config values to truthy strings AdrianF
2026-08-15 13:46 ` [PATCH 4/7] cooker: add a buildFile mode that runs a single task AdrianF
2026-08-15 13:46 ` [PATCH 5/7] tinfoil: add a prepared task runner AdrianF
2026-08-15 13:46 ` [PATCH 6/7] tests/cooker: add TinfoilTests for run_prepared_task AdrianF
2026-08-15 13:46 ` [PATCH 7/7] parse/ast: skip empty BBPATH segments in include_all AdrianF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d9178d92f476b3571cc8038b2ebbf7583a03aa.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=adrian.freihofer@siemens.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.