From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 778C52EAFE; Thu, 16 Nov 2023 12:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SuKBqNHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005A4C433C8; Thu, 16 Nov 2023 12:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700136076; bh=c7gMUttZFyHHQ9COrEEKH4SS+vncMf6Y8hrZnTRxLYg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SuKBqNHsU+fNNgXSXPII1Osj2l1CDoO4VvhdYjyiNcPr/CKLB8/IgHL+sH2Zi5Vd3 OF9GVwgC+Iz1tDkjBPH05TP8xf9cUZvJP27FLs6guK6hcXe+QitVEfeRxycjlrlUHC bB0J7i4JVzw0lbczlYUP1gxsDzeA4QFkt0zl2iuQr1J21UAka2f35Gl0hUARiLxa8d LRMyXZY1B/HP7oyspTrzBF36zEYurikArcAf6C6+ObpTdJRrqhbO5h4zkkhfRV5Xri asFvYLhnhuQaawuRRVLPA38RvdGCETNY6o1wTdnNgYHD8D/fYTKPAmFnROS/p3Z/iZ Rt8ZgxgcGVmMg== Message-ID: <79f3beef-1afe-4b97-8f6e-435c0419b513@kernel.org> Date: Thu, 16 Nov 2023 14:00:46 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] usb: cdns3-ti: move reg writes from probe into an init_hw helper To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com> <20231113-j7200-usb-suspend-v1-2-ad1ee714835c@bootlin.com> Content-Language: en-US From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 15/11/2023 16:23, Théo Lebrun wrote: > Hello, > > On Wed Nov 15, 2023 at 12:33 PM CET, Roger Quadros wrote: >>> --- a/drivers/usb/cdns3/cdns3-ti.c >>> +++ b/drivers/usb/cdns3/cdns3-ti.c > > [...] > >>> static int cdns_ti_probe(struct platform_device *pdev) >>> { >>> struct device *dev = &pdev->dev; >>> struct device_node *node = pdev->dev.of_node; >>> struct cdns_ti *data; >>> - int error; >>> - u32 reg; >>> - int rate_code, i; >>> unsigned long rate; >>> + int error, i; >> >> Should we leave rate_code and get rid of i? > > I see your point about i being usually a temp variable. Using rate_code > instead of i means the for-loop becomes rather long (column 87) & > should ideally be split. > > How about moving the data->usb2_refclk_rate_code assignment up, closer > to the computation of i? That way we don't reference i three blocks > down the road, seemingly out of nowhere. That is much better. Thanks! -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA92DC197A0 for ; Thu, 16 Nov 2023 12:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8jCJ5PvCvkAxWGhOGyKjMRQ7XjwAHBSsgBOqp2GPn/k=; b=iMsOVWiID/EkZM 9kfNNsNk3RR7C9GBqQzV3h+0f/qehlXjn9nxf87LOjxcyyXA1fJAmamK8/iVoTObEHOoTyb8IdfzG zXot0qvzHPduxFai7JhhHYLl9vUGv5+2fbdjxTI/GrULYANVM325QLf+rNQWMmecesindf7xaQ3gE h6FezjhCm1oSZzzJoNj9giSG8QvdpbmREtXmOR3dVVzW/qcAk2Obhu+TzTOtlSIl4GI0/BfIGwdoM wWiLqnJ3S9dMEoxIvKdnSs5ifKZNs4Rim9scwxvZi5o1Ws6PYEZneoYaAJe0yP3MHit5N43DYuyt0 i4joKL3QHwZ4MES8cUSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3b3h-003QpQ-3A; Thu, 16 Nov 2023 12:01:21 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3b3e-003Qof-2i for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 12:01:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BF766CE2005; Thu, 16 Nov 2023 12:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005A4C433C8; Thu, 16 Nov 2023 12:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700136076; bh=c7gMUttZFyHHQ9COrEEKH4SS+vncMf6Y8hrZnTRxLYg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SuKBqNHsU+fNNgXSXPII1Osj2l1CDoO4VvhdYjyiNcPr/CKLB8/IgHL+sH2Zi5Vd3 OF9GVwgC+Iz1tDkjBPH05TP8xf9cUZvJP27FLs6guK6hcXe+QitVEfeRxycjlrlUHC bB0J7i4JVzw0lbczlYUP1gxsDzeA4QFkt0zl2iuQr1J21UAka2f35Gl0hUARiLxa8d LRMyXZY1B/HP7oyspTrzBF36zEYurikArcAf6C6+ObpTdJRrqhbO5h4zkkhfRV5Xri asFvYLhnhuQaawuRRVLPA38RvdGCETNY6o1wTdnNgYHD8D/fYTKPAmFnROS/p3Z/iZ Rt8ZgxgcGVmMg== Message-ID: <79f3beef-1afe-4b97-8f6e-435c0419b513@kernel.org> Date: Thu, 16 Nov 2023 14:00:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] usb: cdns3-ti: move reg writes from probe into an init_hw helper To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com> <20231113-j7200-usb-suspend-v1-2-ad1ee714835c@bootlin.com> Content-Language: en-US From: Roger Quadros In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_040119_079272_D0C3435A X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxNS8xMS8yMDIzIDE2OjIzLCBUaMOpbyBMZWJydW4gd3JvdGU6Cj4gSGVsbG8sCj4gCj4g T24gV2VkIE5vdiAxNSwgMjAyMyBhdCAxMjozMyBQTSBDRVQsIFJvZ2VyIFF1YWRyb3Mgd3JvdGU6 Cj4+PiAtLS0gYS9kcml2ZXJzL3VzYi9jZG5zMy9jZG5zMy10aS5jCj4+PiArKysgYi9kcml2ZXJz L3VzYi9jZG5zMy9jZG5zMy10aS5jCj4gCj4gWy4uLl0KPiAKPj4+ICBzdGF0aWMgaW50IGNkbnNf dGlfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+ICB7Cj4+PiAgCXN0cnVj dCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4+PiAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9k ZSA9IHBkZXYtPmRldi5vZl9ub2RlOwo+Pj4gIAlzdHJ1Y3QgY2Ruc190aSAqZGF0YTsKPj4+IC0J aW50IGVycm9yOwo+Pj4gLQl1MzIgcmVnOwo+Pj4gLQlpbnQgcmF0ZV9jb2RlLCBpOwo+Pj4gIAl1 bnNpZ25lZCBsb25nIHJhdGU7Cj4+PiArCWludCBlcnJvciwgaTsKPj4KPj4gU2hvdWxkIHdlIGxl YXZlIHJhdGVfY29kZSBhbmQgZ2V0IHJpZCBvZiBpPwo+IAo+IEkgc2VlIHlvdXIgcG9pbnQgYWJv dXQgaSBiZWluZyB1c3VhbGx5IGEgdGVtcCB2YXJpYWJsZS4gVXNpbmcgcmF0ZV9jb2RlCj4gaW5z dGVhZCBvZiBpIG1lYW5zIHRoZSBmb3ItbG9vcCBiZWNvbWVzIHJhdGhlciBsb25nIChjb2x1bW4g ODcpICYKPiBzaG91bGQgaWRlYWxseSBiZSBzcGxpdC4KPiAKPiBIb3cgYWJvdXQgbW92aW5nIHRo ZSBkYXRhLT51c2IyX3JlZmNsa19yYXRlX2NvZGUgYXNzaWdubWVudCB1cCwgY2xvc2VyCj4gdG8g dGhlIGNvbXB1dGF0aW9uIG9mIGk/IFRoYXQgd2F5IHdlIGRvbid0IHJlZmVyZW5jZSBpIHRocmVl IGJsb2Nrcwo+IGRvd24gdGhlIHJvYWQsIHNlZW1pbmdseSBvdXQgb2Ygbm93aGVyZS4KClRoYXQg aXMgbXVjaCBiZXR0ZXIuIFRoYW5rcyEKCi0tIApjaGVlcnMsCi1yb2dlcgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=