From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D956C18E5B for ; Tue, 10 Mar 2020 18:07:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id AC5D32146E for ; Tue, 10 Mar 2020 18:07:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NvQi3eK/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC5D32146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 58D564A4FC; Tue, 10 Mar 2020 14:07:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Ar2762ldZkP; Tue, 10 Mar 2020 14:07:13 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7C8F94A2E5; Tue, 10 Mar 2020 14:07:13 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 75B814A2E5 for ; Tue, 10 Mar 2020 14:07:12 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEkOI9RLnLuj for ; Tue, 10 Mar 2020 14:07:11 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 403664A1FA for ; Tue, 10 Mar 2020 14:07:11 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 110802146E; Tue, 10 Mar 2020 18:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583863630; bh=rHYS2dfliP5kBBFI8WXzNz2+NnXttJ2pOTUrYGHzrPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NvQi3eK//4yMrQUAifYnYu1PWXL+qiDJEyW/u+fxmWzYSscjcFAkzncBvknsJMDgu yJVMiSJom2dyM3axRabWI01RADaSXS3ohbIc7WSgmuyu7pFmH/xcwQop4RRQTv5EiD wIkQwTkihaIqbjVQ6J4yoIjMS4YMwZfM+Ge2tS48= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBjHY-00Bh7w-9n; Tue, 10 Mar 2020 18:07:08 +0000 MIME-Version: 1.0 Date: Tue, 10 Mar 2020 18:07:08 +0000 From: Marc Zyngier To: Auger Eric Subject: Re: [PATCH v2 2/2] KVM: arm64: Document PMU filtering API In-Reply-To: <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> References: <20200309124837.19908-1-maz@kernel.org> <20200309124837.19908-3-maz@kernel.org> <7943c896-013b-d9cb-ba89-2040b46437fe@redhat.com> <07f4ef9b5ff6c6c5086c9723c64c035f@kernel.org> <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> Message-ID: <79f80ab568138e1287d0a515e0caa98c@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, robin.murphy@arm.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin Murphy , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0wMy0xMCAxNzozMCwgQXVnZXIgRXJpYyB3cm90ZToKPiBIaSBNYXJjLAo+IAo+IE9u IDMvMTAvMjAgMTI6NTQgUE0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMC0wMy0wOSAx ODoxNywgQXVnZXIgRXJpYyB3cm90ZToKPj4+IEhpIE1hcmMsCj4+PiAKPj4+IE9uIDMvOS8yMCAx OjQ4IFBNLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gQWRkIGEgc21hbGwgYmx1cmIgZGVzY3Jp YmluZyBob3cgdGhlIGV2ZW50IGZpbHRlcmluZyBBUEkgZ2V0cyB1c2VkLgo+Pj4+IAo+Pj4+IFNp Z25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4+Pj4gLS0tCj4+Pj4g wqBEb2N1bWVudGF0aW9uL3ZpcnQva3ZtL2RldmljZXMvdmNwdS5yc3QgfCA0MCAKPj4+PiArKysr KysrKysrKysrKysrKysrKysrKysrCj4+Pj4gwqAxIGZpbGUgY2hhbmdlZCwgNDAgaW5zZXJ0aW9u cygrKQo+Pj4+IAo+Pj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3ZpcnQva3ZtL2Rldmlj ZXMvdmNwdS5yc3QKPj4+PiBiL0RvY3VtZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJz dAo+Pj4+IGluZGV4IDk5NjNlNjgwNzcwYS4uNzI2MmMwNDY5ODU2IDEwMDY0NAo+Pj4+IC0tLSBh L0RvY3VtZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJzdAo+Pj4+ICsrKyBiL0RvY3Vt ZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJzdAo+Pj4+IEBAIC01NSw2ICs1NSw0NiBA QCBSZXF1ZXN0IHRoZSBpbml0aWFsaXphdGlvbiBvZiB0aGUgUE1VdjMuwqAgSWYgCj4+Pj4gdXNp bmcKPj4+PiB0aGUgUE1VdjMgd2l0aCBhbiBpbi1rZXJuZWwKPj4+PiDCoHZpcnR1YWwgR0lDIGlt cGxlbWVudGF0aW9uLCB0aGlzIG11c3QgYmUgZG9uZSBhZnRlciBpbml0aWFsaXppbmcgCj4+Pj4g dGhlCj4+Pj4gaW4ta2VybmVsCj4+Pj4gwqBpcnFjaGlwLgo+Pj4+IAo+Pj4+ICsxLjMgQVRUUklC VVRFOiBLVk1fQVJNX1ZDUFVfUE1VX1YzX0ZJTFRFUgo+Pj4+ICstLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiArCj4+Pj4gKzpQYXJhbWV0ZXJzOiBpbiBrdm1fZGV2 aWNlX2F0dHIuYWRkciB0aGUgYWRkcmVzcyBmb3IgYSBQTVUgZXZlbnQKPj4+PiBmaWx0ZXIgaXMg YQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcG9pbnRlciB0byBhIHN0cnVjdCBrdm1f cG11X2V2ZW50X2ZpbHRlcgo+Pj4+ICsKPj4+PiArOlJldHVybnM6Cj4+Pj4gKwo+Pj4+ICvCoMKg wqDCoCA9PT09PT09wqAgCj4+Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Cj4+Pj4gK8KgwqDCoMKgIC1FTk9ERVY6IFBNVXYzIG5vdCBzdXBw b3J0ZWQgb3IgR0lDIG5vdCBpbml0aWFsaXplZAo+Pj4+ICvCoMKgwqDCoCAtRU5YSU86wqAgUE1V djMgbm90IHByb3Blcmx5IGNvbmZpZ3VyZWQgb3IgaW4ta2VybmVsIGlycWNoaXAgCj4+Pj4gbm90 Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbmZpZ3VyZWQgYXMgcmVxdWlyZWQgcHJpb3Ig dG8gY2FsbGluZyB0aGlzIGF0dHJpYnV0ZQo+Pj4+ICvCoMKgwqDCoCAtRUJVU1k6wqAgUE1VdjMg YWxyZWFkeSBpbml0aWFsaXplZAo+Pj4gbWF5YmUgZG9jdW1lbnQgLUVJTlZBTD8KPj4gCj4+IFl1 cCwgZGVmaW5pdGVseS4KPj4gCj4+Pj4gK8KgwqDCoMKgID09PT09PT3CoCAKPj4+PiA9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPj4+PiArCj4+ Pj4gK1JlcXVlc3QgdGhlIGluc3RhbGxhdGlvbiBvZiBhIFBNVSBldmVudCBmaWx0ZXIgZGVzY3Jp YmUgYXMgZm9sbG93czoKPj4+IHMvZGVzY3JpYmUvZGVzY3JpYmVkCj4+Pj4gKwo+Pj4+ICtzdHJ1 Y3Qga3ZtX3BtdV9ldmVudF9maWx0ZXIgewo+Pj4+ICvCoMKgwqAgX191MTbCoMKgwqAgYmFzZV9l dmVudDsKPj4+PiArwqDCoMKgIF9fdTE2wqDCoMKgIG5ldmVudHM7Cj4+Pj4gKwo+Pj4+ICsjZGVm aW5lIEtWTV9QTVVfRVZFTlRfQUxMT1fCoMKgwqAgMAo+Pj4+ICsjZGVmaW5lIEtWTV9QTVVfRVZF TlRfREVOWcKgwqDCoCAxCj4+Pj4gKwo+Pj4+ICvCoMKgwqAgX191OMKgwqDCoCBhY3Rpb247Cj4+ Pj4gK8KgwqDCoCBfX3U4wqDCoMKgIHBhZFszXTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gK0EgZmls dGVyIHJhbmdlIGlzIGRlZmluZWQgYXMgdGhlIHJhbmdlIFtAYmFzZV9ldmVudCwgQGJhc2VfZXZl bnQgKwo+Pj4+IEBuZXZlbnRzWywKPj4+PiArdG9nZXRoZXIgd2l0aCBhbiBAYWN0aW9uIChLVk1f UE1VX0VWRU5UX0FMTE9XIG9yCj4+Pj4gS1ZNX1BNVV9FVkVOVF9ERU5ZKS4gVGhlCj4+Pj4gK2Zp cnN0IHJlZ2lzdGVyZWQgcmFuZ2UgZGVmaW5lcyB0aGUgZ2xvYmFsIHBvbGljeSAoZ2xvYmFsIEFM TE9XIGlmCj4+Pj4gdGhlIGZpcnN0Cj4+Pj4gK0BhY3Rpb24gaXMgREVOWSwgZ2xvYmFsIERFTlkg aWYgdGhlIGZpcnN0IEBhY3Rpb24gaXMgQUxMT1cpLgo+Pj4+IE11bHRpcGxlIHJhbmdlcwo+Pj4+ ICtjYW4gYmUgcHJvZ3JhbW1lZCwgYW5kIG11c3QgZml0IHdpdGhpbiB0aGUgMTZiaXQgc3BhY2Ug ZGVmaW5lZCBieQo+Pj4+IHRoZSBBUk12OC4xCj4+Pj4gK1BNVSBhcmNoaXRlY3R1cmUuCj4+PiB3 aGF0IGFib3V0IGJlZm9yZSA4LjEgd2hlcmUgdGhlIHJhbmdlIHdhcyAxMCBiaXRzPyBTaG91bGQg aXQgYmUgCj4+PiB0ZXN0ZWQKPj4+IGluIHRoZSBjb2RlPwo+PiAKPj4gSXQncyBhIGdvb2QgcG9p bnQuIFdlIGNvdWxkIHRlc3QgdGhhdCB1cG9uIGluc3RhbGxpbmcgdGhlIGZpbHRlciBhbmQgCj4+ IGxpbWl0Cj4+IHRoZSBiaXRtYXAgYWxsb2NhdGlvbiB0byB0aGUgbWluaW11bS4KPj4gCj4+PiBu aXRwaWNraW5nOiBJdCBpcyBub3QgdG90YWxseSBvYnZpb3VzIHdoYXQgZG9lcyBoYXBwZW4gaWYg dGhlIHVzZXIgCj4+PiBzcGFjZQo+Pj4gc2V0cyBhIGRlbnkgZmlsdGVyIG9uIGEgcmFuZ2UgYW5k IHRoZW4gYW4gYWxsb3cgZmlsdGVyIG9uIHRoZSBzYW1lCj4+PiByYW5nZS4gaXQgaXMgc3VwcG9y dGVkIGJ1dCBtYXkgYmUgd29ydGggdGVsbGluZyBzbz8gQWxzbyBleHBsYWluIHRoZSAKPj4+IHRo ZQo+Pj4gZGVmYXVsdCBmaWx0ZXJpbmcgcmVtYWlucyAiYWxsb3ciIGJ5IGRlZmF1bHQ/Cj4+IAo+ PiBPdmVybGFwcGluZyBmaWx0ZXJzIGFyZSBlYXN5OiB0aGUgbGFzdCBvbmUgd2lucy4gQW5kIHll cywgbm8gZmlsdGVyIAo+PiBtZWFucwo+PiBqdXN0IHRoYXQ6IG5vIGZpbHRlci4KPiBBY3R1YWxs eSB0aGUgcG9pbnQgSSB3YW50ZWQgdG8gcHV0IGZvcndhcmQgaXMKPiAxKSBzZXQgYWxsb3cgZmls dGVyIG9uIHJhbmdlIFswLWFdIC0+IGRlZmF1bHQgc2V0dGluZyBpcyBkZW55IGFuZCBhbGxvdwo+ IFswLWFdIG9ubHkKPiAyKSBkZW55IGRlbnkgZmlsdGVyIG9uIHJhbmcgWzAtYV0gLT4gdGhlcmUg aXMgbm8gInJlYWwiIGFjdGl2ZSAKPiBmaWx0ZXJpbmcKPiBhbnltb3JlIGJ1dCBkZWZhdWx0IGJl aGF2aW9yIHN0aWxsIGlzIGRlbnkuIGllLiB5b3UgZG8gbm90IGRlc3Ryb3kgdGhlCj4gYml0bWFw IG9uIHRoZSBsYXN0IGZpbHRlciByZW1vdmFsIGJ1dCBvbiB0aGUgVk0gcmVtb3ZhbC4KCkFoLCBn b3RjaGEuIFllcywgdGhpcyBpcyBvZGQuIFRoZSBzb2x1dGlvbiB0byB0aGlzIGlzIHRvIHJlLWFw cGx5IGEgCmRlZmF1bHQKYmVoYXZpb3VyLiBCdXQgdGhpcyBuZWVkcyBkb2N1bWVudGluZy4uLgoK VGhhbmtzLAoKICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMg ZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8v bGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 483EAC10F27 for ; Tue, 10 Mar 2020 18:07:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E2502146E for ; Tue, 10 Mar 2020 18:07:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYh193DJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NvQi3eK/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E2502146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=045CqqdTw+r4FBg3boE57sHN0PSNAzQb8+4TIw1Tn4Y=; b=lYh193DJXYG4Kel1Uz3qJvKeE blfz4CWhzD0owy+Zu0NBC/4vhe7EO1/qBHDVZEtH6++hacb1s5S6lDaapfZ1zfctPj8lupCf+ZyM4 bwsSHJtFwDWWoTBzlx0wKcXtXwMT0oOQjrE1j52sHuZMiWIooVqQDx+Zc4B7bAuy/mkub2zF2zziI qn5EY19iwAPEBrMeakODKLfrvjPzA3xjKOkZ0y4Cy3D3H9D9dpJKzt29rz00RoF1ws2uBBopzTT03 sieZZrxBsWSEz79i5ef+5lXNgWgiGGn0oHzIbQvl0hfh4CH06R5NfaMCt40VjQkzn0C2CzhKL5lXe o+Wcd7iOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBjHe-0008E7-1O; Tue, 10 Mar 2020 18:07:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBjHa-0008Dc-H4 for linux-arm-kernel@lists.infradead.org; Tue, 10 Mar 2020 18:07:11 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 110802146E; Tue, 10 Mar 2020 18:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583863630; bh=rHYS2dfliP5kBBFI8WXzNz2+NnXttJ2pOTUrYGHzrPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NvQi3eK//4yMrQUAifYnYu1PWXL+qiDJEyW/u+fxmWzYSscjcFAkzncBvknsJMDgu yJVMiSJom2dyM3axRabWI01RADaSXS3ohbIc7WSgmuyu7pFmH/xcwQop4RRQTv5EiD wIkQwTkihaIqbjVQ6J4yoIjMS4YMwZfM+Ge2tS48= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBjHY-00Bh7w-9n; Tue, 10 Mar 2020 18:07:08 +0000 MIME-Version: 1.0 Date: Tue, 10 Mar 2020 18:07:08 +0000 From: Marc Zyngier To: Auger Eric Subject: Re: [PATCH v2 2/2] KVM: arm64: Document PMU filtering API In-Reply-To: <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> References: <20200309124837.19908-1-maz@kernel.org> <20200309124837.19908-3-maz@kernel.org> <7943c896-013b-d9cb-ba89-2040b46437fe@redhat.com> <07f4ef9b5ff6c6c5086c9723c64c035f@kernel.org> <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> Message-ID: <79f80ab568138e1287d0a515e0caa98c@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, robin.murphy@arm.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_110710_610641_C50005A6 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Suzuki K Poulose , James Morse , linux-arm-kernel@lists.infradead.org, Robin Murphy , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wMy0xMCAxNzozMCwgQXVnZXIgRXJpYyB3cm90ZToKPiBIaSBNYXJjLAo+IAo+IE9u IDMvMTAvMjAgMTI6NTQgUE0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMC0wMy0wOSAx ODoxNywgQXVnZXIgRXJpYyB3cm90ZToKPj4+IEhpIE1hcmMsCj4+PiAKPj4+IE9uIDMvOS8yMCAx OjQ4IFBNLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gQWRkIGEgc21hbGwgYmx1cmIgZGVzY3Jp YmluZyBob3cgdGhlIGV2ZW50IGZpbHRlcmluZyBBUEkgZ2V0cyB1c2VkLgo+Pj4+IAo+Pj4+IFNp Z25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4+Pj4gLS0tCj4+Pj4g wqBEb2N1bWVudGF0aW9uL3ZpcnQva3ZtL2RldmljZXMvdmNwdS5yc3QgfCA0MCAKPj4+PiArKysr KysrKysrKysrKysrKysrKysrKysrCj4+Pj4gwqAxIGZpbGUgY2hhbmdlZCwgNDAgaW5zZXJ0aW9u cygrKQo+Pj4+IAo+Pj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3ZpcnQva3ZtL2Rldmlj ZXMvdmNwdS5yc3QKPj4+PiBiL0RvY3VtZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJz dAo+Pj4+IGluZGV4IDk5NjNlNjgwNzcwYS4uNzI2MmMwNDY5ODU2IDEwMDY0NAo+Pj4+IC0tLSBh L0RvY3VtZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJzdAo+Pj4+ICsrKyBiL0RvY3Vt ZW50YXRpb24vdmlydC9rdm0vZGV2aWNlcy92Y3B1LnJzdAo+Pj4+IEBAIC01NSw2ICs1NSw0NiBA QCBSZXF1ZXN0IHRoZSBpbml0aWFsaXphdGlvbiBvZiB0aGUgUE1VdjMuwqAgSWYgCj4+Pj4gdXNp bmcKPj4+PiB0aGUgUE1VdjMgd2l0aCBhbiBpbi1rZXJuZWwKPj4+PiDCoHZpcnR1YWwgR0lDIGlt cGxlbWVudGF0aW9uLCB0aGlzIG11c3QgYmUgZG9uZSBhZnRlciBpbml0aWFsaXppbmcgCj4+Pj4g dGhlCj4+Pj4gaW4ta2VybmVsCj4+Pj4gwqBpcnFjaGlwLgo+Pj4+IAo+Pj4+ICsxLjMgQVRUUklC VVRFOiBLVk1fQVJNX1ZDUFVfUE1VX1YzX0ZJTFRFUgo+Pj4+ICstLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiArCj4+Pj4gKzpQYXJhbWV0ZXJzOiBpbiBrdm1fZGV2 aWNlX2F0dHIuYWRkciB0aGUgYWRkcmVzcyBmb3IgYSBQTVUgZXZlbnQKPj4+PiBmaWx0ZXIgaXMg YQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcG9pbnRlciB0byBhIHN0cnVjdCBrdm1f cG11X2V2ZW50X2ZpbHRlcgo+Pj4+ICsKPj4+PiArOlJldHVybnM6Cj4+Pj4gKwo+Pj4+ICvCoMKg wqDCoCA9PT09PT09wqAgCj4+Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Cj4+Pj4gK8KgwqDCoMKgIC1FTk9ERVY6IFBNVXYzIG5vdCBzdXBw b3J0ZWQgb3IgR0lDIG5vdCBpbml0aWFsaXplZAo+Pj4+ICvCoMKgwqDCoCAtRU5YSU86wqAgUE1V djMgbm90IHByb3Blcmx5IGNvbmZpZ3VyZWQgb3IgaW4ta2VybmVsIGlycWNoaXAgCj4+Pj4gbm90 Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbmZpZ3VyZWQgYXMgcmVxdWlyZWQgcHJpb3Ig dG8gY2FsbGluZyB0aGlzIGF0dHJpYnV0ZQo+Pj4+ICvCoMKgwqDCoCAtRUJVU1k6wqAgUE1VdjMg YWxyZWFkeSBpbml0aWFsaXplZAo+Pj4gbWF5YmUgZG9jdW1lbnQgLUVJTlZBTD8KPj4gCj4+IFl1 cCwgZGVmaW5pdGVseS4KPj4gCj4+Pj4gK8KgwqDCoMKgID09PT09PT3CoCAKPj4+PiA9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPj4+PiArCj4+ Pj4gK1JlcXVlc3QgdGhlIGluc3RhbGxhdGlvbiBvZiBhIFBNVSBldmVudCBmaWx0ZXIgZGVzY3Jp YmUgYXMgZm9sbG93czoKPj4+IHMvZGVzY3JpYmUvZGVzY3JpYmVkCj4+Pj4gKwo+Pj4+ICtzdHJ1 Y3Qga3ZtX3BtdV9ldmVudF9maWx0ZXIgewo+Pj4+ICvCoMKgwqAgX191MTbCoMKgwqAgYmFzZV9l dmVudDsKPj4+PiArwqDCoMKgIF9fdTE2wqDCoMKgIG5ldmVudHM7Cj4+Pj4gKwo+Pj4+ICsjZGVm aW5lIEtWTV9QTVVfRVZFTlRfQUxMT1fCoMKgwqAgMAo+Pj4+ICsjZGVmaW5lIEtWTV9QTVVfRVZF TlRfREVOWcKgwqDCoCAxCj4+Pj4gKwo+Pj4+ICvCoMKgwqAgX191OMKgwqDCoCBhY3Rpb247Cj4+ Pj4gK8KgwqDCoCBfX3U4wqDCoMKgIHBhZFszXTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gK0EgZmls dGVyIHJhbmdlIGlzIGRlZmluZWQgYXMgdGhlIHJhbmdlIFtAYmFzZV9ldmVudCwgQGJhc2VfZXZl bnQgKwo+Pj4+IEBuZXZlbnRzWywKPj4+PiArdG9nZXRoZXIgd2l0aCBhbiBAYWN0aW9uIChLVk1f UE1VX0VWRU5UX0FMTE9XIG9yCj4+Pj4gS1ZNX1BNVV9FVkVOVF9ERU5ZKS4gVGhlCj4+Pj4gK2Zp cnN0IHJlZ2lzdGVyZWQgcmFuZ2UgZGVmaW5lcyB0aGUgZ2xvYmFsIHBvbGljeSAoZ2xvYmFsIEFM TE9XIGlmCj4+Pj4gdGhlIGZpcnN0Cj4+Pj4gK0BhY3Rpb24gaXMgREVOWSwgZ2xvYmFsIERFTlkg aWYgdGhlIGZpcnN0IEBhY3Rpb24gaXMgQUxMT1cpLgo+Pj4+IE11bHRpcGxlIHJhbmdlcwo+Pj4+ ICtjYW4gYmUgcHJvZ3JhbW1lZCwgYW5kIG11c3QgZml0IHdpdGhpbiB0aGUgMTZiaXQgc3BhY2Ug ZGVmaW5lZCBieQo+Pj4+IHRoZSBBUk12OC4xCj4+Pj4gK1BNVSBhcmNoaXRlY3R1cmUuCj4+PiB3 aGF0IGFib3V0IGJlZm9yZSA4LjEgd2hlcmUgdGhlIHJhbmdlIHdhcyAxMCBiaXRzPyBTaG91bGQg aXQgYmUgCj4+PiB0ZXN0ZWQKPj4+IGluIHRoZSBjb2RlPwo+PiAKPj4gSXQncyBhIGdvb2QgcG9p bnQuIFdlIGNvdWxkIHRlc3QgdGhhdCB1cG9uIGluc3RhbGxpbmcgdGhlIGZpbHRlciBhbmQgCj4+ IGxpbWl0Cj4+IHRoZSBiaXRtYXAgYWxsb2NhdGlvbiB0byB0aGUgbWluaW11bS4KPj4gCj4+PiBu aXRwaWNraW5nOiBJdCBpcyBub3QgdG90YWxseSBvYnZpb3VzIHdoYXQgZG9lcyBoYXBwZW4gaWYg dGhlIHVzZXIgCj4+PiBzcGFjZQo+Pj4gc2V0cyBhIGRlbnkgZmlsdGVyIG9uIGEgcmFuZ2UgYW5k IHRoZW4gYW4gYWxsb3cgZmlsdGVyIG9uIHRoZSBzYW1lCj4+PiByYW5nZS4gaXQgaXMgc3VwcG9y dGVkIGJ1dCBtYXkgYmUgd29ydGggdGVsbGluZyBzbz8gQWxzbyBleHBsYWluIHRoZSAKPj4+IHRo ZQo+Pj4gZGVmYXVsdCBmaWx0ZXJpbmcgcmVtYWlucyAiYWxsb3ciIGJ5IGRlZmF1bHQ/Cj4+IAo+ PiBPdmVybGFwcGluZyBmaWx0ZXJzIGFyZSBlYXN5OiB0aGUgbGFzdCBvbmUgd2lucy4gQW5kIHll cywgbm8gZmlsdGVyIAo+PiBtZWFucwo+PiBqdXN0IHRoYXQ6IG5vIGZpbHRlci4KPiBBY3R1YWxs eSB0aGUgcG9pbnQgSSB3YW50ZWQgdG8gcHV0IGZvcndhcmQgaXMKPiAxKSBzZXQgYWxsb3cgZmls dGVyIG9uIHJhbmdlIFswLWFdIC0+IGRlZmF1bHQgc2V0dGluZyBpcyBkZW55IGFuZCBhbGxvdwo+ IFswLWFdIG9ubHkKPiAyKSBkZW55IGRlbnkgZmlsdGVyIG9uIHJhbmcgWzAtYV0gLT4gdGhlcmUg aXMgbm8gInJlYWwiIGFjdGl2ZSAKPiBmaWx0ZXJpbmcKPiBhbnltb3JlIGJ1dCBkZWZhdWx0IGJl aGF2aW9yIHN0aWxsIGlzIGRlbnkuIGllLiB5b3UgZG8gbm90IGRlc3Ryb3kgdGhlCj4gYml0bWFw IG9uIHRoZSBsYXN0IGZpbHRlciByZW1vdmFsIGJ1dCBvbiB0aGUgVk0gcmVtb3ZhbC4KCkFoLCBn b3RjaGEuIFllcywgdGhpcyBpcyBvZGQuIFRoZSBzb2x1dGlvbiB0byB0aGlzIGlzIHRvIHJlLWFw cGx5IGEgCmRlZmF1bHQKYmVoYXZpb3VyLiBCdXQgdGhpcyBuZWVkcyBkb2N1bWVudGluZy4uLgoK VGhhbmtzLAoKICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMg ZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D882C10F27 for ; Tue, 10 Mar 2020 18:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27CCA21D56 for ; Tue, 10 Mar 2020 18:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583863632; bh=rHYS2dfliP5kBBFI8WXzNz2+NnXttJ2pOTUrYGHzrPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VgW1hK6It6ehtWO43OvvNrT6Iy4A/DO/y21WY6iopXrmuFpSZiIC/V545OzFDa7Xy ZwNIwStrkkUc7cNrUrsnFpu65TdVQOMO14PmlfwEru7O+uBtpn/4P40ncc2lBwccZt zp58TJnvr+Mt4xDdu+x56LUYK0/7qgPiZZii2J2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbgCJSHL (ORCPT ); Tue, 10 Mar 2020 14:07:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:52126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgCJSHL (ORCPT ); Tue, 10 Mar 2020 14:07:11 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 110802146E; Tue, 10 Mar 2020 18:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583863630; bh=rHYS2dfliP5kBBFI8WXzNz2+NnXttJ2pOTUrYGHzrPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NvQi3eK//4yMrQUAifYnYu1PWXL+qiDJEyW/u+fxmWzYSscjcFAkzncBvknsJMDgu yJVMiSJom2dyM3axRabWI01RADaSXS3ohbIc7WSgmuyu7pFmH/xcwQop4RRQTv5EiD wIkQwTkihaIqbjVQ6J4yoIjMS4YMwZfM+Ge2tS48= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBjHY-00Bh7w-9n; Tue, 10 Mar 2020 18:07:08 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 10 Mar 2020 18:07:08 +0000 From: Marc Zyngier To: Auger Eric Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Julien Thierry , Suzuki K Poulose , Robin Murphy , Mark Rutland Subject: Re: [PATCH v2 2/2] KVM: arm64: Document PMU filtering API In-Reply-To: <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> References: <20200309124837.19908-1-maz@kernel.org> <20200309124837.19908-3-maz@kernel.org> <7943c896-013b-d9cb-ba89-2040b46437fe@redhat.com> <07f4ef9b5ff6c6c5086c9723c64c035f@kernel.org> <867c7926-df43-7ab0-d20a-211a59d7612d@redhat.com> Message-ID: <79f80ab568138e1287d0a515e0caa98c@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, robin.murphy@arm.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-03-10 17:30, Auger Eric wrote: > Hi Marc, > > On 3/10/20 12:54 PM, Marc Zyngier wrote: >> On 2020-03-09 18:17, Auger Eric wrote: >>> Hi Marc, >>> >>> On 3/9/20 1:48 PM, Marc Zyngier wrote: >>>> Add a small blurb describing how the event filtering API gets used. >>>> >>>> Signed-off-by: Marc Zyngier >>>> --- >>>>  Documentation/virt/kvm/devices/vcpu.rst | 40 >>>> +++++++++++++++++++++++++ >>>>  1 file changed, 40 insertions(+) >>>> >>>> diff --git a/Documentation/virt/kvm/devices/vcpu.rst >>>> b/Documentation/virt/kvm/devices/vcpu.rst >>>> index 9963e680770a..7262c0469856 100644 >>>> --- a/Documentation/virt/kvm/devices/vcpu.rst >>>> +++ b/Documentation/virt/kvm/devices/vcpu.rst >>>> @@ -55,6 +55,46 @@ Request the initialization of the PMUv3.  If >>>> using >>>> the PMUv3 with an in-kernel >>>>  virtual GIC implementation, this must be done after initializing >>>> the >>>> in-kernel >>>>  irqchip. >>>> >>>> +1.3 ATTRIBUTE: KVM_ARM_VCPU_PMU_V3_FILTER >>>> +--------------------------------------- >>>> + >>>> +:Parameters: in kvm_device_attr.addr the address for a PMU event >>>> filter is a >>>> +             pointer to a struct kvm_pmu_event_filter >>>> + >>>> +:Returns: >>>> + >>>> +     =======  >>>> ====================================================== >>>> +     -ENODEV: PMUv3 not supported or GIC not initialized >>>> +     -ENXIO:  PMUv3 not properly configured or in-kernel irqchip >>>> not >>>> +           configured as required prior to calling this attribute >>>> +     -EBUSY:  PMUv3 already initialized >>> maybe document -EINVAL? >> >> Yup, definitely. >> >>>> +     =======  >>>> ====================================================== >>>> + >>>> +Request the installation of a PMU event filter describe as follows: >>> s/describe/described >>>> + >>>> +struct kvm_pmu_event_filter { >>>> +    __u16    base_event; >>>> +    __u16    nevents; >>>> + >>>> +#define KVM_PMU_EVENT_ALLOW    0 >>>> +#define KVM_PMU_EVENT_DENY    1 >>>> + >>>> +    __u8    action; >>>> +    __u8    pad[3]; >>>> +}; >>>> + >>>> +A filter range is defined as the range [@base_event, @base_event + >>>> @nevents[, >>>> +together with an @action (KVM_PMU_EVENT_ALLOW or >>>> KVM_PMU_EVENT_DENY). The >>>> +first registered range defines the global policy (global ALLOW if >>>> the first >>>> +@action is DENY, global DENY if the first @action is ALLOW). >>>> Multiple ranges >>>> +can be programmed, and must fit within the 16bit space defined by >>>> the ARMv8.1 >>>> +PMU architecture. >>> what about before 8.1 where the range was 10 bits? Should it be >>> tested >>> in the code? >> >> It's a good point. We could test that upon installing the filter and >> limit >> the bitmap allocation to the minimum. >> >>> nitpicking: It is not totally obvious what does happen if the user >>> space >>> sets a deny filter on a range and then an allow filter on the same >>> range. it is supported but may be worth telling so? Also explain the >>> the >>> default filtering remains "allow" by default? >> >> Overlapping filters are easy: the last one wins. And yes, no filter >> means >> just that: no filter. > Actually the point I wanted to put forward is > 1) set allow filter on range [0-a] -> default setting is deny and allow > [0-a] only > 2) deny deny filter on rang [0-a] -> there is no "real" active > filtering > anymore but default behavior still is deny. ie. you do not destroy the > bitmap on the last filter removal but on the VM removal. Ah, gotcha. Yes, this is odd. The solution to this is to re-apply a default behaviour. But this needs documenting... Thanks, M. -- Jazz is not dead. It just smells funny...