From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C800714A94; Mon, 19 Jun 2023 20:18:32 +0000 (UTC) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45A8FD3; Mon, 19 Jun 2023 13:18:30 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso3185177a12.3; Mon, 19 Jun 2023 13:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=ML1POuSF5TNYpNiqkU7Wmm/FZLBDFoP32DY+WPylpmv43DoaA/AoXnTGG2wwzhld3j kjkKToRZCKl1S0ycKV+IUNrHAQ8Dvck3h+D7ZuCxy/PFvkOP44vPViwvWsYYl0BBuNgy b/5HPeUCxmK/jPGro6a0V6gtwlQJxSWG+MjbaRDV7mR48t508gCxLWi7cw8WSlTAdLEO 3p+win9LgLE5lOsK+rw7eJ7na0iRAHUh7i2pWPNrn0k/YllS2kfgOgB31VmT4hCseChr k2Wm+WLNvD9nhPcsjkRc0OVcXyGOSUiyWGCOpqitL1ReK2kli6NusXAAxFAtCrHDui7k NzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=It+aTU9JCM2y7jL4p7lJlCjfG6o20JcbSLehxu66Jm7q+BrmhwyasusDO7rtoEYi0K NQC42j8tDLAiznlhd9DM+8ji0LNBcwmYv4s6Wd5EYYYOgs2BLMp/9JZJf2MEorJpzz15 qYBYq6EcyQwBh68GSgejoX8hbxuwkwUmA5iFIiIo+L9ktPqpHDfCefrQVFH4t5HymodN VMMjSjzQrvwLpQnZk3AFvwIDid3Ym95fETh/4F/BAzBwmlRgfZ+IRx6cYR0NX/uJMgC3 VRJi8WxiHl5cSH+u4ZFuCqDwUL4XbrpqAshCkqXHXDL3mBanL547g8fkomBST3m8drWn PKRw== X-Gm-Message-State: AC+VfDxw8bplcNLipbtq/ZaFPEuPUKARHC4Hn+6fqHRohKEldkAiOKiB LaBTrPeAOLr9MLpyTpcTXXM= X-Google-Smtp-Source: ACHHUZ4MAGz/Bbdlo+4DcmVI4O990mBmojRaVLNYuDWhcs7i7MC/1uf1G62Dkn3iaVvHJNN3c8J+8g== X-Received: by 2002:a05:6a21:78a9:b0:10a:cb95:5aa3 with SMTP id bf41-20020a056a2178a900b0010acb955aa3mr14231287pzc.7.1687205909086; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id k18-20020a637b52000000b005538bf7e3d6sm87568pgn.88.2023.06.19.13.18.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 13:18:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text_alloc() From: Nadav Amit In-Reply-To: Date: Mon, 19 Jun 2023 13:18:15 -0700 Cc: Mike Rapoport , Mark Rutland , Kees Cook , Linux Kernel Mailing List , Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick P Edgecombe , "Russell King (Oracle)" , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390 , linux-trace-kernel@vger.kernel.org, linuxppc-dev , loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, the arch/x86 maintainers Content-Transfer-Encoding: quoted-printable Message-Id: <7F566E60-C371-449B-992B-0C435AD6016B@gmail.com> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-3-rppt@kernel.org> <20230618080027.GA52412@kernel.org> To: Andy Lutomirski , Song Liu X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > On Jun 19, 2023, at 10:09 AM, Andy Lutomirski wrote: >=20 > But jit_text_alloc() can't do this, because the order of operations = doesn't match. With jit_text_alloc(), the executable mapping shows up = before the text is populated, so there is no atomic change from = not-there to populated-and-executable. Which means that there is an = opportunity for CPUs, speculatively or otherwise, to start filling = various caches with intermediate states of the text, which means that = various architectures (even x86!) may need serialization. >=20 > For eBPF- and module- like use cases, where JITting/code gen is quite = coarse-grained, perhaps something vaguely like: >=20 > jit_text_alloc() -> returns a handle and an executable virtual = address, but does *not* map it there > jit_text_write() -> write to that handle > jit_text_map() -> map it and synchronize if needed (no sync needed on = x86, I think) Andy, would you mind explaining why you think a sync is not needed? I = mean I have a =E2=80=9Cfeeling=E2=80=9D that perhaps TSO can guarantee = something based on the order of write and page-table update. Is that the = argument? On this regard, one thing that I clearly do not understand is why = *today* it is ok for users of bpf_arch_text_copy() not to call = text_poke_sync(). Am I missing something? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04177EB64D9 for ; Mon, 19 Jun 2023 20:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4WyrvDaBvcjQGOkvut/Pn6LcdQgAIFAAFuk/tYVOcmA=; b=PA+vksX0W8C1eC ycNim3QTMIFUzhmNdsACDv5+isTTJNloqrFfcuILJgYD7Dl/oTK8gtJ37Y5xipVv6U7U3qPOeZkwM 6MVoJCAfb/9xZiKbmorBbScQJHV8yAECc3j/9pT11PygXhZqfB7l3Ii6cJSjaA/BCCRgAQ5hzoqET 4BI9l1eK+FsrQO/fW1BL1sZHWhKicOhpDspaSfNNCUAc0qi6aJGwzv6Kk7QBil4IpXVAoqxMBtSf7 C2CbE41arsHkfQmUqHew4JgNLsNJwA6R/6bliMnrqAuBWAV6+I0gTH6JqV84T3CZUTzrpmPVY0lnx 2MR8RNYbNGPee5g4rKEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBLKc-009PO1-1K; Mon, 19 Jun 2023 20:18:34 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBLKY-009PMH-2k; Mon, 19 Jun 2023 20:18:32 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-544c0d768b9so3195442a12.0; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=ML1POuSF5TNYpNiqkU7Wmm/FZLBDFoP32DY+WPylpmv43DoaA/AoXnTGG2wwzhld3j kjkKToRZCKl1S0ycKV+IUNrHAQ8Dvck3h+D7ZuCxy/PFvkOP44vPViwvWsYYl0BBuNgy b/5HPeUCxmK/jPGro6a0V6gtwlQJxSWG+MjbaRDV7mR48t508gCxLWi7cw8WSlTAdLEO 3p+win9LgLE5lOsK+rw7eJ7na0iRAHUh7i2pWPNrn0k/YllS2kfgOgB31VmT4hCseChr k2Wm+WLNvD9nhPcsjkRc0OVcXyGOSUiyWGCOpqitL1ReK2kli6NusXAAxFAtCrHDui7k NzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=hWDfgRM6ALmXlJUwpJ+lBxdSC4pchhy4Ct6Zr72FJeMejY5AzFmgX2Inq9bgWtFD72 UjZplI6kPC+5+IMb2nxnNuxxYaz/XWy7/ktRyeFYh/jkxh1IDqh9JpNj2oxCav69nL+s w3w81prRsDi3o1KMrgbxhsorbmTVCqavHX/SczdzOVi4TJhjU9FK0tQYQuFb0KLh8puR FNqarNhzDM3mDkL9GGcq/+/en5vuVeiyC/8MqeLQ+A2tf6k0C4GpRn/LCeUMqhnsBXl0 4efF3DNjYLOHLONL9AU5wem1EHTRldDDff5SpcasaYYmQaCmzDGs8oGLfv0xLazudQQ3 3gMQ== X-Gm-Message-State: AC+VfDxtNQKUgcDb1e/hoLhmjRxdUKdn091bXSUb2Vt5ras0Cvr9TucN x9I0v+SDnJ1OkxtV+al2wr4= X-Google-Smtp-Source: ACHHUZ4MAGz/Bbdlo+4DcmVI4O990mBmojRaVLNYuDWhcs7i7MC/1uf1G62Dkn3iaVvHJNN3c8J+8g== X-Received: by 2002:a05:6a21:78a9:b0:10a:cb95:5aa3 with SMTP id bf41-20020a056a2178a900b0010acb955aa3mr14231287pzc.7.1687205909086; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id k18-20020a637b52000000b005538bf7e3d6sm87568pgn.88.2023.06.19.13.18.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 13:18:28 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text_alloc() From: Nadav Amit In-Reply-To: Date: Mon, 19 Jun 2023 13:18:15 -0700 Cc: Mike Rapoport , Mark Rutland , Kees Cook , Linux Kernel Mailing List , Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick P Edgecombe , "Russell King (Oracle)" , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390 , linux-trace-kernel@vger.kernel.org, linuxppc-dev , loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, the arch/x86 maintainers Message-Id: <7F566E60-C371-449B-992B-0C435AD6016B@gmail.com> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-3-rppt@kernel.org> <20230618080027.GA52412@kernel.org> To: Andy Lutomirski , Song Liu X-Mailer: Apple Mail (2.3731.600.7) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230619_131830_889772_6859CB30 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Cgo+IE9uIEp1biAxOSwgMjAyMywgYXQgMTA6MDkgQU0sIEFuZHkgTHV0b21pcnNraSA8bHV0b0Br ZXJuZWwub3JnPiB3cm90ZToKPiAKPiBCdXQgaml0X3RleHRfYWxsb2MoKSBjYW4ndCBkbyB0aGlz LCBiZWNhdXNlIHRoZSBvcmRlciBvZiBvcGVyYXRpb25zIGRvZXNuJ3QgbWF0Y2guICBXaXRoIGpp dF90ZXh0X2FsbG9jKCksIHRoZSBleGVjdXRhYmxlIG1hcHBpbmcgc2hvd3MgdXAgYmVmb3JlIHRo ZSB0ZXh0IGlzIHBvcHVsYXRlZCwgc28gdGhlcmUgaXMgbm8gYXRvbWljIGNoYW5nZSBmcm9tIG5v dC10aGVyZSB0byBwb3B1bGF0ZWQtYW5kLWV4ZWN1dGFibGUuICBXaGljaCBtZWFucyB0aGF0IHRo ZXJlIGlzIGFuIG9wcG9ydHVuaXR5IGZvciBDUFVzLCBzcGVjdWxhdGl2ZWx5IG9yIG90aGVyd2lz ZSwgdG8gc3RhcnQgZmlsbGluZyB2YXJpb3VzIGNhY2hlcyB3aXRoIGludGVybWVkaWF0ZSBzdGF0 ZXMgb2YgdGhlIHRleHQsIHdoaWNoIG1lYW5zIHRoYXQgdmFyaW91cyBhcmNoaXRlY3R1cmVzIChl dmVuIHg4NiEpIG1heSBuZWVkIHNlcmlhbGl6YXRpb24uCj4gCj4gRm9yIGVCUEYtIGFuZCBtb2R1 bGUtIGxpa2UgdXNlIGNhc2VzLCB3aGVyZSBKSVR0aW5nL2NvZGUgZ2VuIGlzIHF1aXRlIGNvYXJz ZS1ncmFpbmVkLCBwZXJoYXBzIHNvbWV0aGluZyB2YWd1ZWx5IGxpa2U6Cj4gCj4gaml0X3RleHRf YWxsb2MoKSAtPiByZXR1cm5zIGEgaGFuZGxlIGFuZCBhbiBleGVjdXRhYmxlIHZpcnR1YWwgYWRk cmVzcywgYnV0IGRvZXMgKm5vdCogbWFwIGl0IHRoZXJlCj4gaml0X3RleHRfd3JpdGUoKSAtPiB3 cml0ZSB0byB0aGF0IGhhbmRsZQo+IGppdF90ZXh0X21hcCgpIC0+IG1hcCBpdCBhbmQgc3luY2hy b25pemUgaWYgbmVlZGVkIChubyBzeW5jIG5lZWRlZCBvbiB4ODYsIEkgdGhpbmspCgpBbmR5LCB3 b3VsZCB5b3UgbWluZCBleHBsYWluaW5nIHdoeSB5b3UgdGhpbmsgYSBzeW5jIGlzIG5vdCBuZWVk ZWQ/IEkgbWVhbiBJIGhhdmUgYSDigJxmZWVsaW5n4oCdIHRoYXQgcGVyaGFwcyBUU08gY2FuIGd1 YXJhbnRlZSBzb21ldGhpbmcgYmFzZWQgb24gdGhlIG9yZGVyIG9mIHdyaXRlIGFuZCBwYWdlLXRh YmxlIHVwZGF0ZS4gSXMgdGhhdCB0aGUgYXJndW1lbnQ/CgpPbiB0aGlzIHJlZ2FyZCwgb25lIHRo aW5nIHRoYXQgSSBjbGVhcmx5IGRvIG5vdCB1bmRlcnN0YW5kIGlzIHdoeSAqdG9kYXkqIGl0IGlz IG9rIGZvciB1c2VycyBvZiBicGZfYXJjaF90ZXh0X2NvcHkoKSBub3QgdG8gY2FsbCB0ZXh0X3Bv a2Vfc3luYygpLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51 eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3DF7EB64D9 for ; Mon, 19 Jun 2023 20:19:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=ML1POuSF; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QlLhZ0n9xz30hW for ; Tue, 20 Jun 2023 06:19:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=ML1POuSF; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=nadav.amit@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QlLgZ3Yncz30MY for ; Tue, 20 Jun 2023 06:18:32 +1000 (AEST) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-544c0d768b9so3195443a12.0 for ; Mon, 19 Jun 2023 13:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=ML1POuSF5TNYpNiqkU7Wmm/FZLBDFoP32DY+WPylpmv43DoaA/AoXnTGG2wwzhld3j kjkKToRZCKl1S0ycKV+IUNrHAQ8Dvck3h+D7ZuCxy/PFvkOP44vPViwvWsYYl0BBuNgy b/5HPeUCxmK/jPGro6a0V6gtwlQJxSWG+MjbaRDV7mR48t508gCxLWi7cw8WSlTAdLEO 3p+win9LgLE5lOsK+rw7eJ7na0iRAHUh7i2pWPNrn0k/YllS2kfgOgB31VmT4hCseChr k2Wm+WLNvD9nhPcsjkRc0OVcXyGOSUiyWGCOpqitL1ReK2kli6NusXAAxFAtCrHDui7k NzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=J4EeK1E/5Zd+SN2ghRODX28pSpjVLJb6LN3jYcjcSXL5LLL/qDxqeWL7vLwBeYMOlC 1t9lHIhaxh8+CxPy9qi+b2Xlc26T68EAR913flIwwOiTbJphpKb7ICx2/csd24A1Ccku HXrbTbREoLCB5eWl6JnIfyU0+Bdb2ioXE2dOUVsX21c58sZkvapTRSatRb35Jw+zTO26 nRJeh+cZuge1zEYyOOnCQi2yQNOyQ2GN25m61qgz0So4uG3mmWUy5vK6/j/DZpdjUTIJ WEN5i+p/F26lVbaXX7RaA1Kky4taXS1A8iXX6R6kbKHaIZvQ7FmCq5RvU+7GLKZqMAYF vL6A== X-Gm-Message-State: AC+VfDyIzooHHFSrJfYEbaBUcsCMTsdPB0zAdDNF7EScjeLzbHPPXm86 1JcbwXeHprGsIhssjWppYIM= X-Google-Smtp-Source: ACHHUZ4MAGz/Bbdlo+4DcmVI4O990mBmojRaVLNYuDWhcs7i7MC/1uf1G62Dkn3iaVvHJNN3c8J+8g== X-Received: by 2002:a05:6a21:78a9:b0:10a:cb95:5aa3 with SMTP id bf41-20020a056a2178a900b0010acb955aa3mr14231287pzc.7.1687205909086; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id k18-20020a637b52000000b005538bf7e3d6sm87568pgn.88.2023.06.19.13.18.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 13:18:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text_alloc() From: Nadav Amit In-Reply-To: Date: Mon, 19 Jun 2023 13:18:15 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <7F566E60-C371-449B-992B-0C435AD6016B@gmail.com> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-3-rppt@kernel.org> <20230618080027.GA52412@kernel.org> To: Andy Lutomirski , Song Liu X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , the arch/x86 maintainers , Catalin Marinas , linux-mips@vger.kernel.org, linux-mm , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390 , Helge Deller , Huacai Chen , "Russell King \(Oracle\)" , "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, Kees Cook , Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , bpf , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Puranjay Mohan , netdev@vger.kernel.org, Kent Overstreet , Linux Kernel Mailing List , Dinh Nguyen , Luis Chamberlain , Palmer Dabbelt , linux-modules@vger.kernel.org, Andrew Morton , Rick P Edgecombe , linuxppc-dev , "David S. Miller" , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > On Jun 19, 2023, at 10:09 AM, Andy Lutomirski wrote: >=20 > But jit_text_alloc() can't do this, because the order of operations = doesn't match. With jit_text_alloc(), the executable mapping shows up = before the text is populated, so there is no atomic change from = not-there to populated-and-executable. Which means that there is an = opportunity for CPUs, speculatively or otherwise, to start filling = various caches with intermediate states of the text, which means that = various architectures (even x86!) may need serialization. >=20 > For eBPF- and module- like use cases, where JITting/code gen is quite = coarse-grained, perhaps something vaguely like: >=20 > jit_text_alloc() -> returns a handle and an executable virtual = address, but does *not* map it there > jit_text_write() -> write to that handle > jit_text_map() -> map it and synchronize if needed (no sync needed on = x86, I think) Andy, would you mind explaining why you think a sync is not needed? I = mean I have a =E2=80=9Cfeeling=E2=80=9D that perhaps TSO can guarantee = something based on the order of write and page-table update. Is that the = argument? On this regard, one thing that I clearly do not understand is why = *today* it is ok for users of bpf_arch_text_copy() not to call = text_poke_sync(). Am I missing something? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9DDDEB64D9 for ; Mon, 19 Jun 2023 20:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z7wOSd8jQVQerrMsOSRRR3u9Alt6O6KNNaAaM4CGqn0=; b=mvEAkzGtlRkbYo zXF9aIlAY/d3+Wuy0JYXkwT2VvXymMlRFV2HoQdAkB/GSE771DhmYaS4KaNARcLLJnRcE9kbdpuvK 10oatnn6XM5eQX/09Q8AhwRUqUxTMbGX0wlBl7S08ItVxCotZp/bwjEli5Ar6N2rKAEjUMgHzfOhH kyQrapJYJE+cOFB0QXGOXkbyJNU56V8rruJovV8YO7aYlDEhmPiudw4vhmZMP0sF807ps/9P4BKHc 4NI67GIUTuoWfC9nFId6tkLe954lJ4MnBmBQQjN375BVvB7Oqli3z1V/DxvKCzOiX1HBhyrtAFhl1 ywcVumatpBmib8n279rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBLKb-009PNT-35; Mon, 19 Jun 2023 20:18:33 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBLKY-009PMH-2k; Mon, 19 Jun 2023 20:18:32 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-544c0d768b9so3195442a12.0; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=ML1POuSF5TNYpNiqkU7Wmm/FZLBDFoP32DY+WPylpmv43DoaA/AoXnTGG2wwzhld3j kjkKToRZCKl1S0ycKV+IUNrHAQ8Dvck3h+D7ZuCxy/PFvkOP44vPViwvWsYYl0BBuNgy b/5HPeUCxmK/jPGro6a0V6gtwlQJxSWG+MjbaRDV7mR48t508gCxLWi7cw8WSlTAdLEO 3p+win9LgLE5lOsK+rw7eJ7na0iRAHUh7i2pWPNrn0k/YllS2kfgOgB31VmT4hCseChr k2Wm+WLNvD9nhPcsjkRc0OVcXyGOSUiyWGCOpqitL1ReK2kli6NusXAAxFAtCrHDui7k NzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687205909; x=1689797909; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmEEut0OCJI0jheFei8v4KFIgPFEx+9Zr0oYZPTVJvw=; b=hWDfgRM6ALmXlJUwpJ+lBxdSC4pchhy4Ct6Zr72FJeMejY5AzFmgX2Inq9bgWtFD72 UjZplI6kPC+5+IMb2nxnNuxxYaz/XWy7/ktRyeFYh/jkxh1IDqh9JpNj2oxCav69nL+s w3w81prRsDi3o1KMrgbxhsorbmTVCqavHX/SczdzOVi4TJhjU9FK0tQYQuFb0KLh8puR FNqarNhzDM3mDkL9GGcq/+/en5vuVeiyC/8MqeLQ+A2tf6k0C4GpRn/LCeUMqhnsBXl0 4efF3DNjYLOHLONL9AU5wem1EHTRldDDff5SpcasaYYmQaCmzDGs8oGLfv0xLazudQQ3 3gMQ== X-Gm-Message-State: AC+VfDxtNQKUgcDb1e/hoLhmjRxdUKdn091bXSUb2Vt5ras0Cvr9TucN x9I0v+SDnJ1OkxtV+al2wr4= X-Google-Smtp-Source: ACHHUZ4MAGz/Bbdlo+4DcmVI4O990mBmojRaVLNYuDWhcs7i7MC/1uf1G62Dkn3iaVvHJNN3c8J+8g== X-Received: by 2002:a05:6a21:78a9:b0:10a:cb95:5aa3 with SMTP id bf41-20020a056a2178a900b0010acb955aa3mr14231287pzc.7.1687205909086; Mon, 19 Jun 2023 13:18:29 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id k18-20020a637b52000000b005538bf7e3d6sm87568pgn.88.2023.06.19.13.18.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 13:18:28 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text_alloc() From: Nadav Amit In-Reply-To: Date: Mon, 19 Jun 2023 13:18:15 -0700 Cc: Mike Rapoport , Mark Rutland , Kees Cook , Linux Kernel Mailing List , Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick P Edgecombe , "Russell King (Oracle)" , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390 , linux-trace-kernel@vger.kernel.org, linuxppc-dev , loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, the arch/x86 maintainers Message-Id: <7F566E60-C371-449B-992B-0C435AD6016B@gmail.com> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-3-rppt@kernel.org> <20230618080027.GA52412@kernel.org> To: Andy Lutomirski , Song Liu X-Mailer: Apple Mail (2.3731.600.7) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230619_131830_889772_6859CB30 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Cgo+IE9uIEp1biAxOSwgMjAyMywgYXQgMTA6MDkgQU0sIEFuZHkgTHV0b21pcnNraSA8bHV0b0Br ZXJuZWwub3JnPiB3cm90ZToKPiAKPiBCdXQgaml0X3RleHRfYWxsb2MoKSBjYW4ndCBkbyB0aGlz LCBiZWNhdXNlIHRoZSBvcmRlciBvZiBvcGVyYXRpb25zIGRvZXNuJ3QgbWF0Y2guICBXaXRoIGpp dF90ZXh0X2FsbG9jKCksIHRoZSBleGVjdXRhYmxlIG1hcHBpbmcgc2hvd3MgdXAgYmVmb3JlIHRo ZSB0ZXh0IGlzIHBvcHVsYXRlZCwgc28gdGhlcmUgaXMgbm8gYXRvbWljIGNoYW5nZSBmcm9tIG5v dC10aGVyZSB0byBwb3B1bGF0ZWQtYW5kLWV4ZWN1dGFibGUuICBXaGljaCBtZWFucyB0aGF0IHRo ZXJlIGlzIGFuIG9wcG9ydHVuaXR5IGZvciBDUFVzLCBzcGVjdWxhdGl2ZWx5IG9yIG90aGVyd2lz ZSwgdG8gc3RhcnQgZmlsbGluZyB2YXJpb3VzIGNhY2hlcyB3aXRoIGludGVybWVkaWF0ZSBzdGF0 ZXMgb2YgdGhlIHRleHQsIHdoaWNoIG1lYW5zIHRoYXQgdmFyaW91cyBhcmNoaXRlY3R1cmVzIChl dmVuIHg4NiEpIG1heSBuZWVkIHNlcmlhbGl6YXRpb24uCj4gCj4gRm9yIGVCUEYtIGFuZCBtb2R1 bGUtIGxpa2UgdXNlIGNhc2VzLCB3aGVyZSBKSVR0aW5nL2NvZGUgZ2VuIGlzIHF1aXRlIGNvYXJz ZS1ncmFpbmVkLCBwZXJoYXBzIHNvbWV0aGluZyB2YWd1ZWx5IGxpa2U6Cj4gCj4gaml0X3RleHRf YWxsb2MoKSAtPiByZXR1cm5zIGEgaGFuZGxlIGFuZCBhbiBleGVjdXRhYmxlIHZpcnR1YWwgYWRk cmVzcywgYnV0IGRvZXMgKm5vdCogbWFwIGl0IHRoZXJlCj4gaml0X3RleHRfd3JpdGUoKSAtPiB3 cml0ZSB0byB0aGF0IGhhbmRsZQo+IGppdF90ZXh0X21hcCgpIC0+IG1hcCBpdCBhbmQgc3luY2hy b25pemUgaWYgbmVlZGVkIChubyBzeW5jIG5lZWRlZCBvbiB4ODYsIEkgdGhpbmspCgpBbmR5LCB3 b3VsZCB5b3UgbWluZCBleHBsYWluaW5nIHdoeSB5b3UgdGhpbmsgYSBzeW5jIGlzIG5vdCBuZWVk ZWQ/IEkgbWVhbiBJIGhhdmUgYSDigJxmZWVsaW5n4oCdIHRoYXQgcGVyaGFwcyBUU08gY2FuIGd1 YXJhbnRlZSBzb21ldGhpbmcgYmFzZWQgb24gdGhlIG9yZGVyIG9mIHdyaXRlIGFuZCBwYWdlLXRh YmxlIHVwZGF0ZS4gSXMgdGhhdCB0aGUgYXJndW1lbnQ/CgpPbiB0aGlzIHJlZ2FyZCwgb25lIHRo aW5nIHRoYXQgSSBjbGVhcmx5IGRvIG5vdCB1bmRlcnN0YW5kIGlzIHdoeSAqdG9kYXkqIGl0IGlz IG9rIGZvciB1c2VycyBvZiBicGZfYXJjaF90ZXh0X2NvcHkoKSBub3QgdG8gY2FsbCB0ZXh0X3Bv a2Vfc3luYygpLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK