All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Fixed PHY problems
Date: Fri, 11 May 2007 17:37:50 +0200	[thread overview]
Message-ID: <7a21345ce9b0de392cbb9cfd675c6491@kernel.crashing.org> (raw)
In-Reply-To: <20070511180412.025aa1ca@vitb.ru.mvista.com>

>> 			phy3: ethernet-phy@03 {

>> 			phy4: ethernet-phy@04 {

@3 resp. @4 is more in line with existing practice.

> phy1: fixed-phy@01 {
> 	reg = <100 1>; /*100Mps, full duplex*/

The first entry in "reg" has to correspond to the
unit address (@01 in this case -- again, should be
@1 instead).

Never overload the meaning of well-known properties,
esp. not if it conflicts with the existing semantics,
like here.


Segher

  parent reply	other threads:[~2007-05-11 15:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 17:41 Fixed PHY problems Joakim Tjernlund
2007-05-11  8:07 ` Vitaly Bordug
2007-05-11  9:04   ` Joakim Tjernlund
2007-05-11 13:41     ` Joakim Tjernlund
2007-05-11 14:04       ` Vitaly Bordug
2007-05-11 14:20         ` Joakim Tjernlund
2007-05-11 15:37         ` Segher Boessenkool [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-05-19 14:42 Hammond Christian-r55079
2007-05-20 10:17 ` Joakim Tjernlund
2007-05-21 12:46   ` Hammond Christian-r55079
2007-05-22 13:23     ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a21345ce9b0de392cbb9cfd675c6491@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.