From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3DABCA5FC4 for ; Wed, 30 Sep 2026 18:25:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xByz6-0004gT-Gg; Wed, 30 Sep 2026 14:24:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xByz0-0004fm-7R for qemu-arm@nongnu.org; Wed, 30 Sep 2026 14:24:47 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xByyy-00059s-GI for qemu-arm@nongnu.org; Wed, 30 Sep 2026 14:24:45 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68UHeuX1241657 for ; Wed, 30 Sep 2026 18:24:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AcQqtxrq9kSTdnEAU6EEBDtma1couIcZMR7l45ScqNU=; b=K6koTTKvaI7pD3KT Xb/Hp4QtJu+LxyLGSqvvzG74UXGUldy13NzKCVq4SdVtTABiZz+MjJXyYsSVgou9 iuYZV2MsxQcd4XMmhLxrkwatR7q+D3aWrtkcEBYO6FvwjuhnA/Iyf8gbMnruYbIU dlIkGUySIytV4ouLrJTY+o/zFNEooy3b3B/n59Ty/2uaHT/heLwz1gqhQ1J0Blwy w6rJb69pdqH1JQ0A0rf1pOAQDvLFYvN4xn3INEppQWospxwsUB874eYBQrPVCKf9 z4dxLYm8GuTiOARsrBYg2szEd4Stc6ndmedXzwHWkWCdkvr23SiiUdWx1vx0B1je mS7Q/A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h10bka7g2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 30 Sep 2026 18:24:42 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93c5ab5c136so755648085a.3 for ; Wed, 30 Sep 2026 11:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790792682; x=1791397482; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=AcQqtxrq9kSTdnEAU6EEBDtma1couIcZMR7l45ScqNU=; b=TWThFmky+6KISVXkZaeUXMCmC3mOCgPzZPL+KiJrSbRVcPzzz878vs3uea1gai2/pi e+1Q7QrdpzDPhtYvCvMnqOOGcVbM0Py7a1B6b+cok4r2meLuQOLTmD07D5JETmLL0Vc2 sRA4u6bUbnrhe+1LTpM2WsJbbx8ZddPSAnylt2guVb3FlMYV38O1s65xXnI+2jC12hqL OHQFBYdwfYBhlzuXZLRyAkX/aLf47Hlbu4CHA49sRn4aBYfuktJBScbMTHntADBTYkkP gCJlC4Bq0srJ+0BS/bQ37S6uxipWginABZw5Cacbll+JdtfFcdHesdEATmzMpdAyhIux xAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790792682; x=1791397482; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AcQqtxrq9kSTdnEAU6EEBDtma1couIcZMR7l45ScqNU=; b=iAiHCKnkBo7tp6roS7476AqsKCSpc/0tLt8B1W8umhaASYa77GWI5rLuKhYP3DpQtq IeautkrYIEKv0GmTE1/4cpkNPOBzVX9y3hzSnyEmHpKdoDJ5L8M8Od1hwZFKVdrpKv6b ov7ZtEsKKFEpg4SA6waOs5f8FFTkCLHUsZs8u0BPH2CFzIuOdnupww/3FLbuFzI5ghJc SLY+DjPMQW8JD74NPS/UQLXWcj/3MjfHcq9Aif5UJYejs8D/VF0AEj+2Kvy7S/u7k4SH YAgqNPuY1Q7mxupYu63qYKJwcEbP2/926DE9coOaA/PSEnMscU4QIYlAGC8AxdEqdR0r k8nw== X-Forwarded-Encrypted: i=1; AKwUvByaCk8NCz3rHQi6IovgaLneq08dgy93tB2tzr5ir9+YxcLLZysMYvmTK7iQabSdSHE1deZ3cVZIGw==@nongnu.org X-Gm-Message-State: AFuF++ld2dsqIIT96cJczP6deXl8zNLNY+wGIgdZoNtcJ7DuwPTazXcW cyF8vkt3J/+KPPiIrS+7pmHZTD9NcHwe5lUjuD9Egp5sCrdsqH+nJrdCDYBgnRaxzIkdsrptFvs 6sdmaFTaq62HdawN5tHf8ZFuWaYS4Esy9rKjrsRV4uO8UpnV6Ts8Bkgk= X-Gm-Gg: AYBFou229PZNhatQ0zrN8uDHpzdSID4kB9zaJN2IjOdCoPq9Q8PhmmpG0ZPtcao7QBl EMt4Es4zHZ9/kIFALMDcI/WGsFZwfsOf03hA3ZVhS6YWkA6FaWWlhGLl6HzYY1bu+F6tEXEy3Io D2GSw4IQ4VnXCRXNohyunsJ144GeBoWeXCu3yMEg+Y9omNJ1Y+GeY70Y5PRkJVmN3wSmNcCrEvA SqY3Pm2DgalSHMRAEfD1g19iysdBmwD0d3ps0jfs0PGZ2Qlz9wD4fYVNz/eNTOgp0W/nIeypCq3 2wXrfNk6bE7jbW1om2nyOmYYgkNn4/5dX5o6aa3JXpSsELCSYgwcCKpNVPapyoX9ecJouRRLUy/ U5B24YmSbz0JwYg5d0z1pKPObgPUZ82MgyA== X-Received: by 2002:a05:620a:2944:b0:93c:9ba9:2b9d with SMTP id af79cd13be357-93ca9651b4fmr396726585a.19.1790792681829; Wed, 30 Sep 2026 11:24:41 -0700 (PDT) X-Received: by 2002:a05:620a:2944:b0:93c:9ba9:2b9d with SMTP id af79cd13be357-93ca9651b4fmr396719485a.19.1790792681237; Wed, 30 Sep 2026 11:24:41 -0700 (PDT) Received: from [192.168.68.102] ([187.10.234.20]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93cb6356ec4sm28290585a.6.2026.09.30.11.24.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2026 11:24:40 -0700 (PDT) Message-ID: <7a320a89-efb4-4520-80bf-d673d514e39a@oss.qualcomm.com> Date: Wed, 30 Sep 2026 15:24:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] target/riscv: bypass smstateen check in debugger mode To: =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , =?UTF-8?Q?Alex_Benn=C3=A9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Zhao Liu , Peter Maydell , Chinmay Rath , Nicholas Piggin , Glenn Miles , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Liu Zhiwei , Chao Liu , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, Paolo Bonzini , Laurent Vivier , Mark Cave-Ayland , Artyom Tarasenko , Helge Deller , Pierrick Bouvier , Warner Losh , Kyle Evans References: <20260911-query-reg-v1-0-0c04f0c02cf3@redhat.com> <20260911-query-reg-v1-8-0c04f0c02cf3@redhat.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20260911-query-reg-v1-8-0c04f0c02cf3@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: NpNIwXWyv2cw8X9lm4ESFJPlqAAHiOCa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTMwMDA3NSBTYWx0ZWRfX4yDqFAA73f11 VLkBcJjpR38iS9KXGshHhGji2P2IuvWOL4dGc9vpsV18UBPagWgbB7W9WsYvRcYBZRL36Dsfeg6 9ywnZC180AtdTB56lXUWgD2HQc+Mnoz1Ohz6/JRRmtWAtODsWK+ernmlMIGm7LJlL5euCMatbpf der8TslFniCDamyAROvisIpJIR9bZcQ4FAuGi7qmxIfWow54PQdWPAaSXKXh9xtgnnQJjNpdM4w /rSDV32DJnVZfrDFJwvdE3d2bdsxdG1YmAh8K6/SrKnbaoYi/ZjVmxqEvwOxIKc6gnAUu3fnITg BKmIIR2R9pmoba/UsPxo59EUqTqwJdnjAqmUHM5lf86azNySRcQhw7bkZM+9leyp4iQNIjAmJRt WnQRfcAl7MP0kTTGo8vkRgNW/7s+t1ltA6gbUo1kVFVWocAqt+hUH7VA3QjmT4/DwHtTCpruw08 5JcrYGhhIeL7XgPJ0TQ== X-Authority-Analysis: v=2.4 cv=MZn5KJ/f c=1 sm=1 tr=0 ts=6abd53ea cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=jbqyKmyYbxlRs/MVMa3Ccg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=MxrccPtz3TexQuPw8uEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTMwMDA3NSBTYWx0ZWRfX8h8KFD5cRJVe 230OZ9UOBkfR5FW9FvHdEpdGsPcbZc5T7DzAM0wKZXZctZjKrPFK2bm8VE+aRk4aVmnXuYpXRkk aNSDZHcDAMJzTiFQvOJHVME3clel17c= X-Proofpoint-ORIG-GUID: NpNIwXWyv2cw8X9lm4ESFJPlqAAHiOCa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-30_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609300075 Received-SPF: pass client-ip=205.220.180.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 9/11/2026 9:27 AM, Marc-André Lureau wrote: > Allow to read CSRs gated by Smstateen extension when env->debugger. > > Signed-off-by: Marc-André Lureau > --- > target/riscv/tcg/csr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/tcg/csr.c b/target/riscv/tcg/csr.c > index bd4b6dc114bc..93a7f419f29f 100644 > --- a/target/riscv/tcg/csr.c > +++ b/target/riscv/tcg/csr.c > @@ -53,7 +53,8 @@ RISCVException smstateen_acc_ok(CPURISCVState *env, int index, uint64_t bit) > { > bool virt = env->virt_enabled; > > - if (env->priv == PRV_M || !riscv_cpu_cfg(env)->ext_smstateen) { > + if (env->debugger || env->priv == PRV_M || > + !riscv_cpu_cfg(env)->ext_smstateen) { We have an going work in qemu-riscv (sdext, currently on v10) that adds a new 'debug' mode that is higher than the machine mode (PRV_M). It already uses env->debugger in its logic. I believe this change is already in line with what we want there, i.e. debug mode having at least the same accesses as PRV_M. Reviewed-by: Daniel Henrique Barboza > return RISCV_EXCP_NONE; > } > >