From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
Date: Wed, 24 Apr 2024 07:42:44 +0200 [thread overview]
Message-ID: <7a3d4b8a-e89e-499e-92b7-9f63fbc84011@kernel.org> (raw)
In-Reply-To: <20240423182428.704159-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 23/04/2024 20:24, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Group single const value items into an enum list.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> - Updated commit message
> - Grouped single const value items into an enum list.
> ---
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 29f2400247eb..2bf90095742b 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -13,15 +13,13 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r7s72100 # RZ/A1H
> - - items:
> - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> - - items:
> - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> + - enum:
You wanted to drop the items, but I still see it here.
> + - renesas,sdhi-sh73a0 # R-Mobile APE6
> + - renesas,sdhi-r7s72100 # RZ/A1H
> + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> + - renesas,sdhi-r8a7740 # R-Mobile A1
> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
Keep list alphabetically ordered.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-24 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 18:24 [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
2024-04-24 5:42 ` Krzysztof Kozlowski [this message]
2024-04-25 15:43 ` Lad, Prabhakar
2024-04-25 17:11 ` Geert Uytterhoeven
2024-04-25 18:35 ` Krzysztof Kozlowski
2024-04-25 18:54 ` Lad, Prabhakar
2024-04-23 18:24 ` [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
2024-04-24 12:23 ` Geert Uytterhoeven
2024-04-23 18:24 ` [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
2024-04-24 12:25 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a3d4b8a-e89e-499e-92b7-9f63fbc84011@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.