Re: [Phosphor-power] psu-ng: Add method to get PSU conf from D-Bus.

[Brandon Wyman <bjwyman@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]


On 2021-06-23 04:11, Chanh Nguyen OS wrote:
> Hi B. J. Wyman,
>
> I'm using the psu-ng to monitor the PSU. I used the 
> */pmbus/*(https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/pmbus.rst 
> <https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/pmbus.rst>) 
> driver to support hardware monitoring for the PSU, don't use the 
> */ibm-cffps/*driver 
> (https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/ibm-cffps.rst 
> <https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/ibm-cffps.rst>)
>
> I don't clear why we fix to use the *IBMCFFPSInterface 
> (https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/38138/10/phosphor-power-supply/psu_manager.cpp#16 
> <https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/38138/10/phosphor-power-supply/psu_manager.cpp#16>)* ?

Yeah, that was sort of a short-sighted updated. That probably should 
have been something configurable:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/43018/8/phosphor-power-supply/power_supply.cpp#30


That is used to get the power supply information off of D-Bus, hopefully 
populated by the entity-manager service.

https://github.com/openbmc/entity-manager/blob/master/schemas/IBM.json

https://github.com/openbmc/entity-manager/blob/master/configurations/Nisqually.json


This should *NOT* be IBM specific, but I had some kind of blinders on 
when I wrote this.

>
> Thanks,
> Chanh Nguyen
>

[-- Attachment #2: Type: text/html, Size: 5668 bytes --]