From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7D8C433E6 for ; Fri, 19 Feb 2021 13:28:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F099C64EB4 for ; Fri, 19 Feb 2021 13:28:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F099C64EB4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD5pg-00077d-Ow for qemu-devel@archiver.kernel.org; Fri, 19 Feb 2021 08:28:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD5ep-0006eU-Vx for qemu-devel@nongnu.org; Fri, 19 Feb 2021 08:17:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:54500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD5eo-0007pk-EP for qemu-devel@nongnu.org; Fri, 19 Feb 2021 08:17:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B0339ABAE; Fri, 19 Feb 2021 13:17:16 +0000 (UTC) Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/ To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini References: <008512eb-9b60-9d1f-4599-ad712574da80@redhat.com> From: Claudio Fontana Message-ID: <7a465ccb-a2f9-9293-d0d4-dd4cc65bfb8d@suse.de> Date: Fri, 19 Feb 2021 14:17:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <008512eb-9b60-9d1f-4599-ad712574da80@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/19/21 2:14 PM, Philippe Mathieu-Daudé wrote: > On 2/19/21 2:04 PM, Claudio Fontana wrote: >> Hi Paolo, >> >> currently we have use of CONFIG_TCG in tests/, >> >> but is that variable available at all in there? >> >> I have to adapt some qemu/tests/qtest/* to work also without tcg for ARM, >> >> but I think I am not seeing CONFIG_TCG filtering through, and I wonder whether all the checks in there are actually "wrong". > > Checking for ./configure definitions in tests is probably wrong, > it should be done via binary introspection (ask the binary if it > has the feature enabled). > How are we going to launch with the correct qemu options in qtest/bios-tables-test.c and qtest/boot-serial-tests.c ? I mean I agree with your sentiment, but it does not solve the problem.. Ciao, Claudio