Re: [PATCH v3 1/2] dt-bindings: i2c: Add binding for Qualcomm CCI I2C controller

[Todor Tomov <todor.tomov@linaro.org>]

Hi Bjorn,

On  7.08.2018 21:07, Bjorn Andersson wrote:
> On Tue 07 Aug 10:39 PDT 2018, Rob Herring wrote:
> 
>> On Tue, Aug 07, 2018 at 09:48:26AM +0530, Vinod wrote:
>>> On 06-08-18, 11:03, Bjorn Andersson wrote:
>>>> On Mon 06 Aug 04:04 PDT 2018, Vinod Koul wrote:
>>>>
>>>>> From: Todor Tomov <todor.tomov@linaro.org>
>>>>>
>>>>> Add DT binding document for Qualcomm Camera Control Interface (CCI)
>>>>> I2C controller.
>>>>>
>>>>> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>
>>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>>>>> ---
>>>>>  .../devicetree/bindings/i2c/i2c-qcom-cci.txt       | 55 ++++++++++++++++++++++
>>>>>  1 file changed, 55 insertions(+)
>>>>>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
>>>>> new file mode 100644
>>>>> index 000000000000..977978dd4444
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
>>>>> @@ -0,0 +1,55 @@
>>>>> +Qualcomm Camera Control Interface (CCI) I2C controller
>>>>> +
>>>>> +Required properties:
>>>>> + - compatible: Should be one of:
>>>>> +   - "qcom,cci-v1.0.8" for 8916;
>>>>> +   - "qcom,cci-v1.4.0" for 8996.
>>>>
>>>> As pointed out by Rob previously we should either use version numbers or
>>>> platform numbers, not both.
>>
>> Not really what I said...
>>
> 
> Sorry, I thought this was part of your concern.
> 
> Then I'll revise my statement to: if we're going to list the platforms
> here anyways I think we should just use the platform numbering as
> compatible directly.
> 
>>>>
>>>> So this should either be:
>>>>
>>>> 	- "qcom,cci-v1.0.8"
> 
> This is supposed to be 1.1.0 for 8916...

There is conflicting information about this in the documentation. However the version read from the hw version register is 1.0.8 and this matches the value listed in the SWI too so I believe 1.0.8 is correct for 8916.

> 
>>>> 	- "qcom,cci-v1.4.0"


-- 
Best regards,
Todor Tomov