Re: [PATCH 3/3] hw/ppc: Add stub for pnv_chip_find_core()

[Aditya Gupta <adityag@linux.ibm.com>]

Hi Cédric and Philippe,


On 26/05/25 17:21, Philippe Mathieu-Daudé wrote:
> On 26/5/25 13:48, Cédric Le Goater wrote:
>> On 5/26/25 13:23, Philippe Mathieu-Daudé wrote:
>>> Since commit 9808ce6d5cb, building QEMU configured with
>>> '--without-default-devices' fails:
>>>
>>>    Undefined symbols for architecture arm64:
>>>      "_pnv_chip_find_core", referenced from:
>>>          _helper_load_sprd in target_ppc_misc_helper.c.o
>>>          _helper_store_sprd in target_ppc_misc_helper.c.o
>>>    ld: symbol(s) not found for architecture arm64
>>>    clang: error: linker command failed with exit code 1
>>> > Fix by adding a stub when CONFIG_POWERNV is not available.
>>
>> The fix would be to add an abstract handler to implement SPRD accesses
>> on the PowerNV machine.


Is this what you meant by an abstract handler ?
https://github.com/adi-g15-ibm/qemu/commit/0abac37032a5ef66d64a649ce04f24876bf9007d


The thing done, is just to introduce a function pointer in 
'PowerPCCPUClass',
namely 'handle_sprd_store' and 'handle_sprd_load'


These will be set in the PNV chip realize path, so now the SPRD code in
target/ppc, will only call this for PowerNV.

Separated the powernv specific code, so target/ppc code doesn't depend
on pnv calls now.


Not well tested, will try somethings.


Thanks,

Aditya Gupta


>
> I don't know what "SPRD" is so I'll let someone more familiar with
> this area do the proper cleanup.
>
> Regards,
>
> Phil.
>
>>
>> Thanks,
>>
>> C.
>
>