All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata@amd.com>
To: Gregory Price <gourry@gourry.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<Jonathan.Cameron@huawei.com>, <dave.hansen@intel.com>,
	<mgorman@techsingularity.net>, <mingo@redhat.com>,
	<peterz@infradead.org>, <raghavendra.kt@amd.com>,
	<riel@surriel.com>, <rientjes@google.com>, <sj@kernel.org>,
	<weixugc@google.com>, <willy@infradead.org>,
	<ying.huang@linux.alibaba.com>, <ziy@nvidia.com>,
	<dave@stgolabs.net>, <nifan.cxl@gmail.com>,
	<xuezhengchu@huawei.com>, <yiannis@zptcorp.com>,
	<akpm@linux-foundation.org>, <david@redhat.com>,
	<byungchul@sk.com>, <kinseyho@google.com>,
	<joshua.hahnjy@gmail.com>, <yuanchu@google.com>,
	<balbirs@nvidia.com>, <alok.rathore@samsung.com>,
	<shivankg@amd.com>
Subject: Re: [RFC PATCH v5 00/10] mm: Hot page tracking and promotion infrastructure
Date: Tue, 24 Feb 2026 17:25:13 +0530	[thread overview]
Message-ID: <7a574665-0a65-46fb-b87d-d2ae28308759@amd.com> (raw)
In-Reply-To: <aZxsBifRchLn2m42@gourry-fedora-PF4VCD3F>

On 23-Feb-26 8:32 PM, Gregory Price wrote:
> On Mon, Feb 23, 2026 at 07:57:39PM +0530, Bharata B Rao wrote:
>>
>> Time in seconds - Lower is better
>> Mop/s total - Higher is better
>> =====================================================================================
>>                         Base            Base            pghot-default
>> pghot-precise
>>                         NUMAB0          NUMAB2          NUMAB2          NUMAB2
>> =====================================================================================
>> Time in seconds         7349.86         4422.50         6219.71         4113.56
>> Mop/s total             53247.66        88493.630       62923.030       95139.810
>>
>> pgpromote_success       0               42181834        248503390       41955718
>> pgpromote_candidate     0               0               577086192       0
>> pgpromote_candidate_nrl 0               42181834        29410329        41956171
>> pgdemote_kswapd         0               0               216489010       0
>> numa_pte_updates        0               42252749        607470975       42037882
>> numa_hint_faults        0               42183772        606540729       41968150
>> =====================================================================================
>>
>> - In the base case, the benchmark numbers improve significantly due to hot page
>>   promotion.
>> - Though the benchmark runs for hundreds of minutes, the pages get promoted
>>   within the first few mins.
>> - pghot-precise is able to match the base case numbers.
>> - The benchmark suffers in pghot-default case due to promotion being limited
>>   to the default NID (0) only. This leads to excessive PTE updates, hint faults,
>>   demotion and promotion churn.
> 
> Wow, this really seems to justify the extra memory usage.
> 
> Is it possible for you to change pghot-default to move the page to a
> random (or round-robin) node on the top tier instead of NID(0) by default?
> 
> At least then pghot-default would be correct 1/N % of the time (in theory).
> I'd be curious to see how close it gets to NUMAB2 with that.

For pghot-default, with target_nid alternating between the available
toptier nodes 0 and 1, the numbers catch up with pghot-precise and base
NUMAB2 case as seen below:
================================
Time in seconds         4337.98
Mop/s total             90217.86

pgpromote_success       42170085
pgpromote_candidate     0
pgpromote_candidate_nrl 42171963
pgdemote_kswapd         0
numa_pte_updates        42338538
numa_hint_faults        42185662
================================

Regards,
Bharata.


  reply	other threads:[~2026-02-24 11:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 14:40 [RFC PATCH v5 00/10] mm: Hot page tracking and promotion infrastructure Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 01/10] mm: migrate: Allow misplaced migration without VMA Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 02/10] migrate: Add migrate_misplaced_folios_batch() Bharata B Rao
2026-02-26 20:40   ` Joshua Hahn
2026-02-27 14:41     ` Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 03/10] mm: Hot page tracking and promotion Bharata B Rao
2026-02-11 15:40   ` Bharata B Rao
2026-02-11 16:08     ` Gregory Price
2026-02-12  2:03       ` Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 04/10] mm: pghot: Precision mode for pghot Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 05/10] mm: sched: move NUMA balancing tiering promotion to pghot Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 06/10] x86: ibs: In-kernel IBS driver for memory access profiling Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 07/10] x86: ibs: Enable IBS profiling for memory accesses Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 08/10] mm: mglru: generalize page table walk Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 09/10] mm: klruscand: use mglru scanning for page promotion Bharata B Rao
2026-01-29 14:40 ` [RFC PATCH v5 10/10] mm: pghot: Add folio_mark_accessed() as hotness source Bharata B Rao
2026-02-09  3:25 ` [RFC PATCH v5 00/10] mm: Hot page tracking and promotion infrastructure Bharata B Rao
2026-02-09  3:30 ` Bharata B Rao
2026-02-11 15:30 ` Bharata B Rao
2026-02-11 16:04   ` Gregory Price
2026-02-12  2:16     ` Bharata B Rao
2026-02-11 16:06   ` Gregory Price
2026-02-12 16:15   ` Bharata B Rao
2026-02-13 14:56 ` Gregory Price
2026-02-16  3:00   ` Bharata B Rao
2026-02-23 14:27 ` Bharata B Rao
2026-02-23 15:02   ` Gregory Price
2026-02-24 11:55     ` Bharata B Rao [this message]
2026-02-24 15:30       ` Gregory Price
2026-02-25  4:35         ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a574665-0a65-46fb-b87d-d2ae28308759@amd.com \
    --to=bharata@amd.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alok.rathore@samsung.com \
    --cc=balbirs@nvidia.com \
    --cc=byungchul@sk.com \
    --cc=dave.hansen@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=gourry@gourry.net \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kinseyho@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@redhat.com \
    --cc=nifan.cxl@gmail.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@amd.com \
    --cc=riel@surriel.com \
    --cc=rientjes@google.com \
    --cc=shivankg@amd.com \
    --cc=sj@kernel.org \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=xuezhengchu@huawei.com \
    --cc=yiannis@zptcorp.com \
    --cc=ying.huang@linux.alibaba.com \
    --cc=yuanchu@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.