From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SX9D6PA3" Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3EB2102; Sat, 2 Dec 2023 08:36:18 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50aab20e828so4290640e87.2; Sat, 02 Dec 2023 08:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701534977; x=1702139777; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=SX9D6PA3tIHRR4KkFTlZwi27U9blNDCtK6BYa2hMFeAM1yS02SX+QMYABlUBDd9ft4 bqreMp5vUTPzKmhcjusJ6DjGr39r3IcDaL3HZ0/CGxKXgUt7LEa43A+Fyttd0ytFu16T 0nnLnahz4zyELdrPUjEUOESAJCmOC7fNNHFDQPuRBAekaeKkm9Z7oQ3DlNeaQPMgS94v imhC90lrRtXutZsTbUDNnpK6l8AvNN0SS4Fe7KQxbRATyKoAzN3zzJdFfc1IGxfM3YYr wAevnayMvLBKLizWagOj66N3AW+srUG5CiBszuMkq+RB6t0KP5JmXqiflJS821Wzsy+y +Nuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701534977; x=1702139777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=ZLHrtPiKbE/xQmyzkaCxkEGWL20cdrwDkaQjCC9+JWHdg4rmJ5WnkB0BHIvGLled6O vNjJX/XqNOl+iEW1CfuacijCzKYsHpmhyYflVDCPt6RSydRpr9sZN1LADr5atDHKtOBE pHfmaMlPQVqpm436G1Fe9pp351tC4iRLTtITATLHDmdlhy0TmPIDyI8o8hIR8gM1sIS1 5tIT5onBnNPJS89pEY49z2HyRBmoONmsEscfY/LH3nHyXKJRta+zIsuvzDM1NaSHlDHX MWK5C/bHI+OBUyqLULDi/+KH2WJWxlsKooiXNFjUUIFwazxITb/uZ5WCzVga82nRrfKs ROOQ== X-Gm-Message-State: AOJu0YxnNXpcEkulWKhVlN/yOIFMBgdPl4KhFCw+WRxVPmlhsSyrCmix /h0uEjY3kBQ2vfvVbZOjMg== X-Google-Smtp-Source: AGHT+IF33HnUEXqWEy4B+lQlMo7S3GPuLcKmlqPCjVR7Kz4ZLcX9FlrrJcRavP6xP748jt47pbec1g== X-Received: by 2002:a05:6512:e98:b0:50b:bfaa:317b with SMTP id bi24-20020a0565120e9800b0050bbfaa317bmr1710184lfb.11.1701534976526; Sat, 02 Dec 2023 08:36:16 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:b6b5:9b26:a823:2f2d? ([2a02:810b:f40:4300:b6b5:9b26:a823:2f2d]) by smtp.gmail.com with ESMTPSA id eh4-20020a0564020f8400b0054c9b0bd576sm314474edb.26.2023.12.02.08.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 08:36:16 -0800 (PST) Message-ID: <7a6eed43-477a-48a4-bd64-4528da920ffd@gmail.com> Date: Sat, 2 Dec 2023 17:36:15 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <20231202125144.66052-3-knaerzche@gmail.com> <6926340.F8r316W7xa@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <6926340.F8r316W7xa@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Heiko, Am 02.12.23 um 16:51 schrieb Heiko Stübner: > Hi Alex, > > Am Samstag, 2. Dezember 2023, 13:51:41 CET schrieb Alex Bee: >> Add power controller and qos nodes for RK3128 in order to use >> them as powerdomains. > does the power-domain controller work with the incomplete set of > pm-domains too? Yes, it does - the missing domains can request idle only and can't be powered on/off - if no one requests idle they are just up all the time. > What I have in mind is > - adding the power-controller node with the existing set of power-domains > - the gpu pm-domain is in there > - adding the gpu parts My main concern about adding them later was the change of the ABI after they've been exposed in the SoC DT. If that's not an issue - sure: I can add them in a separate series. > > > And a second series with > - patch1 from here > - a dts patch adding the additional pm-domains to rk3128.dtsi > - I guess patch1 also should be split into a patch adding the binding-ids > and a separate patch for the code addition. Yeah, I noticed this also :) Regards, Alex > > > Heiko > >> Signed-off-by: Alex Bee >> --- >> arch/arm/boot/dts/rockchip/rk3128.dtsi | 101 +++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi b/arch/arm/boot/dts/rockchip/rk3128.dtsi >> index 4e8b38604ecd..b72905db04f7 100644 >> --- a/arch/arm/boot/dts/rockchip/rk3128.dtsi >> +++ b/arch/arm/boot/dts/rockchip/rk3128.dtsi >> @@ -8,6 +8,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> compatible = "rockchip,rk3128"; >> @@ -133,6 +134,106 @@ smp-sram@0 { >> pmu: syscon@100a0000 { >> compatible = "rockchip,rk3128-pmu", "syscon", "simple-mfd"; >> reg = <0x100a0000 0x1000>; >> + >> + power: power-controller { >> + compatible = "rockchip,rk3128-power-controller"; >> + #power-domain-cells = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + power-domain@RK3128_PD_VIO { >> + reg = ; >> + clocks = <&cru ACLK_CIF>, >> + <&cru HCLK_CIF>, >> + <&cru DCLK_EBC>, >> + <&cru HCLK_EBC>, >> + <&cru ACLK_IEP>, >> + <&cru HCLK_IEP>, >> + <&cru ACLK_LCDC0>, >> + <&cru HCLK_LCDC0>, >> + <&cru PCLK_MIPI>, >> + <&cru ACLK_RGA>, >> + <&cru HCLK_RGA>, >> + <&cru ACLK_VIO0>, >> + <&cru ACLK_VIO1>, >> + <&cru HCLK_VIO>, >> + <&cru HCLK_VIO_H2P>, >> + <&cru DCLK_VOP>, >> + <&cru SCLK_VOP>; >> + pm_qos = <&qos_ebc>, >> + <&qos_iep>, >> + <&qos_lcdc>, >> + <&qos_rga>, >> + <&qos_vip>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_VIDEO { >> + reg = ; >> + clocks = <&cru ACLK_VDPU>, >> + <&cru HCLK_VDPU>, >> + <&cru ACLK_VEPU>, >> + <&cru HCLK_VEPU>, >> + <&cru SCLK_HEVC_CORE>; >> + pm_qos = <&qos_vpu>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_GPU { >> + reg = ; >> + clocks = <&cru ACLK_GPU>; >> + pm_qos = <&qos_gpu>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_CRYPTO { >> + reg = ; >> + clocks = <&cru HCLK_CRYPTO>, >> + <&cru SCLK_CRYPTO>; >> + pm_qos = <&qos_crypto>; >> + #power-domain-cells = <0>; >> + }; >> + }; >> + }; >> + >> + qos_crypto: qos@10128080 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x10128080 0x20>; >> + }; >> + >> + qos_gpu: qos@1012d000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012d000 0x20>; >> + }; >> + >> + qos_vpu: qos@1012e000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012e000 0x20>; >> + }; >> + >> + qos_rga: qos@1012f000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f000 0x20>; >> + }; >> + >> + qos_ebc: qos@1012f080 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f080 0x20>; >> + }; >> + >> + qos_iep: qos@1012f100 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f100 0x20>; >> + }; >> + >> + qos_lcdc: qos@1012f180 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f180 0x20>; >> + }; >> + >> + qos_vip: qos@1012f200 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f200 0x20>; >> }; >> >> gic: interrupt-controller@10139000 { >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D5A6C10DCE for ; Sat, 2 Dec 2023 16:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9Pv17l5Og6bAp8UYiSSTgNych0tswltRJTakVbt7l0=; b=4aQQ/OEWjQY1ba N7VgF1zV0fdLwjdL5D5WuCP/I1M1SqjHHiyPOOq5aZXCfoI+/AB4VWQCeuIdSx26prDwOoP/icMkT zNJ+BPKqRWPTkgJfkyLzW9SvZAekoyUpa66cmM/vU04BV6ED5S63lL6YV/RXYw1EVEvm50MV2iO2S Gt7iwO5RLEHtEfuawdDbnaa/6UcCBlkjiAsJqNWEEjBF2CSUFVwhCJGMSSXVnE70mn+Sc2aQmochN bWIiayI1PzCbulTyCy2YDehC0Zj7XO7YhufkzqjbP0wzKER6oYHNrBUjTkUwEPaJ98BGPOUyrjy8N YMSSwtfpgpOsLaU9iE/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r9Syc-00Fu9k-0W; Sat, 02 Dec 2023 16:36:22 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r9SyZ-00Fu8m-05; Sat, 02 Dec 2023 16:36:20 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c9b9191722so42428791fa.1; Sat, 02 Dec 2023 08:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701534977; x=1702139777; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=Nx0JzGB1nzq7A2G9PPvXnIqLt2doFZP66IMdC9R9V4GGrWOHDWJM12vZj17Cuc7TA4 xTWr1vF2Tpml7JSzweM87r9VdPlmLNt9+xso4BAvx1B9SnrR8GyLHno8ngQ9oXFVKP0R nzrxWklI0hTFyfDGzbQad4rCWppu0FEsvLx1aHzyPpyCBvgTM5vqxRgPTxJrc9XcOOAp gmBO+vM2/bchxM/bt3qtb/k2yPiXHQwROHsTwzA4yO7fX2z8/A2Ir+rGqR4V5aB36LZi +gOkoihH7y21Ip+mYEMuCNv1NoZ03vBEtsZQJ2JhHJPIFuQ+dDXfMk5PGSXMZ5DpR303 uRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701534977; x=1702139777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=wuPTQQRJ8RXfBBs16H2pt2sBYaKxmXwKDPxUXiHEtALTtZjGyEvmgPiWLhbGftbHm1 o7r3nGIaW6kpAvsl86SIbCVjq+8tLWvXBNQGoyA9rxpRqr5tabTAm9PtFJN2ZGcumwqU YQjD3/lNG4I5jWySAQvjQp7P+3S87UTrmaYVVcy5aFcZg8blvUePf7ipAN/AnvHe+2iA grzn0ThuDEuyQA5RUOcoCL2CDQsiPTTNZ82CZYfG3PBBcRczdqQMQ2C9rb+EpdzjsScQ NJl1Sn23gaDzOfUqBavxqU8hV+XRaUpAOZZhs2w1QY5x4BlqDha6wzhKSJ70G0QQ7lcL rO0A== X-Gm-Message-State: AOJu0YzTcuqh75afdm2grrOtA92qg/reFRnGGjcjFVK9mqO7DJuaNF+x leZb6iv1hADkk3mgUonEAA== X-Google-Smtp-Source: AGHT+IF33HnUEXqWEy4B+lQlMo7S3GPuLcKmlqPCjVR7Kz4ZLcX9FlrrJcRavP6xP748jt47pbec1g== X-Received: by 2002:a05:6512:e98:b0:50b:bfaa:317b with SMTP id bi24-20020a0565120e9800b0050bbfaa317bmr1710184lfb.11.1701534976526; Sat, 02 Dec 2023 08:36:16 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:b6b5:9b26:a823:2f2d? ([2a02:810b:f40:4300:b6b5:9b26:a823:2f2d]) by smtp.gmail.com with ESMTPSA id eh4-20020a0564020f8400b0054c9b0bd576sm314474edb.26.2023.12.02.08.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 08:36:16 -0800 (PST) Message-ID: <7a6eed43-477a-48a4-bd64-4528da920ffd@gmail.com> Date: Sat, 2 Dec 2023 17:36:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <20231202125144.66052-3-knaerzche@gmail.com> <6926340.F8r316W7xa@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <6926340.F8r316W7xa@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231202_083619_069918_BD26E4E4 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSGVpa28sCgpBbSAwMi4xMi4yMyB1bSAxNjo1MSBzY2hyaWViIEhlaWtvIFN0w7xibmVyOgo+ IEhpIEFsZXgsCj4KPiBBbSBTYW1zdGFnLCAyLiBEZXplbWJlciAyMDIzLCAxMzo1MTo0MSBDRVQg c2NocmllYiBBbGV4IEJlZToKPj4gQWRkIHBvd2VyIGNvbnRyb2xsZXIgYW5kIHFvcyBub2RlcyBm b3IgUkszMTI4IGluIG9yZGVyIHRvIHVzZQo+PiB0aGVtIGFzIHBvd2VyZG9tYWlucy4KPiBkb2Vz IHRoZSBwb3dlci1kb21haW4gY29udHJvbGxlciB3b3JrIHdpdGggdGhlIGluY29tcGxldGUgc2V0 IG9mCj4gcG0tZG9tYWlucyB0b28/CgpZZXMsIGl0IGRvZXMgLSB0aGUgbWlzc2luZyBkb21haW5z IGNhbiByZXF1ZXN0IGlkbGUgb25seSBhbmQgY2FuJ3QgYmUgCnBvd2VyZWQgb24vb2ZmIC0gaWYg bm8gb25lIHJlcXVlc3RzIGlkbGUgdGhleSBhcmUganVzdCB1cCBhbGwgdGhlIHRpbWUuCgo+IFdo YXQgSSBoYXZlIGluIG1pbmQgaXMKPiAtIGFkZGluZyB0aGUgcG93ZXItY29udHJvbGxlciBub2Rl IHdpdGggdGhlIGV4aXN0aW5nIHNldCBvZiBwb3dlci1kb21haW5zCj4gLSB0aGUgZ3B1IHBtLWRv bWFpbiBpcyBpbiB0aGVyZQo+IC0gYWRkaW5nIHRoZSBncHUgcGFydHMKCk15IG1haW4gY29uY2Vy biBhYm91dCBhZGRpbmcgdGhlbSBsYXRlciB3YXMgdGhlIGNoYW5nZSBvZiB0aGUgQUJJIGFmdGVy IAp0aGV5J3ZlIGJlZW4gZXhwb3NlZCBpbiB0aGUgU29DIERULiBJZiB0aGF0J3Mgbm90IGFuIGlz c3VlIC0gc3VyZTogSSBjYW4gCmFkZCB0aGVtIGluIGEgc2VwYXJhdGUgc2VyaWVzLgoKPgo+Cj4g QW5kIGEgc2Vjb25kIHNlcmllcyB3aXRoCj4gLSBwYXRjaDEgZnJvbSBoZXJlCj4gLSBhIGR0cyBw YXRjaCBhZGRpbmcgdGhlIGFkZGl0aW9uYWwgcG0tZG9tYWlucyB0byByazMxMjguZHRzaQo+IC0g SSBndWVzcyBwYXRjaDEgYWxzbyBzaG91bGQgYmUgc3BsaXQgaW50byBhIHBhdGNoIGFkZGluZyB0 aGUgYmluZGluZy1pZHMKPiAgICBhbmQgYSBzZXBhcmF0ZSBwYXRjaCBmb3IgdGhlIGNvZGUgYWRk aXRpb24uCgpZZWFoLCBJIG5vdGljZWQgdGhpcyBhbHNvIDopCgpSZWdhcmRzLAoKQWxleAoKPgo+ Cj4gSGVpa28KPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IEJlZSA8a25hZXJ6Y2hlQGdtYWlsLmNv bT4KPj4gLS0tCj4+ICAgYXJjaC9hcm0vYm9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kgfCAx MDEgKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMDEgaW5z ZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcm9ja2NoaXAv cmszMTI4LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9yb2NrY2hpcC9yazMxMjguZHRzaQo+PiBp bmRleCA0ZThiMzg2MDRlY2QuLmI3MjkwNWRiMDRmNyAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0v Ym9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kKPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMv cm9ja2NoaXAvcmszMTI4LmR0c2kKPj4gQEAgLTgsNiArOCw3IEBACj4+ICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4KPj4gICAjaW5jbHVkZSA8 ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvaXJxLmg+Cj4+ICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL3BpbmN0cmwvcm9ja2NoaXAuaD4KPj4gKyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9w b3dlci9yazMxMjgtcG93ZXIuaD4KPj4gICAKPj4gICAvIHsKPj4gICAJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMxMjgiOwo+PiBAQCAtMTMzLDYgKzEzNCwxMDYgQEAgc21wLXNyYW1AMCB7Cj4+ ICAgCXBtdTogc3lzY29uQDEwMGEwMDAwIHsKPj4gICAJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAs cmszMTI4LXBtdSIsICJzeXNjb24iLCAic2ltcGxlLW1mZCI7Cj4+ICAgCQlyZWcgPSA8MHgxMDBh MDAwMCAweDEwMDA+Owo+PiArCj4+ICsJCXBvd2VyOiBwb3dlci1jb250cm9sbGVyIHsKPj4gKwkJ CWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXBvd2VyLWNvbnRyb2xsZXIiOwo+PiArCQkJ I3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwxPjsKPj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ PiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhf UERfVklPIHsKPj4gKwkJCQlyZWcgPSA8UkszMTI4X1BEX1ZJTz47Cj4+ICsJCQkJY2xvY2tzID0g PCZjcnUgQUNMS19DSUY+LAo+PiArCQkJCQkgPCZjcnUgSENMS19DSUY+LAo+PiArCQkJCQkgPCZj cnUgRENMS19FQkM+LAo+PiArCQkJCQkgPCZjcnUgSENMS19FQkM+LAo+PiArCQkJCQkgPCZjcnUg QUNMS19JRVA+LAo+PiArCQkJCQkgPCZjcnUgSENMS19JRVA+LAo+PiArCQkJCQkgPCZjcnUgQUNM S19MQ0RDMD4sCj4+ICsJCQkJCSA8JmNydSBIQ0xLX0xDREMwPiwKPj4gKwkJCQkJIDwmY3J1IFBD TEtfTUlQST4sCj4+ICsJCQkJCSA8JmNydSBBQ0xLX1JHQT4sCj4+ICsJCQkJCSA8JmNydSBIQ0xL X1JHQT4sCj4+ICsJCQkJCSA8JmNydSBBQ0xLX1ZJTzA+LAo+PiArCQkJCQkgPCZjcnUgQUNMS19W SU8xPiwKPj4gKwkJCQkJIDwmY3J1IEhDTEtfVklPPiwKPj4gKwkJCQkJIDwmY3J1IEhDTEtfVklP X0gyUD4sCj4+ICsJCQkJCSA8JmNydSBEQ0xLX1ZPUD4sCj4+ICsJCQkJCSA8JmNydSBTQ0xLX1ZP UD47Cj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfZWJjPiwKPj4gKwkJCQkJIDwmcW9zX2llcD4sCj4+ ICsJCQkJCSA8JnFvc19sY2RjPiwKPj4gKwkJCQkJIDwmcW9zX3JnYT4sCj4+ICsJCQkJCSA8JnFv c192aXA+Owo+PiArCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47Cj4+ICsJCQl9Owo+PiAr Cj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX1ZJREVPIHsKPj4gKwkJCQlyZWcgPSA8Uksz MTI4X1BEX1ZJREVPPjsKPj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX1ZEUFU+LAo+PiArCQkJ CQkgPCZjcnUgSENMS19WRFBVPiwKPj4gKwkJCQkJIDwmY3J1IEFDTEtfVkVQVT4sCj4+ICsJCQkJ CSA8JmNydSBIQ0xLX1ZFUFU+LAo+PiArCQkJCQkgPCZjcnUgU0NMS19IRVZDX0NPUkU+Owo+PiAr CQkJCXBtX3FvcyA9IDwmcW9zX3ZwdT47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDww PjsKPj4gKwkJCX07Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhfUERfR1BVIHsKPj4g KwkJCQlyZWcgPSA8UkszMTI4X1BEX0dQVT47Cj4+ICsJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19H UFU+Owo+PiArCQkJCXBtX3FvcyA9IDwmcW9zX2dwdT47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1j ZWxscyA9IDwwPjsKPj4gKwkJCX07Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhfUERf Q1JZUFRPIHsKPj4gKwkJCQlyZWcgPSA8UkszMTI4X1BEX0NSWVBUTz47Cj4+ICsJCQkJY2xvY2tz ID0gPCZjcnUgSENMS19DUllQVE8+LAo+PiArCQkJCQkgPCZjcnUgU0NMS19DUllQVE8+Owo+PiAr CQkJCXBtX3FvcyA9IDwmcW9zX2NyeXB0bz47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9 IDwwPjsKPj4gKwkJCX07Cj4+ICsJCX07Cj4+ICsJfTsKPj4gKwo+PiArCXFvc19jcnlwdG86IHFv c0AxMDEyODA4MCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJz eXNjb24iOwo+PiArCQlyZWcgPSA8MHgxMDEyODA4MCAweDIwPjsKPj4gKwl9Owo+PiArCj4+ICsJ cW9zX2dwdTogcW9zQDEwMTJkMDAwIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMx MjgtcW9zIiwgInN5c2NvbiI7Cj4+ICsJCXJlZyA9IDwweDEwMTJkMDAwIDB4MjA+Owo+PiArCX07 Cj4+ICsKPj4gKwlxb3NfdnB1OiBxb3NAMTAxMmUwMDAgewo+PiArCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzEyOC1xb3MiLCAic3lzY29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmUwMDAgMHgy MD47Cj4+ICsJfTsKPj4gKwo+PiArCXFvc19yZ2E6IHFvc0AxMDEyZjAwMCB7Cj4+ICsJCWNvbXBh dGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+PiArCQlyZWcgPSA8MHgx MDEyZjAwMCAweDIwPjsKPj4gKwl9Owo+PiArCj4+ICsJcW9zX2ViYzogcW9zQDEwMTJmMDgwIHsK Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+ICsJ CXJlZyA9IDwweDEwMTJmMDgwIDB4MjA+Owo+PiArCX07Cj4+ICsKPj4gKwlxb3NfaWVwOiBxb3NA MTAxMmYxMDAgewo+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lz Y29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmYxMDAgMHgyMD47Cj4+ICsJfTsKPj4gKwo+PiArCXFv c19sY2RjOiBxb3NAMTAxMmYxODAgewo+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEy OC1xb3MiLCAic3lzY29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmYxODAgMHgyMD47Cj4+ICsJfTsK Pj4gKwo+PiArCXFvc192aXA6IHFvc0AxMDEyZjIwMCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAicm9j a2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+PiArCQlyZWcgPSA8MHgxMDEyZjIwMCAweDIw PjsKPj4gICAJfTsKPj4gICAKPj4gICAJZ2ljOiBpbnRlcnJ1cHQtY29udHJvbGxlckAxMDEzOTAw MCB7Cj4+Cj4KPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E17C4167B for ; Sat, 2 Dec 2023 16:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r1+Ax36ddRN6OWHHlkyRFARQtkdX6BeEcrGCkJxJ8zQ=; b=WI9kQMgRcQIimd ZQCHNBwtMiG2sdKdr6qrUUhzDhIwVcag1vXYXMMTHceelZaF9gIq4XU3slAY/99eGv/dM5Mo0fbiJ wd96+I7zzWVc4qqrKDWpW8Kwcstlm//k397FqYyoWCK03MZnvpjIDMoAwU9GRJG4kkE+S2tI443Fv 6AGAUKZ9ous/BLTq9Z/AD6w0uzVI9ll1rD9MS8TIjTqpLV6BRLm2gLK9+14ojlehgQ8H7uZcNBJj/ JbKNaigUGXYIe7/VkR68EZlsgvs0VgeJZgKdXfIG6jwQfJgYEpU20wY9dBmAgT0T6uead8hHPj+Dw BuNfPVYKUaJKEgbmkIIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r9Syb-00Fu9P-1y; Sat, 02 Dec 2023 16:36:21 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r9SyZ-00Fu8m-05; Sat, 02 Dec 2023 16:36:20 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c9b9191722so42428791fa.1; Sat, 02 Dec 2023 08:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701534977; x=1702139777; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=Nx0JzGB1nzq7A2G9PPvXnIqLt2doFZP66IMdC9R9V4GGrWOHDWJM12vZj17Cuc7TA4 xTWr1vF2Tpml7JSzweM87r9VdPlmLNt9+xso4BAvx1B9SnrR8GyLHno8ngQ9oXFVKP0R nzrxWklI0hTFyfDGzbQad4rCWppu0FEsvLx1aHzyPpyCBvgTM5vqxRgPTxJrc9XcOOAp gmBO+vM2/bchxM/bt3qtb/k2yPiXHQwROHsTwzA4yO7fX2z8/A2Ir+rGqR4V5aB36LZi +gOkoihH7y21Ip+mYEMuCNv1NoZ03vBEtsZQJ2JhHJPIFuQ+dDXfMk5PGSXMZ5DpR303 uRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701534977; x=1702139777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=wuPTQQRJ8RXfBBs16H2pt2sBYaKxmXwKDPxUXiHEtALTtZjGyEvmgPiWLhbGftbHm1 o7r3nGIaW6kpAvsl86SIbCVjq+8tLWvXBNQGoyA9rxpRqr5tabTAm9PtFJN2ZGcumwqU YQjD3/lNG4I5jWySAQvjQp7P+3S87UTrmaYVVcy5aFcZg8blvUePf7ipAN/AnvHe+2iA grzn0ThuDEuyQA5RUOcoCL2CDQsiPTTNZ82CZYfG3PBBcRczdqQMQ2C9rb+EpdzjsScQ NJl1Sn23gaDzOfUqBavxqU8hV+XRaUpAOZZhs2w1QY5x4BlqDha6wzhKSJ70G0QQ7lcL rO0A== X-Gm-Message-State: AOJu0YzTcuqh75afdm2grrOtA92qg/reFRnGGjcjFVK9mqO7DJuaNF+x leZb6iv1hADkk3mgUonEAA== X-Google-Smtp-Source: AGHT+IF33HnUEXqWEy4B+lQlMo7S3GPuLcKmlqPCjVR7Kz4ZLcX9FlrrJcRavP6xP748jt47pbec1g== X-Received: by 2002:a05:6512:e98:b0:50b:bfaa:317b with SMTP id bi24-20020a0565120e9800b0050bbfaa317bmr1710184lfb.11.1701534976526; Sat, 02 Dec 2023 08:36:16 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:b6b5:9b26:a823:2f2d? ([2a02:810b:f40:4300:b6b5:9b26:a823:2f2d]) by smtp.gmail.com with ESMTPSA id eh4-20020a0564020f8400b0054c9b0bd576sm314474edb.26.2023.12.02.08.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 08:36:16 -0800 (PST) Message-ID: <7a6eed43-477a-48a4-bd64-4528da920ffd@gmail.com> Date: Sat, 2 Dec 2023 17:36:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <20231202125144.66052-3-knaerzche@gmail.com> <6926340.F8r316W7xa@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <6926340.F8r316W7xa@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231202_083619_069918_BD26E4E4 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSGVpa28sCgpBbSAwMi4xMi4yMyB1bSAxNjo1MSBzY2hyaWViIEhlaWtvIFN0w7xibmVyOgo+ IEhpIEFsZXgsCj4KPiBBbSBTYW1zdGFnLCAyLiBEZXplbWJlciAyMDIzLCAxMzo1MTo0MSBDRVQg c2NocmllYiBBbGV4IEJlZToKPj4gQWRkIHBvd2VyIGNvbnRyb2xsZXIgYW5kIHFvcyBub2RlcyBm b3IgUkszMTI4IGluIG9yZGVyIHRvIHVzZQo+PiB0aGVtIGFzIHBvd2VyZG9tYWlucy4KPiBkb2Vz IHRoZSBwb3dlci1kb21haW4gY29udHJvbGxlciB3b3JrIHdpdGggdGhlIGluY29tcGxldGUgc2V0 IG9mCj4gcG0tZG9tYWlucyB0b28/CgpZZXMsIGl0IGRvZXMgLSB0aGUgbWlzc2luZyBkb21haW5z IGNhbiByZXF1ZXN0IGlkbGUgb25seSBhbmQgY2FuJ3QgYmUgCnBvd2VyZWQgb24vb2ZmIC0gaWYg bm8gb25lIHJlcXVlc3RzIGlkbGUgdGhleSBhcmUganVzdCB1cCBhbGwgdGhlIHRpbWUuCgo+IFdo YXQgSSBoYXZlIGluIG1pbmQgaXMKPiAtIGFkZGluZyB0aGUgcG93ZXItY29udHJvbGxlciBub2Rl IHdpdGggdGhlIGV4aXN0aW5nIHNldCBvZiBwb3dlci1kb21haW5zCj4gLSB0aGUgZ3B1IHBtLWRv bWFpbiBpcyBpbiB0aGVyZQo+IC0gYWRkaW5nIHRoZSBncHUgcGFydHMKCk15IG1haW4gY29uY2Vy biBhYm91dCBhZGRpbmcgdGhlbSBsYXRlciB3YXMgdGhlIGNoYW5nZSBvZiB0aGUgQUJJIGFmdGVy IAp0aGV5J3ZlIGJlZW4gZXhwb3NlZCBpbiB0aGUgU29DIERULiBJZiB0aGF0J3Mgbm90IGFuIGlz c3VlIC0gc3VyZTogSSBjYW4gCmFkZCB0aGVtIGluIGEgc2VwYXJhdGUgc2VyaWVzLgoKPgo+Cj4g QW5kIGEgc2Vjb25kIHNlcmllcyB3aXRoCj4gLSBwYXRjaDEgZnJvbSBoZXJlCj4gLSBhIGR0cyBw YXRjaCBhZGRpbmcgdGhlIGFkZGl0aW9uYWwgcG0tZG9tYWlucyB0byByazMxMjguZHRzaQo+IC0g SSBndWVzcyBwYXRjaDEgYWxzbyBzaG91bGQgYmUgc3BsaXQgaW50byBhIHBhdGNoIGFkZGluZyB0 aGUgYmluZGluZy1pZHMKPiAgICBhbmQgYSBzZXBhcmF0ZSBwYXRjaCBmb3IgdGhlIGNvZGUgYWRk aXRpb24uCgpZZWFoLCBJIG5vdGljZWQgdGhpcyBhbHNvIDopCgpSZWdhcmRzLAoKQWxleAoKPgo+ Cj4gSGVpa28KPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IEJlZSA8a25hZXJ6Y2hlQGdtYWlsLmNv bT4KPj4gLS0tCj4+ICAgYXJjaC9hcm0vYm9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kgfCAx MDEgKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMDEgaW5z ZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcm9ja2NoaXAv cmszMTI4LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9yb2NrY2hpcC9yazMxMjguZHRzaQo+PiBp bmRleCA0ZThiMzg2MDRlY2QuLmI3MjkwNWRiMDRmNyAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0v Ym9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kKPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMv cm9ja2NoaXAvcmszMTI4LmR0c2kKPj4gQEAgLTgsNiArOCw3IEBACj4+ICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4KPj4gICAjaW5jbHVkZSA8 ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvaXJxLmg+Cj4+ICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL3BpbmN0cmwvcm9ja2NoaXAuaD4KPj4gKyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9w b3dlci9yazMxMjgtcG93ZXIuaD4KPj4gICAKPj4gICAvIHsKPj4gICAJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMxMjgiOwo+PiBAQCAtMTMzLDYgKzEzNCwxMDYgQEAgc21wLXNyYW1AMCB7Cj4+ ICAgCXBtdTogc3lzY29uQDEwMGEwMDAwIHsKPj4gICAJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAs cmszMTI4LXBtdSIsICJzeXNjb24iLCAic2ltcGxlLW1mZCI7Cj4+ICAgCQlyZWcgPSA8MHgxMDBh MDAwMCAweDEwMDA+Owo+PiArCj4+ICsJCXBvd2VyOiBwb3dlci1jb250cm9sbGVyIHsKPj4gKwkJ CWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXBvd2VyLWNvbnRyb2xsZXIiOwo+PiArCQkJ I3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwxPjsKPj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ PiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhf UERfVklPIHsKPj4gKwkJCQlyZWcgPSA8UkszMTI4X1BEX1ZJTz47Cj4+ICsJCQkJY2xvY2tzID0g PCZjcnUgQUNMS19DSUY+LAo+PiArCQkJCQkgPCZjcnUgSENMS19DSUY+LAo+PiArCQkJCQkgPCZj cnUgRENMS19FQkM+LAo+PiArCQkJCQkgPCZjcnUgSENMS19FQkM+LAo+PiArCQkJCQkgPCZjcnUg QUNMS19JRVA+LAo+PiArCQkJCQkgPCZjcnUgSENMS19JRVA+LAo+PiArCQkJCQkgPCZjcnUgQUNM S19MQ0RDMD4sCj4+ICsJCQkJCSA8JmNydSBIQ0xLX0xDREMwPiwKPj4gKwkJCQkJIDwmY3J1IFBD TEtfTUlQST4sCj4+ICsJCQkJCSA8JmNydSBBQ0xLX1JHQT4sCj4+ICsJCQkJCSA8JmNydSBIQ0xL X1JHQT4sCj4+ICsJCQkJCSA8JmNydSBBQ0xLX1ZJTzA+LAo+PiArCQkJCQkgPCZjcnUgQUNMS19W SU8xPiwKPj4gKwkJCQkJIDwmY3J1IEhDTEtfVklPPiwKPj4gKwkJCQkJIDwmY3J1IEhDTEtfVklP X0gyUD4sCj4+ICsJCQkJCSA8JmNydSBEQ0xLX1ZPUD4sCj4+ICsJCQkJCSA8JmNydSBTQ0xLX1ZP UD47Cj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfZWJjPiwKPj4gKwkJCQkJIDwmcW9zX2llcD4sCj4+ ICsJCQkJCSA8JnFvc19sY2RjPiwKPj4gKwkJCQkJIDwmcW9zX3JnYT4sCj4+ICsJCQkJCSA8JnFv c192aXA+Owo+PiArCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47Cj4+ICsJCQl9Owo+PiAr Cj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX1ZJREVPIHsKPj4gKwkJCQlyZWcgPSA8Uksz MTI4X1BEX1ZJREVPPjsKPj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX1ZEUFU+LAo+PiArCQkJ CQkgPCZjcnUgSENMS19WRFBVPiwKPj4gKwkJCQkJIDwmY3J1IEFDTEtfVkVQVT4sCj4+ICsJCQkJ CSA8JmNydSBIQ0xLX1ZFUFU+LAo+PiArCQkJCQkgPCZjcnUgU0NMS19IRVZDX0NPUkU+Owo+PiAr CQkJCXBtX3FvcyA9IDwmcW9zX3ZwdT47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDww PjsKPj4gKwkJCX07Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhfUERfR1BVIHsKPj4g KwkJCQlyZWcgPSA8UkszMTI4X1BEX0dQVT47Cj4+ICsJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19H UFU+Owo+PiArCQkJCXBtX3FvcyA9IDwmcW9zX2dwdT47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1j ZWxscyA9IDwwPjsKPj4gKwkJCX07Cj4+ICsKPj4gKwkJCXBvd2VyLWRvbWFpbkBSSzMxMjhfUERf Q1JZUFRPIHsKPj4gKwkJCQlyZWcgPSA8UkszMTI4X1BEX0NSWVBUTz47Cj4+ICsJCQkJY2xvY2tz ID0gPCZjcnUgSENMS19DUllQVE8+LAo+PiArCQkJCQkgPCZjcnUgU0NMS19DUllQVE8+Owo+PiAr CQkJCXBtX3FvcyA9IDwmcW9zX2NyeXB0bz47Cj4+ICsJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9 IDwwPjsKPj4gKwkJCX07Cj4+ICsJCX07Cj4+ICsJfTsKPj4gKwo+PiArCXFvc19jcnlwdG86IHFv c0AxMDEyODA4MCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJz eXNjb24iOwo+PiArCQlyZWcgPSA8MHgxMDEyODA4MCAweDIwPjsKPj4gKwl9Owo+PiArCj4+ICsJ cW9zX2dwdTogcW9zQDEwMTJkMDAwIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMx MjgtcW9zIiwgInN5c2NvbiI7Cj4+ICsJCXJlZyA9IDwweDEwMTJkMDAwIDB4MjA+Owo+PiArCX07 Cj4+ICsKPj4gKwlxb3NfdnB1OiBxb3NAMTAxMmUwMDAgewo+PiArCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzEyOC1xb3MiLCAic3lzY29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmUwMDAgMHgy MD47Cj4+ICsJfTsKPj4gKwo+PiArCXFvc19yZ2E6IHFvc0AxMDEyZjAwMCB7Cj4+ICsJCWNvbXBh dGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+PiArCQlyZWcgPSA8MHgx MDEyZjAwMCAweDIwPjsKPj4gKwl9Owo+PiArCj4+ICsJcW9zX2ViYzogcW9zQDEwMTJmMDgwIHsK Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+ICsJ CXJlZyA9IDwweDEwMTJmMDgwIDB4MjA+Owo+PiArCX07Cj4+ICsKPj4gKwlxb3NfaWVwOiBxb3NA MTAxMmYxMDAgewo+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lz Y29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmYxMDAgMHgyMD47Cj4+ICsJfTsKPj4gKwo+PiArCXFv c19sY2RjOiBxb3NAMTAxMmYxODAgewo+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEy OC1xb3MiLCAic3lzY29uIjsKPj4gKwkJcmVnID0gPDB4MTAxMmYxODAgMHgyMD47Cj4+ICsJfTsK Pj4gKwo+PiArCXFvc192aXA6IHFvc0AxMDEyZjIwMCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAicm9j a2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+PiArCQlyZWcgPSA8MHgxMDEyZjIwMCAweDIw PjsKPj4gICAJfTsKPj4gICAKPj4gICAJZ2ljOiBpbnRlcnJ1cHQtY29udHJvbGxlckAxMDEzOTAw MCB7Cj4+Cj4KPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB439C4167B for ; Sat, 2 Dec 2023 16:36:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 824CD10E097; Sat, 2 Dec 2023 16:36:25 +0000 (UTC) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCB7D10E097 for ; Sat, 2 Dec 2023 16:36:18 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50bbb4de875so4322237e87.0 for ; Sat, 02 Dec 2023 08:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701534977; x=1702139777; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=XaJk8tp6KWO2VIoDAafadzyVDwTVUGGLGyLRR6D5SBwgWChbD+3mPEJ40XoqL8o14V 3Vcx79EaSnOIMhAymfQ5TqHu5EtPs/apzDt2/101x2nDY0QCoW67j3+hhI2gYw+MTqxu z3dQqKah5yGIkVcXuYMUkxV1Nwa0Emp4suC/+XvzQyLRAlN1hlRyiQE+KQPQWgseCGK+ E6pJrTMrXytOLOl8tzAKbxxuvo2YE/N6qaYYyLpz8otq9rAEsvPwjaEf1UsRu5599o5L IuJSzn2gbY0ScFHZYz3OLETFbJOtCXzFKSOmVAGaEi5xw1SonN+qFKtEzNIX+eOePlHe Z+Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701534977; x=1702139777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0V2pKk4+4aA81N20X6iKRNTg+2H72cbN/toxwCkNhk=; b=BjbI9fk9e75SNlgwnMl3Egu5tRbd3IXO3vHplI9OYeeDlxpKF9D+ItTCGBgPTRX4pR ZuD3lC1Y0TlFtwjOOxzgqu45qPgIlU7FeN+5nD2UUP+cwRCVVtL6xik6rVjlLijdh7YN jV6DY6j7gwWBDPO6fJVho6SWQlQoGzyryBEqsg8hthK7JtyS0DaXTG4owhB1b0FPrkto ElN57jxbz4TRIZQQfdFky0A9DCgtEiF4jBV+U5xxGhUM8hqatqd9LStjS07pxj0iKlMT MwacZG93pAfQTl1EXFj7XhSwlD3OSkI+p/W2YKaObPCqIF68B5KEq+YFFQUylcj59O8y 081A== X-Gm-Message-State: AOJu0YxKLKvNYGYg775cxqwb8pjPQ96sS75F3DuR9CS8tfhMYgaksflR XYbotkPZUlTDxHSGbJl1tg== X-Google-Smtp-Source: AGHT+IF33HnUEXqWEy4B+lQlMo7S3GPuLcKmlqPCjVR7Kz4ZLcX9FlrrJcRavP6xP748jt47pbec1g== X-Received: by 2002:a05:6512:e98:b0:50b:bfaa:317b with SMTP id bi24-20020a0565120e9800b0050bbfaa317bmr1710184lfb.11.1701534976526; Sat, 02 Dec 2023 08:36:16 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:b6b5:9b26:a823:2f2d? ([2a02:810b:f40:4300:b6b5:9b26:a823:2f2d]) by smtp.gmail.com with ESMTPSA id eh4-20020a0564020f8400b0054c9b0bd576sm314474edb.26.2023.12.02.08.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 08:36:16 -0800 (PST) Message-ID: <7a6eed43-477a-48a4-bd64-4528da920ffd@gmail.com> Date: Sat, 2 Dec 2023 17:36:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring References: <20231202125144.66052-1-knaerzche@gmail.com> <20231202125144.66052-3-knaerzche@gmail.com> <6926340.F8r316W7xa@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <6926340.F8r316W7xa@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Heiko, Am 02.12.23 um 16:51 schrieb Heiko Stübner: > Hi Alex, > > Am Samstag, 2. Dezember 2023, 13:51:41 CET schrieb Alex Bee: >> Add power controller and qos nodes for RK3128 in order to use >> them as powerdomains. > does the power-domain controller work with the incomplete set of > pm-domains too? Yes, it does - the missing domains can request idle only and can't be powered on/off - if no one requests idle they are just up all the time. > What I have in mind is > - adding the power-controller node with the existing set of power-domains > - the gpu pm-domain is in there > - adding the gpu parts My main concern about adding them later was the change of the ABI after they've been exposed in the SoC DT. If that's not an issue - sure: I can add them in a separate series. > > > And a second series with > - patch1 from here > - a dts patch adding the additional pm-domains to rk3128.dtsi > - I guess patch1 also should be split into a patch adding the binding-ids > and a separate patch for the code addition. Yeah, I noticed this also :) Regards, Alex > > > Heiko > >> Signed-off-by: Alex Bee >> --- >> arch/arm/boot/dts/rockchip/rk3128.dtsi | 101 +++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi b/arch/arm/boot/dts/rockchip/rk3128.dtsi >> index 4e8b38604ecd..b72905db04f7 100644 >> --- a/arch/arm/boot/dts/rockchip/rk3128.dtsi >> +++ b/arch/arm/boot/dts/rockchip/rk3128.dtsi >> @@ -8,6 +8,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> compatible = "rockchip,rk3128"; >> @@ -133,6 +134,106 @@ smp-sram@0 { >> pmu: syscon@100a0000 { >> compatible = "rockchip,rk3128-pmu", "syscon", "simple-mfd"; >> reg = <0x100a0000 0x1000>; >> + >> + power: power-controller { >> + compatible = "rockchip,rk3128-power-controller"; >> + #power-domain-cells = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + power-domain@RK3128_PD_VIO { >> + reg = ; >> + clocks = <&cru ACLK_CIF>, >> + <&cru HCLK_CIF>, >> + <&cru DCLK_EBC>, >> + <&cru HCLK_EBC>, >> + <&cru ACLK_IEP>, >> + <&cru HCLK_IEP>, >> + <&cru ACLK_LCDC0>, >> + <&cru HCLK_LCDC0>, >> + <&cru PCLK_MIPI>, >> + <&cru ACLK_RGA>, >> + <&cru HCLK_RGA>, >> + <&cru ACLK_VIO0>, >> + <&cru ACLK_VIO1>, >> + <&cru HCLK_VIO>, >> + <&cru HCLK_VIO_H2P>, >> + <&cru DCLK_VOP>, >> + <&cru SCLK_VOP>; >> + pm_qos = <&qos_ebc>, >> + <&qos_iep>, >> + <&qos_lcdc>, >> + <&qos_rga>, >> + <&qos_vip>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_VIDEO { >> + reg = ; >> + clocks = <&cru ACLK_VDPU>, >> + <&cru HCLK_VDPU>, >> + <&cru ACLK_VEPU>, >> + <&cru HCLK_VEPU>, >> + <&cru SCLK_HEVC_CORE>; >> + pm_qos = <&qos_vpu>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_GPU { >> + reg = ; >> + clocks = <&cru ACLK_GPU>; >> + pm_qos = <&qos_gpu>; >> + #power-domain-cells = <0>; >> + }; >> + >> + power-domain@RK3128_PD_CRYPTO { >> + reg = ; >> + clocks = <&cru HCLK_CRYPTO>, >> + <&cru SCLK_CRYPTO>; >> + pm_qos = <&qos_crypto>; >> + #power-domain-cells = <0>; >> + }; >> + }; >> + }; >> + >> + qos_crypto: qos@10128080 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x10128080 0x20>; >> + }; >> + >> + qos_gpu: qos@1012d000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012d000 0x20>; >> + }; >> + >> + qos_vpu: qos@1012e000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012e000 0x20>; >> + }; >> + >> + qos_rga: qos@1012f000 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f000 0x20>; >> + }; >> + >> + qos_ebc: qos@1012f080 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f080 0x20>; >> + }; >> + >> + qos_iep: qos@1012f100 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f100 0x20>; >> + }; >> + >> + qos_lcdc: qos@1012f180 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f180 0x20>; >> + }; >> + >> + qos_vip: qos@1012f200 { >> + compatible = "rockchip,rk3128-qos", "syscon"; >> + reg = <0x1012f200 0x20>; >> }; >> >> gic: interrupt-controller@10139000 { >> > > >