From: wangzhiqiang (Q) <wangzhiqiang95@huawei.com>
To: lvm-devel@redhat.com
Subject: 答复: [PATCH] pvscan --cache /dev/xx needs to scan all disks and aliases when enable device filter
Date: Fri, 9 Dec 2022 01:27:09 +0000 [thread overview]
Message-ID: <7a7c6e61cecc4e73838617e5ce5fe612@huawei.com> (raw)
In-Reply-To: <20221207152936.GA12874@redhat.com>
Thanks. the _filter_uses_symlinks function handles this case well.
wangzhiqiang
-----????-----
???: David Teigland <teigland@redhat.com>
????: 2022?12?7? 23:30
???: wangzhiqiang (Q) <wangzhiqiang95@huawei.com>
??: lvm-devel at redhat.com; linfeilong <linfeilong@huawei.com>; liuzhiqiang (I) <liuzhiqiang26@huawei.com>
??: Re: [PATCH] pvscan --cache /dev/xx needs to scan all disks and aliases when enable device filter
On Wed, Dec 07, 2022 at 09:34:13AM +0000, wangzhiqiang (Q) wrote:
> When the system restarts and the disk goes online, the udev rule will
> be triggered to scan the metadata on the disk to automatically
> activate the logical volume, If we specify the scanned disk alias in lvm.conf, reject other unspecified disks, then lv cannot activate since the aliases mismatch with disk name.
>
> If device filtering is configured in lvm.conf, then pvscan --cache
> /dev/xx needs to scan all disks and aliases
Hi, if I understand correctly, pvscan is already attempting to handle this case. See the use of "_filter_uses_symlinks" in pvscan.c. Perhaps it needs check for other symlink substrings? The problem with your patch is that it's a significant performance penalty for a common configuration.
Dave
prev parent reply other threads:[~2022-12-09 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 9:34 [PATCH] pvscan --cache /dev/xx needs to scan all disks and aliases when enable device filter wangzhiqiang
2022-12-07 15:29 ` David Teigland
2022-12-09 1:27 ` wangzhiqiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a7c6e61cecc4e73838617e5ce5fe612@huawei.com \
--to=wangzhiqiang95@huawei.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.