From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 366D5145FF6 for ; Wed, 22 May 2024 18:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716403240; cv=none; b=MdpPoICKM6fevv20iHFafNd1deya/cE8u6QOt6f+Ib/omdoxmZ+Awlwdernhp3PKAasU6Ljft2+khR+4CFfjdUIGecQtt73EYmu35kW/ADM7KSB4DECnKnDbn2N2yEF2VrqORadIbno64OK12OisSB9bgWwHUuG0zHegIiNDCtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716403240; c=relaxed/simple; bh=pvfNI1321JVtef7N+59lYxiObUuoIkn6QTtflB1MBjE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jmgk/8BFp0Ry6MWTPK3F3geDfpjPq8uLNCfRC4QDpDExZRj6LJOyjaxBamgFhCw7/bZj4VEJiOvrXVTCjYCQc4S/nD91KEni6ZoQR7HgRlcEW7ylBTT68swhOyFCYcfxTBtxNty8ZQ4lSbt7CXB8a1r90dtLOj/7vu+TlooZ8oA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZiAfGJ8/; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZiAfGJ8/" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7e24aa659abso22434839f.3 for ; Wed, 22 May 2024 11:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1716403238; x=1717008038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=ZiAfGJ8/7Tp3Wp5CYTquG8GZV24qMCLf0ceknIzVUcWQ/8PEFow+ystDmKwo3No7nx Gs0VPJw/OIHVC7sIc/TknKQExOnL7DRsjptWGKUDfxLt4Hpfmkob/lyeltGGr/tH1dpJ g8lwbAoUPdmzQL8TWpUmDt1wjZrxz0Fp1sbNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716403238; x=1717008038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=Ua4RwZtvTDEfHVeQGYn0LAdTUoDvy9qhCCpwfVHaYXq7nDVJhWtiWUmMQstCrHblLF 6vwMuWo7oVpcWyyM0SFQrJRzGp1/Ir4JTCVzxzA9B2tBn3EI+KN/jIUKC2whg+3UDtiX LFx0h16rto36kAJMWSHsrYi32OTW8JZETuCB+chOkJxGL0RpVAhDxxPTsysCdd9M4slf Mn8ptK8Qj+FpFzGNiOGPju5f6LMabCG/T87bXzFJ7hAlbcbYKCdluEUJ/1UHVeJ9zhrJ vPpEif/vqHdHDNelH0PuRfsEF9sbz5FKxkdBkb6QvRuOSaQXDhidwFLMQA0cLYU7aYkZ wxRg== X-Forwarded-Encrypted: i=1; AJvYcCXdkm17Pz9okgovp+6zIU0/NTYn3AsGFaLdXXlrUTpmuRu1eODkqy73+Ab75BA0DDH6DClBLga+ZGqh3QvrP/AJUucX X-Gm-Message-State: AOJu0Yw/1tFvfoMLCw/4dNZoiT1V9kr7xT4FQa0iBYuuj0voUwR6n8Ba qBXFDjL2QUaq0q8MUN8bYz8bQ4SeU9juS1rTKo/clO32CWS8LWNhcxqyRrDVatU= X-Google-Smtp-Source: AGHT+IHfJbSzf9eR6h+5NiCKdgJYC/D5h2NHJ2n/qeMndC5IVVrtGPtwRsxEDeIFRtYop2k9g8p2Vw== X-Received: by 2002:a05:6602:420a:b0:7de:b279:fb3e with SMTP id ca18e2360f4ac-7e37db353b9mr293535939f.1.1716403238250; Wed, 22 May 2024 11:40:38 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-48a42b0e43dsm4496318173.101.2024.05.22.11.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 11:40:37 -0700 (PDT) Message-ID: <7a7d6b6c-0f28-4ffe-9bf2-a25c088636db@linuxfoundation.org> Date: Wed, 22 May 2024 12:40:36 -0600 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/68] Define _GNU_SOURCE for sources using To: Edward Liaw , Jakub Kicinski Cc: Andrew Morton , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, Shuah Khan References: <20240522005913.3540131-1-edliaw@google.com> <6caf3332-9ed9-4257-9532-4fd71c465c0d@linuxfoundation.org> <20240522101349.565a745e@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/22/24 11:44, Edward Liaw wrote: > On Wed, May 22, 2024 at 10:13 AM Jakub Kicinski wrote: >> >> On Wed, 22 May 2024 10:19:33 -0600 Shuah Khan wrote: >>> On 5/21/24 18:56, Edward Liaw wrote: >>>> Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes >>>> redefinitions of _GNU_SOURCE from source code. >>>> >>>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >>>> asprintf into kselftest_harness.h, which is a GNU extension and needs >>> >>> Easier solution to define LINE_MAX locally. In gerenal it is advisable >>> to not add local defines, but it is desirable in some cases to avoid >>> churn like this one. >> >> Will the patch that Andrew applied: >> https://lore.kernel.org/all/20240519213733.2AE81C32781@smtp.kernel.org/ >> make its way to Linus? As you say that's a much simpler fix. > Thank you Jakub. Yes. This is a simpler fix. > Right, this patch series may be unnecessary after all, since the > problem is fixed by that patch. > > It might be better to drop the series unless it is desirable to > centralize the declaration of _GNU_SOURCE to the root Makefile / > lib.mk. If that is still wanted, maybe a more palatable approach > would be to surround every instance of #define _GNU_SOURCE with > #ifndef _GNU_SOURCE first, then induce the change to CFLAGS in lib.mk. > That would prevent a partial merge from triggering build warnings. Please drop this series. thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2101CC25B79 for ; Wed, 22 May 2024 18:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vZoBNCsR9XtJiZG9qD7lBcvc9r5/VWzZgNScSPo7aCI=; b=SsykC3hAxvbJ+Y SfuhM/D7RKc/Zhb380fReoY+7eQIVEt6H6VcggfB0gQPpDvbdopfL7fj9cg8qRwlFbVSwnsYJtane q8TsfIWL2OCGbRN7oTNoKj8PTKUcCC8h26DQef3y09Dzr5B1V0l4WjTnCXuEUOuZCudeY+IpUM978 wxiC559zp62MEoTVxIW0tZ42p6Od0vI7GROCUS1L4oD/3ZJUuNW5NWiWiP3cxjgcPzCcLw0eyJQyT n4nPo3M5JxGIu+VaPngbF34gbWumdICN6WZNPL7QOCPOs/RlVRjvo1/KNQvOh+9mUwZb1lY3oXLaf RkbMBvtg1DdpGS8S9jQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9qtH-00000003piy-30jT; Wed, 22 May 2024 18:40:43 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9qtE-00000003phl-23Xo for linux-riscv@lists.infradead.org; Wed, 22 May 2024 18:40:42 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7dec804bd19so17470739f.1 for ; Wed, 22 May 2024 11:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1716403238; x=1717008038; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=h8GGKxE4tVE7lVh1tnZNy8/omjw+ENyPyovHbUFSHIS+t8y2GRValhDcbZpPsq5kGB 7HDhAUVBmKqep9P69POslN8q1OYC/ma5MdtsowjZODJ5S0vwwe8hrcqzKS3i7Y+1iQs2 9ry1vc39nuOokT77mx7qRy99bxcLmD3qcmoS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716403238; x=1717008038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=F9DpyebRlerFz8Gl3vN3MINdioqj9zk71HtwrHjmQuFirFp50kmQwJkhUwKc1aDt/M n9QNcKS+IyB4RjDMZMgwvr2ITgHuIcKhufonwjPXgxx4Y79J4cxyhNMUXH5Z9MSpKdWg XLkxORXE+sF+1wXDv/SD0TmKYokV2VrjI/nupq6aKPDpKj5ECZjvihispX49ndL+Ew2w hrXzrIsawo5pK7OnV1rW4W7gh2YL4zh09gYGdqvgJmnBtupQlm0JWe/2cylNvet3+yit BRmCZ4u/+Nv5Ns2XuXuZ50mVWQ2xf07Lh5kLYyYdfMy/6pm7oht4+RRHLoHnEEt6Bc0e h69A== X-Forwarded-Encrypted: i=1; AJvYcCVs9uCXRnZCd1VXoCmEsvk5WWcowWsdbi8EXfUry69XyM1M9oZfoptr1y0PEBs35IU8p7xc4rMdHbpe/wXiCttmLucSRctkMjurFMDTOrHy X-Gm-Message-State: AOJu0Yw+azrRmiNiq12hSt7mmZpndT+abibKJBEY2m1tZVDHfVULwlgl vjTBOsvMrb80gZG4+E28kNt3+GeVNhWVG4nbbs1rhcy69alPR9BR9bhIgWmq/Q0= X-Google-Smtp-Source: AGHT+IHfJbSzf9eR6h+5NiCKdgJYC/D5h2NHJ2n/qeMndC5IVVrtGPtwRsxEDeIFRtYop2k9g8p2Vw== X-Received: by 2002:a05:6602:420a:b0:7de:b279:fb3e with SMTP id ca18e2360f4ac-7e37db353b9mr293535939f.1.1716403238250; Wed, 22 May 2024 11:40:38 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-48a42b0e43dsm4496318173.101.2024.05.22.11.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 11:40:37 -0700 (PDT) Message-ID: <7a7d6b6c-0f28-4ffe-9bf2-a25c088636db@linuxfoundation.org> Date: Wed, 22 May 2024 12:40:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/68] Define _GNU_SOURCE for sources using To: Edward Liaw , Jakub Kicinski Cc: Andrew Morton , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, Shuah Khan References: <20240522005913.3540131-1-edliaw@google.com> <6caf3332-9ed9-4257-9532-4fd71c465c0d@linuxfoundation.org> <20240522101349.565a745e@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_114040_567999_11E58499 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gNS8yMi8yNCAxMTo0NCwgRWR3YXJkIExpYXcgd3JvdGU6Cj4gT24gV2VkLCBNYXkgMjIsIDIw MjQgYXQgMTA6MTPigK9BTSBKYWt1YiBLaWNpbnNraSA8a3ViYUBrZXJuZWwub3JnPiB3cm90ZToK Pj4KPj4gT24gV2VkLCAyMiBNYXkgMjAyNCAxMDoxOTozMyAtMDYwMCBTaHVhaCBLaGFuIHdyb3Rl Ogo+Pj4gT24gNS8yMS8yNCAxODo1NiwgRWR3YXJkIExpYXcgd3JvdGU6Cj4+Pj4gQ2VudHJhbGl6 ZXMgdGhlIGRlZmluaXRpb24gb2YgX0dOVV9TT1VSQ0UgaW50byBLSERSX0lOQ0xVREVTIGFuZCBy ZW1vdmVzCj4+Pj4gcmVkZWZpbml0aW9ucyBvZiBfR05VX1NPVVJDRSBmcm9tIHNvdXJjZSBjb2Rl Lgo+Pj4+Cj4+Pj4gODA5MjE2MjMzNTU1ICgic2VsZnRlc3RzL2hhcm5lc3M6IHJlbW92ZSB1c2Ug b2YgTElORV9NQVgiKSBpbnRyb2R1Y2VkCj4+Pj4gYXNwcmludGYgaW50byBrc2VsZnRlc3RfaGFy bmVzcy5oLCB3aGljaCBpcyBhIEdOVSBleHRlbnNpb24gYW5kIG5lZWRzCj4+Pgo+Pj4gRWFzaWVy IHNvbHV0aW9uIHRvIGRlZmluZSBMSU5FX01BWCBsb2NhbGx5LiBJbiBnZXJlbmFsIGl0IGlzIGFk dmlzYWJsZQo+Pj4gdG8gbm90IGFkZCBsb2NhbCBkZWZpbmVzLCBidXQgaXQgaXMgZGVzaXJhYmxl IGluIHNvbWUgY2FzZXMgdG8gYXZvaWQKPj4+IGNodXJuIGxpa2UgdGhpcyBvbmUuCj4+Cj4+IFdp bGwgdGhlIHBhdGNoIHRoYXQgQW5kcmV3IGFwcGxpZWQ6Cj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2FsbC8yMDI0MDUxOTIxMzczMy4yQUU4MUMzMjc4MUBzbXRwLmtlcm5lbC5vcmcvCj4+IG1h a2UgaXRzIHdheSB0byBMaW51cz8gQXMgeW91IHNheSB0aGF0J3MgYSBtdWNoIHNpbXBsZXIgZml4 Lgo+IAoKVGhhbmsgeW91IEpha3ViLiBZZXMuIFRoaXMgaXMgYSBzaW1wbGVyIGZpeC4KCj4gUmln aHQsIHRoaXMgcGF0Y2ggc2VyaWVzIG1heSBiZSB1bm5lY2Vzc2FyeSBhZnRlciBhbGwsIHNpbmNl IHRoZQo+IHByb2JsZW0gaXMgZml4ZWQgYnkgdGhhdCBwYXRjaC4KPiAKPiBJdCBtaWdodCBiZSBi ZXR0ZXIgdG8gZHJvcCB0aGUgc2VyaWVzIHVubGVzcyBpdCBpcyBkZXNpcmFibGUgdG8KPiBjZW50 cmFsaXplIHRoZSBkZWNsYXJhdGlvbiBvZiBfR05VX1NPVVJDRSB0byB0aGUgcm9vdCBNYWtlZmls ZSAvCj4gbGliLm1rLiAgSWYgdGhhdCBpcyBzdGlsbCB3YW50ZWQsIG1heWJlIGEgbW9yZSBwYWxh dGFibGUgYXBwcm9hY2gKPiB3b3VsZCBiZSB0byBzdXJyb3VuZCBldmVyeSBpbnN0YW5jZSBvZiAj ZGVmaW5lIF9HTlVfU09VUkNFIHdpdGgKPiAjaWZuZGVmIF9HTlVfU09VUkNFIGZpcnN0LCB0aGVu IGluZHVjZSB0aGUgY2hhbmdlIHRvIENGTEFHUyBpbiBsaWIubWsuCj4gVGhhdCB3b3VsZCBwcmV2 ZW50IGEgcGFydGlhbCBtZXJnZSBmcm9tIHRyaWdnZXJpbmcgYnVpbGQgd2FybmluZ3MuCgpQbGVh c2UgZHJvcCB0aGlzIHNlcmllcy4KCnRoYW5rcywKLS0gU2h1YWgKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QK bGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==