From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714C0EB64DD for ; Thu, 27 Jul 2023 05:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232457AbjG0FoW (ORCPT ); Thu, 27 Jul 2023 01:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233056AbjG0Fnw (ORCPT ); Thu, 27 Jul 2023 01:43:52 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 306B544A3 for ; Wed, 26 Jul 2023 22:42:40 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b8ad907ba4so3584995ad.0 for ; Wed, 26 Jul 2023 22:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1690436497; x=1691041297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5hOt4JSGfUE5gU0yacloLGJlfRYBYpf+ipeOpBUjKNM=; b=Kuq9l8I7Ju9+mfwW/4hNW7XR2Of8OzPo9y3Knw4BfrpCs99gGGoSzDMYJnVSc+QCPO IBmUoXbgJFEMzxwfKyXTVvSgevk2H/JsIf0tMDC1KBlqFzMV/Kg5mn38xva5mum5pY1V rkgSC9C3h1igGM0Ha8T8mvi9eLoQ84lWq8fAiAqq4rVr26S9AnVJm/tZgYK0+7BIcHmy WYc8jC2FKhI8k7JnaHiGi7pn4nlPJduoNAMC1MS8ZEShlOcIg2UGfJUv86WRFUZCRvOK heFJKWYxs81gekLI23ka3N5kbL7Z9E93tnQgfCXSborYvO5V2w5YxwjQk5g+zwf9bHR/ P4cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690436497; x=1691041297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5hOt4JSGfUE5gU0yacloLGJlfRYBYpf+ipeOpBUjKNM=; b=XuuG9XdeIr9e6/O1m3gjjqBIfFUmrHnAclchEvL9CKNmWgXPS0f4tbCMDGSvWqZZyv DjEnMqu/JqoevZls+BJBThaJ9Yx2SF6P3w9U0u8iZLKWuIf8RcQnCa9f7vb+awLsVgjD xBhQTPAUUTx+Ha8rIF+xdm3yXsfn276SwRqMkyHAtK/P+rtWBopeY7pnxNrDP+CVNGtL drtu1rRL6b/6rFxmcLi623CHQMovsT3MfLhKmObHXlOHlhGAPmujzTp6N1sEwySIxBVH ptS72vVVVz3KQMhk5rSv0Dy9Vo7cHQaW+Ptu9b1M1h7iP7djTvm2ibiGNmkU532bc3Kg n4dQ== X-Gm-Message-State: ABy/qLbrH4qu1pbVMUQIk5gH1nuO0jtaKlSpQAvwjw1QqcXZwvZ9oGmz IPqZhvmo/uxcR9cF0ZyHQ/aMTA== X-Google-Smtp-Source: APBJJlGLqhEYZFyockZ7kQ8xzFt6+vTwuXVKCHw0Pf4YFqnPNsgR9xQM23jn+ls85R/x9uD/DbKECg== X-Received: by 2002:a17:903:48d:b0:1b9:cb27:7f43 with SMTP id jj13-20020a170903048d00b001b9cb277f43mr3256746plb.43.1690436497422; Wed, 26 Jul 2023 22:41:37 -0700 (PDT) Received: from [10.0.2.15] ([82.78.167.79]) by smtp.gmail.com with ESMTPSA id jw16-20020a170903279000b001b8a7e1b116sm561407plb.191.2023.07.26.22.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 22:41:37 -0700 (PDT) Message-ID: <7a8e07cf-2995-0018-b658-91a37457f05b@tuxon.dev> Date: Thu, 27 Jul 2023 08:41:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 46/61] mmc: atmel-mci: Convert to platform remove callback returning void Content-Language: en-US To: Yangtao Li , Ludovic Desroches , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-46-frank.li@vivo.com> From: claudiu beznea In-Reply-To: <20230726040041.26267-46-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 26.07.2023 07:00, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König > Signed-off-by: Yangtao Li Reviewed-by: Claudiu Beznea > --- > drivers/mmc/host/atmel-mci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c > index dd18440a90c5..b4ae9aa939a5 100644 > --- a/drivers/mmc/host/atmel-mci.c > +++ b/drivers/mmc/host/atmel-mci.c > @@ -2600,7 +2600,7 @@ static int atmci_probe(struct platform_device *pdev) > return ret; > } > > -static int atmci_remove(struct platform_device *pdev) > +static void atmci_remove(struct platform_device *pdev) > { > struct atmel_mci *host = platform_get_drvdata(pdev); > unsigned int i; > @@ -2630,8 +2630,6 @@ static int atmci_remove(struct platform_device *pdev) > > pm_runtime_disable(&pdev->dev); > pm_runtime_put_noidle(&pdev->dev); > - > - return 0; > } > > #ifdef CONFIG_PM > @@ -2664,7 +2662,7 @@ static const struct dev_pm_ops atmci_dev_pm_ops = { > > static struct platform_driver atmci_driver = { > .probe = atmci_probe, > - .remove = atmci_remove, > + .remove_new = atmci_remove, > .driver = { > .name = "atmel_mci", > .probe_type = PROBE_PREFER_ASYNCHRONOUS, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C98CEB64DD for ; Thu, 27 Jul 2023 05:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S8aY9Kh6G3RZcsvu2mjQSQ+3bpdc2hKgxbvd5Jg3Zco=; b=FQyNfVtLhFpXOQ sW7LVcD7UVL6DGVaMmeuuGD/uOgmO+TS8fWrL3Ur4xrnTwYcvXaIRGcODfjyRcBPFPtqvmt7rmYHT xTNSgJji2sIFJgCdpTwWMl7meG4qZL0O9ek2gfcnRJJ8vwr4LLBoDhejtqzFnvKVNOnoDxpW3AKFJ VJ3MqbqdvDctMwVjbkhaJIj+ltN6wXNNPFNBnKpHRjq4fPJ64NvlaDzEfnJkTu0VINxJd3eWC/US7 fb9rdER6KS9CM6bLknQo+7P1voKTt9ma2CUsdBKndG6NLPhmtTEGJu6lpIDM3wVuh2/lc68hKaBko 6LpnTqumLQwf5dygehyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOtkr-00CEUe-26; Thu, 27 Jul 2023 05:41:41 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOtkp-00CETz-04 for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 05:41:40 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1b89d47ffb6so3444185ad.2 for ; Wed, 26 Jul 2023 22:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1690436497; x=1691041297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5hOt4JSGfUE5gU0yacloLGJlfRYBYpf+ipeOpBUjKNM=; b=Kuq9l8I7Ju9+mfwW/4hNW7XR2Of8OzPo9y3Knw4BfrpCs99gGGoSzDMYJnVSc+QCPO IBmUoXbgJFEMzxwfKyXTVvSgevk2H/JsIf0tMDC1KBlqFzMV/Kg5mn38xva5mum5pY1V rkgSC9C3h1igGM0Ha8T8mvi9eLoQ84lWq8fAiAqq4rVr26S9AnVJm/tZgYK0+7BIcHmy WYc8jC2FKhI8k7JnaHiGi7pn4nlPJduoNAMC1MS8ZEShlOcIg2UGfJUv86WRFUZCRvOK heFJKWYxs81gekLI23ka3N5kbL7Z9E93tnQgfCXSborYvO5V2w5YxwjQk5g+zwf9bHR/ P4cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690436497; x=1691041297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5hOt4JSGfUE5gU0yacloLGJlfRYBYpf+ipeOpBUjKNM=; b=VAT9FqQIEk/wTODhyECZPIZ1wmLooNC8LjFAwIzOtJViKwLsn87W4rmA9siClWg6L7 sNoSP3RB6E+tioxNd4M3eUuLiPqcFSBZoox9k5d5+vZnIy2GZJUTTyrvT2XpbxHv90tn FwoEv840zrhZ2Kf+eh+kPVqdaJqP/wtFTNfQtm+eOiDviJs2YItY+7f3jP0+EkfqYBFA 8Cm6BAEIoMPzPIyYEQqtFn3ZK0n6hlsvi43VvkNb+JyGZ350tSUmNr/26Q1EwuJqThrk Q0aRWaBK5R6+dtXvzpGnIloxBaXXH42WQKGEg26xWfuOmlhMFTWBUHijT/MUReXdobaO bnRg== X-Gm-Message-State: ABy/qLYYEg6YxDZBsFfHxv9muS2Z0APpJ+wvdbJJV/nIeMqcgHtKgfoJ 8EL5DALljQ8pjSJUB5A5ZHC8ag== X-Google-Smtp-Source: APBJJlGLqhEYZFyockZ7kQ8xzFt6+vTwuXVKCHw0Pf4YFqnPNsgR9xQM23jn+ls85R/x9uD/DbKECg== X-Received: by 2002:a17:903:48d:b0:1b9:cb27:7f43 with SMTP id jj13-20020a170903048d00b001b9cb277f43mr3256746plb.43.1690436497422; Wed, 26 Jul 2023 22:41:37 -0700 (PDT) Received: from [10.0.2.15] ([82.78.167.79]) by smtp.gmail.com with ESMTPSA id jw16-20020a170903279000b001b8a7e1b116sm561407plb.191.2023.07.26.22.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 22:41:37 -0700 (PDT) Message-ID: <7a8e07cf-2995-0018-b658-91a37457f05b@tuxon.dev> Date: Thu, 27 Jul 2023 08:41:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 46/61] mmc: atmel-mci: Convert to platform remove callback returning void Content-Language: en-US To: Yangtao Li , Ludovic Desroches , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-46-frank.li@vivo.com> From: claudiu beznea In-Reply-To: <20230726040041.26267-46-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230726_224139_061448_A6E77DCC X-CRM114-Status: GOOD ( 25.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyNi4wNy4yMDIzIDA3OjAwLCBZYW5ndGFvIExpIHdyb3RlOgo+IFRoZSAucmVtb3ZlKCkg Y2FsbGJhY2sgZm9yIGEgcGxhdGZvcm0gZHJpdmVyIHJldHVybnMgYW4gaW50IHdoaWNoIG1ha2Vz Cj4gbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBvc3NpYmxlIHRvIGRv IGVycm9yIGhhbmRsaW5nIGJ5Cj4gcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUuIEhvd2V2ZXIgdGhl IHZhbHVlIHJldHVybmVkIGlzIChtb3N0bHkpIGlnbm9yZWQKPiBhbmQgdGhpcyB0eXBpY2FsbHkg cmVzdWx0cyBpbiByZXNvdXJjZSBsZWFrcy4gVG8gaW1wcm92ZSBoZXJlIHRoZXJlIGlzIGEKPiBx dWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRoZSBmaXJz dCBzdGVwIG9mIHRoaXMKPiBxdWVzdCBhbGwgZHJpdmVycyBhcmUgY29udmVydGVkIHRvIC5yZW1v dmVfbmV3KCkgd2hpY2ggYWxyZWFkeSByZXR1cm5zCj4gdm9pZC4KPiAKPiBUcml2aWFsbHkgY29u dmVydCB0aGlzIGRyaXZlciBmcm9tIGFsd2F5cyByZXR1cm5pbmcgemVybyBpbiB0aGUgcmVtb3Zl Cj4gY2FsbGJhY2sgdG8gdGhlIHZvaWQgcmV0dXJuaW5nIHZhcmlhbnQuCj4gCj4gQ2M6IFV3ZSBL bGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4gU2lnbmVkLW9m Zi1ieTogWWFuZ3RhbyBMaSA8ZnJhbmsubGlAdml2by5jb20+CgpSZXZpZXdlZC1ieTogQ2xhdWRp dSBCZXpuZWEgPGNsYXVkaXUuYmV6bmVhQHR1eG9uLmRldj4KCj4gLS0tCj4gICBkcml2ZXJzL21t Yy9ob3N0L2F0bWVsLW1jaS5jIHwgNiArKy0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbW1jL2hv c3QvYXRtZWwtbWNpLmMgYi9kcml2ZXJzL21tYy9ob3N0L2F0bWVsLW1jaS5jCj4gaW5kZXggZGQx ODQ0MGE5MGM1Li5iNGFlOWFhOTM5YTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tbWMvaG9zdC9h dG1lbC1tY2kuYwo+ICsrKyBiL2RyaXZlcnMvbW1jL2hvc3QvYXRtZWwtbWNpLmMKPiBAQCAtMjYw MCw3ICsyNjAwLDcgQEAgc3RhdGljIGludCBhdG1jaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiAtc3RhdGljIGludCBhdG1j aV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArc3RhdGljIHZvaWQgYXRt Y2lfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICB7Cj4gICAJc3RydWN0 IGF0bWVsX21jaQkqaG9zdCA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ICAgCXVuc2ln bmVkIGludAkJaTsKPiBAQCAtMjYzMCw4ICsyNjMwLDYgQEAgc3RhdGljIGludCBhdG1jaV9yZW1v dmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIAo+ICAgCXBtX3J1bnRpbWVfZGlz YWJsZSgmcGRldi0+ZGV2KTsKPiAgIAlwbV9ydW50aW1lX3B1dF9ub2lkbGUoJnBkZXYtPmRldik7 Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiAgICNpZmRlZiBDT05GSUdfUE0KPiBAQCAt MjY2NCw3ICsyNjYyLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkZXZfcG1fb3BzIGF0bWNpX2Rl dl9wbV9vcHMgPSB7Cj4gICAKPiAgIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGF0bWNp X2RyaXZlciA9IHsKPiAgIAkucHJvYmUJCT0gYXRtY2lfcHJvYmUsCj4gLQkucmVtb3ZlCQk9IGF0 bWNpX3JlbW92ZSwKPiArCS5yZW1vdmVfbmV3CT0gYXRtY2lfcmVtb3ZlLAo+ICAgCS5kcml2ZXIJ CT0gewo+ICAgCQkubmFtZQkJPSAiYXRtZWxfbWNpIiwKPiAgIAkJLnByb2JlX3R5cGUJPSBQUk9C RV9QUkVGRVJfQVNZTkNIUk9OT1VTLAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=