From: Lance Yang <lance.yang@linux.dev>
To: ranxiaokai627@163.com
Cc: leitao@debian.org, ljs@kernel.org, ziy@nvidia.com,
liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, akpm@linux-foundation.org, baohua@kernel.org,
david@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn,
hughd@google.com, baolin.wang@linux.alibaba.com
Subject: Re: [PATCH v3 2/2] mm: shmem: refactor thpsize_shmem_enabled_show() with helper arrays
Date: Thu, 21 May 2026 21:18:52 +0800 [thread overview]
Message-ID: <7a976d40-54a8-43f1-9d7f-744cb34e7bc1@linux.dev> (raw)
In-Reply-To: <20260518123238.56344-3-ranxiaokai627@163.com>
On 2026/5/18 20:32, ranxiaokai627@163.com wrote:
> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>
> Replace the hardcoded if/else chain of test_bit() calls and string
> literals in thpsize_shmem_enabled_show() with a loop over
> huge_shmem_orders_by_mode[] and huge_shmem_enabled_mode_strings[] arrays.
>
> This makes thpsize_shmem_enabled_show() consistent with
> thpsize_shmem_enabled_store() and eliminates duplicated mode name strings.
>
> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Reviewed-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>
> ---
Thanks.
Tested-by: Lance Yang <lance.yang@linux.dev>
next prev parent reply other threads:[~2026-05-21 13:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:32 [PATCH v3 0/2] refactors thpsize_shmem_enabled_store() and thpsize_shmem_enabled_show() ranxiaokai627
2026-05-18 12:32 ` [PATCH v3 1/2] mm: shmem: refactor thpsize_shmem_enabled_store() with sysfs_match_string() ranxiaokai627
2026-05-19 2:22 ` Baolin Wang
2026-05-21 13:17 ` Lance Yang
2026-05-22 8:07 ` Barry Song
2026-05-22 10:39 ` Lorenzo Stoakes
2026-05-22 10:55 ` Lorenzo Stoakes
2026-05-25 7:52 ` ranxiaokai627
2026-05-18 12:32 ` [PATCH v3 2/2] mm: shmem: refactor thpsize_shmem_enabled_show() with helper arrays ranxiaokai627
2026-05-21 13:18 ` Lance Yang [this message]
2026-05-22 10:34 ` Lorenzo Stoakes
2026-05-22 10:44 ` Barry Song
2026-05-22 10:56 ` Lorenzo Stoakes
2026-05-22 10:54 ` Lorenzo Stoakes
2026-05-22 11:36 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a976d40-54a8-43f1-9d7f-744cb34e7bc1@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=leitao@debian.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=npache@redhat.com \
--cc=ran.xiaokai@zte.com.cn \
--cc=ranxiaokai627@163.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.