All of lore.kernel.org
 help / color / mirror / Atom feed
From: sunran001@208suo.com
To: dennis@kernel.org, tj@kernel.org, cl@linux.com,
	akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC
Date: Tue, 18 Jul 2023 14:35:11 +0800	[thread overview]
Message-ID: <7aa3a1cee63518cb13906d11ea130c9c@208suo.com> (raw)
In-Reply-To: <20230718063328.16140-1-xujianghui@cdjrlc.com>

ERROR: function pcpu_balance_populated called on line 2238 inside lock
on line 2234 but uses GFP_KERNEL

Generated by: scripts/coccinelle/locks/call_kern.cocci

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  mm/percpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/percpu.c b/mm/percpu.c
index 28e07ede46f6..d8809c7511cd 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -2033,7 +2033,7 @@ static void pcpu_balance_free(bool empty_only)
  static void pcpu_balance_populated(void)
  {
      /* gfp flags passed to underlying allocators */
-    const gfp_t gfp = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN;
+    const gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN;
      struct pcpu_chunk *chunk;
      int slot, nr_to_pop, ret;

       reply	other threads:[~2023-07-18  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230718063328.16140-1-xujianghui@cdjrlc.com>
2023-07-18  6:35 ` sunran001 [this message]
2023-07-18 17:17   ` [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC Andrew Morton
2023-07-20 23:43     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aa3a1cee63518cb13906d11ea130c9c@208suo.com \
    --to=sunran001@208suo.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=dennis@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.