From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Brad Griffis <bgriffis@nvidia.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] arm64: tegra: Fix Tegra234 PCIe interrupt-map
Date: Fri, 13 Dec 2024 11:37:25 +0000 [thread overview]
Message-ID: <7ab2cc1a-a461-495f-824d-9dd62973cf48@nvidia.com> (raw)
In-Reply-To: <942ae75e-51d1-4265-adec-e1446fe0ff48@linaro.org>
Hi Krzysztof!
On 13/12/2024 11:11, Krzysztof Kozlowski wrote:
> On 12/12/2024 22:11, Brad Griffis wrote:
>> For interrupt-map entries, the DTS specification requires
>> that #address-cells is defined for both the child node and the
>> interrupt parent. For the PCIe interrupt-map entries, the parent
>> node ("gic") has not specified #address-cells. The existing layout
>> of the PCIe interrupt-map entries indicates that it assumes
>> that #address-cells is zero for this node.
>>
>> Explicitly set #address-cells to zero for "gic" so that it complies
>> with the device tree specification.
>>
>> Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
>> ---
>
> So entire nvidia works on old kernel and sends patches rebased on old
> kernel? Please start working on mainline.
You know that is not the case! Yes there may be a few cases of people
using your old email, but not all of us :-)
> I give the same feedback multiple times and still nvidia repeats the
> same mistakes.
>
> You CC-ed an address, which suggests you do not work on mainline kernel
> or you do not use get_maintainers.pl/b4/patman. Please rebase and always
> work on mainline or start using mentioned tools, so correct addresses
> will be used.
This applies on top of today's -next and so I don't see any need to resend.
FYI, Brad has been working improve our testing for mainline and -next
and so I know he is working on mainline.
So are we perfect? No. But we are working on getting better!
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2024-12-13 11:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 21:11 [PATCH] arm64: tegra: Fix Tegra234 PCIe interrupt-map Brad Griffis
2024-12-13 9:51 ` Jon Hunter
2024-12-13 10:21 ` Thierry Reding
2024-12-13 11:11 ` Krzysztof Kozlowski
2024-12-13 11:37 ` Jon Hunter [this message]
2024-12-13 13:26 ` Krzysztof Kozlowski
2024-12-14 0:35 ` Brad Griffis
2024-12-14 10:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ab2cc1a-a461-495f-824d-9dd62973cf48@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bgriffis@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.