From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 801F5C4167B for ; Fri, 15 Dec 2023 11:07:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2C2DF83DB1; Fri, 15 Dec 2023 11:07:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2C2DF83DB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702638425; bh=eE3ZOX73ow4WZ1LYXguVpyU+7+pcXw9xMTUFUYRRjcI=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wVqFeGBr5sUoaufTVYRja9veMsINq+SlNmhxUf1uaI0Evwk5kcXP+4Bgs0BDUoJ+u AejAX229ofcwPU/RrJFkH1e2qTjSDtBmGRUR9aib54LR0/MCDLJ4JeeFg0pVrApKKL vYZ/hZiYySatAFjlJAkcxMm3U/P1GyTAF5emCuTNnPfMts2108gkiO6/hDTBnXXG0D JFBS2OLTR6XaWqfyijV6UZgotLjLMTG4rsYzm2ThLyrgWdKuvOiydGV+Dj4jNMFFRq N8DyFeWna10snBkPRrYQLf+cZEnZif8l1OAxk7yKZ55YKIg6uKPHr+cfKk2L1cx56n f1sWohk4O0euQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e6JD48sw4Ytw; Fri, 15 Dec 2023 11:07:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 19E80812CB; Fri, 15 Dec 2023 11:07:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 19E80812CB Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E09EB1BF404 for ; Fri, 15 Dec 2023 11:07:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BA077401C2 for ; Fri, 15 Dec 2023 11:07:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BA077401C2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rRCd4AzCGOvq for ; Fri, 15 Dec 2023 11:07:01 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 437E94011A for ; Fri, 15 Dec 2023 11:07:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 437E94011A Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-C6yt4rebMHCvS06JD4n2eg-1; Fri, 15 Dec 2023 06:06:58 -0500 X-MC-Unique: C6yt4rebMHCvS06JD4n2eg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a1d3a7dbb81so12429466b.0 for ; Fri, 15 Dec 2023 03:06:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702638417; x=1703243217; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+SBrpdDFNUNV9rPT9NLwnq0LGAxyDiW4IAOIo/k6GdI=; b=KIAdOJwSG6aLPVO6pO/XNCnsjihpzB7ODSI0D2SQ9Pn3Bvk8OqLFAPpROsO8O0em7L WyEwd3AWkjMBXEIjvwtTRDZh5j4hMQvjkeLQW0Z1+Ba3XM70jpQ4DQ8wP2eO324MEpxa UsSt4QJQeDB6a55TTADB25TA9ogK48yVqQhDTyFhkPzJLYh7/Yl5GwJixpAU+AZzTFAL eIXSdBPIeia4i1NPfrMZynBpAv43MVO1p6+wjv1iU1tKAZ5zBzdW76bjSIBZRUDTyYIV 2LpoSXqJeIGOHp3S14QaZ2uYsFoH5ZCv4OlLjySW3rP4dcs2LO5iU1+xpX25uEaNwP1r gxHw== X-Gm-Message-State: AOJu0Yw4QXLhSaGBd4xrTLmw+zoLg5LdyqFhasjvMYp5X6J2S5KQzXhi ejA+gM/oj7y1q4kXnVG9fME7TX0T8fTelqZ0m28HOLMcIymCkiZJRvwTR8LjTqiAAA+PsrRkP+K CyCZgzl5ql/y9ASVJg6UfLgkmkL37qA== X-Received: by 2002:a17:907:c312:b0:a01:ae7b:d19b with SMTP id tl18-20020a170907c31200b00a01ae7bd19bmr13400105ejc.7.1702638416815; Fri, 15 Dec 2023 03:06:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqpkcw+CXAIe9OcjU9a+jALwDiPC7w1Lq9B7//FnjoXl2yypFOCqn4E0ZWOM64gx9WBsXmQw== X-Received: by 2002:a17:907:c312:b0:a01:ae7b:d19b with SMTP id tl18-20020a170907c31200b00a01ae7bd19bmr13400093ejc.7.1702638416441; Fri, 15 Dec 2023 03:06:56 -0800 (PST) Received: from gerbillo.redhat.com (146-241-255-162.dyn.eolo.it. [146.241.255.162]) by smtp.gmail.com with ESMTPSA id st10-20020a170907c08a00b00a1cd0794696sm10590739ejc.53.2023.12.15.03.06.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 03:06:55 -0800 (PST) Message-ID: <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> From: Paolo Abeni To: Jakub Kicinski , Jiri Pirko Date: Fri, 15 Dec 2023 12:06:52 +0100 In-Reply-To: <20231214174604.1ca4c30d@kernel.org> References: <20230727021021.961119-1-wenjun1.wu@intel.com> <20230822034003.31628-1-wenjun1.wu@intel.com> <20230822081255.7a36fa4d@kernel.org> <0893327b-1c84-7c25-d10c-1cc93595825a@intel.com> <5aed9b87-28f8-f0b0-67c4-346e1d8f762c@intel.com> <20231118084843.70c344d9@kernel.org> <3d60fabf-7edf-47a2-9b95-29b0d9b9e236@intel.com> <20231122192201.245a0797@kernel.org> <20231127174329.6dffea07@kernel.org> <55e51b97c29894ebe61184ab94f7e3d8486e083a.camel@redhat.com> <20231214174604.1ca4c30d@kernel.org> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702638419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+SBrpdDFNUNV9rPT9NLwnq0LGAxyDiW4IAOIo/k6GdI=; b=c4jQJRL9pSlhHb4Ac3mktdYA91ZY1fLOsqrdipv8HUn0BZzLjpkkGgUW1l+1y1a/7awYpV IJx/IUAtV9X74r7gOEY9OAj7gqpmCooEVQFoimoJJOLk4TeKYVmcWGw2C8X+CtwXJnDRCi BEOVWbsl8tadLjio2MZilSCEeYKq/S8= X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c4jQJRL9 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Samudrala, Sridhar" , netdev@vger.kernel.org, Simon Horman , anthony.l.nguyen@intel.com, "Chittim, Madhu" , maxtram95@gmail.com, qi.z.zhang@intel.com, intel-wired-lan@lists.osuosl.org, Wenjun Wu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gVGh1LCAyMDIzLTEyLTE0IGF0IDE3OjQ2IC0wODAwLCBKYWt1YiBLaWNpbnNraSB3cm90ZToK PiBPbiBUaHUsIDE0IERlYyAyMDIzIDIxOjI5OjUxICswMTAwIFBhb2xvIEFiZW5pIHdyb3RlOgo+ ID4gVG9nZXRoZXIgd2l0aCBTaW1vbiwgSSBzcGVudCBzb21lIHRpbWUgb24gdGhlIGFib3ZlLiBX ZSB0aGluayB0aGUKPiA+IG5kb19zZXR1cF90YyhUQ19TRVRVUF9RRElTQ19UQkYpIGhvb2sgY291 bGQgYmUgdXNlZCBhcyBjb21tb24gYmFzaXMgZm9yCj4gPiB0aGlzIG9mZmxvYWRzLCB3aXRoIHNv bWUgc21hbGwgZXh0ZW5zaW9ucyAoYWRkaW5nIGEgJ21heF9yYXRlJyBwYXJhbSwKPiA+IHRvbyku Cj4gCj4gdUFQSSBhc2lkZSwgd2h5IHdvdWxkIHdlIHVzZSBuZG9fc2V0dXBfdGMoVENfU0VUVVBf UURJU0NfVEJGKQo+IHRvIGltcGxlbWVudCBjb21tb24gYmFzaXM/Cj4gCj4gSXMgaXQgbm90IGNs ZWFuZXIgdG8gaGF2ZSBhIHNlcGFyYXRlIGRyaXZlciBBUEksIHdpdGggaXRzIG9wcwo+IGFuZCBj YXBhYmlsaXRpZXM/CgpXZSB1bmRlcnN0YW5kIG9uZSBvZiB0aGUgZW5kIGdvYWwgaXMgY29uc29s aWRhdGluZyB0aGUgZXhpc3RpbmcgcmF0ZS0KcmVsYXRlZCBpbiBrZXJuZWwgaW50ZXJmYWNlcy4g IEFkZGluZyBhIG5ldyBvbmUgZG9lcyBub3QgZmVlbCBhIGdvb2QKc3RhcnRpbmcgdG8gcmVhY2gg dGhhdCBnb2FsLCBzZWUgWzFdICYgWzJdIDspLiBuZG9fc2V0dXBfdGMoKSBmZWVscwpsaWtlIHRo ZSBuYXR1cmFsIGNob2ljZSBmb3IgSC9XIG9mZmxvYWQgYW5kIFRCRiBpcyB0aGUgZXhpc3RpbmcK aW50ZXJmYWNlIElNSE8gbmVhcmVzdCB0byB0aGUgcmVxdWlyZW1lbnRzIGhlcmUuCgpUaGUgZGV2 bGluayByYXRlIEFQSSBjb3VsZCBiZSBhIHBvc3NpYmxlIGFsdGVybmF0aXZlLi4uCgo+ID4gVGhl IGlkZWEgd291bGQgYmU6Cj4gPiAtICdmaXhpbmcnIHNjaF9idGYgc28gdGhhdCB0aGUgcy93IHBh dGggYmVjYW1lIGEgbm8tb3Agd2hlbiBoL3cgb2ZmbG9hZAo+ID4gaXMgZW5hYmxlZAo+ID4gLSBl eHRlbmQgc2NoX2J0ZiB0byBzdXBwb3J0IG1heCByYXRlCj4gPiAtIGRvIHRoZSByZWxldmFudCBp Y2UgaW1wbGVtZW50YXRpb24KPiA+IC0gbmRvX3NldF90eF9tYXhyYXRlIGNvdWxkIGJlIHJlcGxh Y2VkIHdpdGggdGhlIG1lbnRpb25lZCBuZG8gY2FsbCAodGhlCj4gPiBsYXR0ZXIgaW50ZXJmYWNl IGlzIGEgc3RyaWN0IHN1cGVyLXNldCBvZiBmb3JtZXIpCj4gPiAtIG5kb19zZXRfdmZfcmF0ZSBj b3VsZCBhbHNvIGJlIHJlcGxhY2VkIHdpdGggdGhlIG1lbnRpb25lZCBuZG8gY2FsbAo+ID4gKHdp dGggYW5vdGhlciBzbWFsbCBleHRlbnNpb24gdG8gdGhlIG9mZmxvYWQgZGF0YSkKPiA+IAo+ID4g SSB0aGluayBtcXByaW8gZGVzZXJ2ZXMgaXQncyBvd24gc2VwYXJhdGUgb2ZmbG9hZCBpbnRlcmZh Y2UsIGFzIGl0Cj4gPiBjb3ZlcnMgbXVsdGlwbGUgdGFza3Mgb3RoZXIgdGhhbiBzaGFwaW5nIChn cm91cGluZyBxdWV1ZXMgYW5kIG1hcHBpbmcKPiA+IHByaW9yaXR5IHRvIGNsYXNzZXMpCj4gPiAK PiA+IEluIHRoZSBsb25nIHJ1biB3ZSBjb3VsZCBoYXZlIGEgZ2VuZXJpYyBpbXBsZW1lbnRhdGlv biBvZiB0aGUKPiA+IG5kb19zZXR1cF90YyhUQ19TRVRVUF9RRElTQ19UQkYpIGluIHRlcm0gb2Yg ZGV2bGluayByYXRlIGFkZGluZyBhCj4gPiBnZW5lcmljIHdheSB0byBmZXRjaCB0aGUgZGV2bGlu a19wb3J0IGluc3RhbmNlIGNvcnJlc3BvbmRpbmcgdG8gdGhlCj4gPiBnaXZlbiBuZXRkZXYgYW5k IG1hcHBpbmcgdGhlIFRCRiBmZWF0dXJlcyB0byB0aGUgZGV2bGlua19yYXRlIEFQSS4KPiA+IAo+ ID4gTm90IHN0YXJ0aW5nIHRoaXMgZHVlIHRvIHdoYXQgSmlyaSBtZW50aW9uZWQgWzFdLgo+IAo+ IEppcmksIEFGQUlVLCBpcyBhZ2FpbnN0IHVzaW5nIGRldmxpbmsgcmF0ZSAqdUFQSSogdG8gY29u ZmlndXJlIG5ldHdvcmsKPiByYXRlIGxpbWl0aW5nLiBUaGF0J3Mgc2VwYXJhdGUgZnJvbSB0aGUg aW50ZXJuYWwgcmVwcmVzZW50YXRpb24uCgouLi4gd2l0aCBhIGNvdXBsZXMgb2YgY2F2ZWF0czoK CjEpIEFGQUlDUyBkZXZsaW5rIChhbmQvb3IgZGV2bGlua19wb3J0KSBkb2VzIG5vdCBoYXZlIGZp bmUgZ3JhaW5lZCwgcGVyCnF1ZXVlIHJlcHJlc2VudGF0aW9uIGFuZCBpbnRlbCB3YW50IHRvIGJl IGFibGUgdG8gY29uZmlndXJlIHNoYXBpbmcgb24KcGVyIHF1ZXVlIGJhc2lzLiBJIHRoaW5rL2hv cGUgd2UgZG9uJ3Qgd2FudCB0byBicmluZyB0aGUgZGlzY3Vzc2lvbiB0bwpleHRlbmRpbmcgdGhl IGRldmxpbmsgaW50ZXJmYWNlIHdpdGggcXVldWUgc3VwcG9ydCwgSSBmZWFyIHRoYXQgd2lsbApi bG9jayB1cyBmb3IgYSBsb25nIHRpbWUuIFBlcmhhcHMgSeKAmW0gbWlzc2luZyBvciBtaXN1bmRl cnN0YW5kaW5nCnNvbWV0aGluZyBoZXJlLiBPdGhlcndpc2UgaW4gcmV0cm9zcGVjdCB0aGlzIGxv b2tzIGxpa2UgYSByZWFzb25hYmxlCnBvaW50IHRvIGNvbXBsZXRlbHkgYXZvaWQgZGV2bGluayBo ZXJlLgoKMikgTXkgdW5kZXJzdGFuZGluZyBvZiBKaXJpIHN0YXRlbWVudCB3YXMgbW9yZSByZXN0 cmljdGl2ZS4gQEppcmkgaXQKd291bGQgZ3JlYXQgaWYgY291bGQgc2hhcmUgeW91ciBnZW51aW5l IGludGVycHJldGF0aW9uOiBhcmUgeW91IG9rIHdpdGgKdXNpbmcgdGhlIGRldmxpbmtfcG9ydCBy YXRlIEFQSSBhcyBhIGJhc2lzIHRvIHJlcGxhY2UKbmRvX3NldF90eF9tYXhyYXRlKCkgKHZpYSBk ZXYtPmRldmxpbmtfcG9ydC0+ZGV2bGluay0+KSBhbmQgcG9zc2libHkKbmRvX3NldF92Zl9yYXRl KCkuIE5vdGUgdGhlIGdpdmVuIHRoZSBwcmV2aW91cyBwb2ludCwgdGhpcyBvcHRpb24gd291bGQK c3RpbGwgZmVlbCBwcm9ibGVtYXRpYy4KCkNoZWVycywKClBhb2xvCgpbMV0gaHR0cHM6Ly94a2Nk LmNvbS85MjcvClsyXSBodHRwczovL3d3dy55b3V0dWJlLmNvbS93YXRjaD92PWY4a09fTC1wRHdv CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC13 aXJlZC1sYW4gbWFpbGluZyBsaXN0CkludGVsLXdpcmVkLWxhbkBvc3Vvc2wub3JnCmh0dHBzOi8v bGlzdHMub3N1b3NsLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLXdpcmVkLWxhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 248AB1C28F for ; Fri, 15 Dec 2023 11:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d9l314U9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702638421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+SBrpdDFNUNV9rPT9NLwnq0LGAxyDiW4IAOIo/k6GdI=; b=d9l314U9R3CIClmwWSBpsbeIW3OA6+YWunDiJLeiHn/n2AR59D7080W+d50KyrK4yYRkSw scKBOmz6l5LB9QzWTofH4G7xTECnBTX0Twc4TYCW0Zdk6rPqGi5Hcfk1oNlrDbhDiyX8/b vf1aBbpYe7l1F0oD8+kTUtMbTAK17do= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-2qIOFF6xNhCoSsapn7XPLg-1; Fri, 15 Dec 2023 06:06:58 -0500 X-MC-Unique: 2qIOFF6xNhCoSsapn7XPLg-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a1d3a7dbb81so12430266b.0 for ; Fri, 15 Dec 2023 03:06:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702638417; x=1703243217; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+SBrpdDFNUNV9rPT9NLwnq0LGAxyDiW4IAOIo/k6GdI=; b=FS8Zn2SbrbE8mDvDtgWSAj/fwija7a37zuBVc3hdoJchOHQX/yjcBLBWIMtBTaVuq4 id1hfn0Vq/v/CsiOJmQ8hIBsmDcvr/Y53NpHRxxleZsDOGFhjpstzvKPKHIFMliFg072 9sQVRDIMRz96ZUGNm23mOL9vuQq5ZEBuL47vWEjhLvwqyRoJY7L/qaHIt5cLHliJHdbk 8oIihXPc8T+D5Zz8s8dMPJGF2fuWbpzt65trp32E4GVay6vOMWHsJG3kivxH3GbXJupN qWbbTlErAE0K0KfIQj2kgM7sj2QSnQ6k9Z+dpn10549IpoVowY0W1IPNzY+SnZzIZAlf 9rLw== X-Gm-Message-State: AOJu0Yykkhky/2GJ5/h29EjUlOPz5qz6NGyr/xYXN9AI2BW/8a5YFjsH fr64Cyy8s7mGHcKa2yZg3DBLUkDkoAh5ZOgNk5B24YjJWL7I/aN76zFO7/xVZazMnPqZo3qwbSo QE9YNLegtuCBGHcEW X-Received: by 2002:a17:907:c312:b0:a01:ae7b:d19b with SMTP id tl18-20020a170907c31200b00a01ae7bd19bmr13400113ejc.7.1702638416821; Fri, 15 Dec 2023 03:06:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqpkcw+CXAIe9OcjU9a+jALwDiPC7w1Lq9B7//FnjoXl2yypFOCqn4E0ZWOM64gx9WBsXmQw== X-Received: by 2002:a17:907:c312:b0:a01:ae7b:d19b with SMTP id tl18-20020a170907c31200b00a01ae7bd19bmr13400093ejc.7.1702638416441; Fri, 15 Dec 2023 03:06:56 -0800 (PST) Received: from gerbillo.redhat.com (146-241-255-162.dyn.eolo.it. [146.241.255.162]) by smtp.gmail.com with ESMTPSA id st10-20020a170907c08a00b00a1cd0794696sm10590739ejc.53.2023.12.15.03.06.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 03:06:55 -0800 (PST) Message-ID: <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' From: Paolo Abeni To: Jakub Kicinski , Jiri Pirko Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, qi.z.zhang@intel.com, Wenjun Wu , maxtram95@gmail.com, "Chittim, Madhu" , "Samudrala, Sridhar" , Simon Horman Date: Fri, 15 Dec 2023 12:06:52 +0100 In-Reply-To: <20231214174604.1ca4c30d@kernel.org> References: <20230727021021.961119-1-wenjun1.wu@intel.com> <20230822034003.31628-1-wenjun1.wu@intel.com> <20230822081255.7a36fa4d@kernel.org> <0893327b-1c84-7c25-d10c-1cc93595825a@intel.com> <5aed9b87-28f8-f0b0-67c4-346e1d8f762c@intel.com> <20231118084843.70c344d9@kernel.org> <3d60fabf-7edf-47a2-9b95-29b0d9b9e236@intel.com> <20231122192201.245a0797@kernel.org> <20231127174329.6dffea07@kernel.org> <55e51b97c29894ebe61184ab94f7e3d8486e083a.camel@redhat.com> <20231214174604.1ca4c30d@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2023-12-14 at 17:46 -0800, Jakub Kicinski wrote: > On Thu, 14 Dec 2023 21:29:51 +0100 Paolo Abeni wrote: > > Together with Simon, I spent some time on the above. We think the > > ndo_setup_tc(TC_SETUP_QDISC_TBF) hook could be used as common basis for > > this offloads, with some small extensions (adding a 'max_rate' param, > > too). >=20 > uAPI aside, why would we use ndo_setup_tc(TC_SETUP_QDISC_TBF) > to implement common basis? >=20 > Is it not cleaner to have a separate driver API, with its ops > and capabilities? We understand one of the end goal is consolidating the existing rate- related in kernel interfaces. Adding a new one does not feel a good starting to reach that goal, see [1] & [2] ;). ndo_setup_tc() feels like the natural choice for H/W offload and TBF is the existing interface IMHO nearest to the requirements here. The devlink rate API could be a possible alternative... > > The idea would be: > > - 'fixing' sch_btf so that the s/w path became a no-op when h/w offload > > is enabled > > - extend sch_btf to support max rate > > - do the relevant ice implementation > > - ndo_set_tx_maxrate could be replaced with the mentioned ndo call (the > > latter interface is a strict super-set of former) > > - ndo_set_vf_rate could also be replaced with the mentioned ndo call > > (with another small extension to the offload data) > >=20 > > I think mqprio deserves it's own separate offload interface, as it > > covers multiple tasks other than shaping (grouping queues and mapping > > priority to classes) > >=20 > > In the long run we could have a generic implementation of the > > ndo_setup_tc(TC_SETUP_QDISC_TBF) in term of devlink rate adding a > > generic way to fetch the devlink_port instance corresponding to the > > given netdev and mapping the TBF features to the devlink_rate API. > >=20 > > Not starting this due to what Jiri mentioned [1]. >=20 > Jiri, AFAIU, is against using devlink rate *uAPI* to configure network > rate limiting. That's separate from the internal representation. ... with a couples of caveats: 1) AFAICS devlink (and/or devlink_port) does not have fine grained, per queue representation and intel want to be able to configure shaping on per queue basis. I think/hope we don't want to bring the discussion to extending the devlink interface with queue support, I fear that will block us for a long time. Perhaps I=E2=80=99m missing or misunderstanding something here. Otherwise in retrospect this looks like a reasonable point to completely avoid devlink here. 2) My understanding of Jiri statement was more restrictive. @Jiri it would great if could share your genuine interpretation: are you ok with using the devlink_port rate API as a basis to replace ndo_set_tx_maxrate() (via dev->devlink_port->devlink->) and possibly ndo_set_vf_rate(). Note the given the previous point, this option would still feel problematic. Cheers, Paolo [1] https://xkcd.com/927/ [2] https://www.youtube.com/watch?v=3Df8kO_L-pDwo