All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Jan Kara <jack@suse.cz>,
	Joanne Koong <joannelkoong@gmail.com>,
	linux-mm@kvack.org, athul.krishna.kr@protonmail.com,
	j.neuschaefer@gmx.net, carnil@debian.org,
	linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()
Date: Mon, 19 Jan 2026 10:44:08 +0100	[thread overview]
Message-ID: <7b21ef98-e9f3-4e09-97ab-cf1ee9def41f@kernel.org> (raw)
In-Reply-To: <20260118164051.521de8ad2758376c3e1d2d81@linux-foundation.org>

On 1/19/26 01:40, Andrew Morton wrote:
> On Tue, 6 Jan 2026 18:54:47 +0100 "David Hildenbrand (Red Hat)" <david@kernel.org> wrote:
> 
>> On 1/6/26 17:05, Miklos Szeredi wrote:
>>> On Tue, 6 Jan 2026 at 16:41, David Hildenbrand (Red Hat)
>>> <david@kernel.org> wrote:
>>>
>>>> I assume the usual suspects, including mm/memory-failure.c.
>>>>
>>>> memory_failure() not only contains a folio_wait_writeback() but also a
>>>> folio_lock(), so twice the fun :)
>>>
>>> As long as it's run from a workqueue it shouldn't affect the rest of
>>> the system, right?  The wq thread will consume a nontrivial amount of
>>> resources, I suppose, so it would be better to implement those waits
>>> asynchronously.
>>
>> Good question. I know that memory_failure() can be triggered out of
>> various context, but I never traced it back to its origin.
> 
> I'm seeing unhappy okays from David and Jan, so I'll upstream this
> patch later in the week, unless someone stops me.

Just to clarify, I'm happy with this patch as is. The semantics make 
perfect sense.

-- 
Cheers

David


  reply	other threads:[~2026-01-19  9:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15  3:00 [PATCH v2 0/1] fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes() Joanne Koong
2025-12-15  3:00 ` [PATCH v2 1/1] " Joanne Koong
2025-12-15 17:09   ` Bernd Schubert
2025-12-16  7:07     ` Joanne Koong
2025-12-16 18:13   ` J. Neuschäfer
2026-01-02 17:42   ` Joanne Koong
2026-01-03 18:03   ` Andrew Morton
2026-01-04 18:54     ` David Hildenbrand (Red Hat)
2026-01-05 19:55       ` Joanne Koong
2026-01-06  9:33   ` Jan Kara
2026-01-06 10:05     ` David Hildenbrand (Red Hat)
2026-01-06 13:13       ` Miklos Szeredi
2026-01-06 13:55         ` Jan Kara
2026-01-06 14:33         ` David Hildenbrand (Red Hat)
2026-01-06 15:21           ` Miklos Szeredi
2026-01-06 15:41             ` David Hildenbrand (Red Hat)
2026-01-06 16:05               ` Miklos Szeredi
2026-01-06 17:54                 ` David Hildenbrand (Red Hat)
2026-01-19  0:40                   ` Andrew Morton
2026-01-19  9:44                     ` David Hildenbrand (Red Hat) [this message]
2026-01-06 23:30     ` Joanne Koong
2026-01-07 10:12       ` Jan Kara
2026-01-07 23:20         ` Joanne Koong
2026-01-08 10:36           ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b21ef98-e9f3-4e09-97ab-cf1ee9def41f@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=athul.krishna.kr@protonmail.com \
    --cc=carnil@debian.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=jack@suse.cz \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.