From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F16C2BB55 for ; Thu, 9 Apr 2020 19:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 413BF20679 for ; Thu, 9 Apr 2020 19:00:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HzZx14fO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgDITAS (ORCPT ); Thu, 9 Apr 2020 15:00:18 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:40926 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbgDITAS (ORCPT ); Thu, 9 Apr 2020 15:00:18 -0400 Received: by mail-lf1-f67.google.com with SMTP id j17so468593lfe.7; Thu, 09 Apr 2020 12:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xSPvBLVxXTk7r4uWb9GSydHFAj4ViQiiOpEJD7YvZqM=; b=HzZx14fOthqThXVovSEdzT9xxI/iYxCiakr7ChDEkTRBPbeg+0FtTsefFhjKcZbYso 08oR6Rv5DR5KJG/uJO42ACFWlWAw+D2taHz/o03ai1SgRLwNOQ0Apvc+nzMplJ1rU8RN aHctEtXnwIhH5KRdLzylxrGAWrtuDctU8dbyJUhk9kw3NVGwzUw+Uz49grdCQrKslpTY 7bszUiajBg2cvJ7mkFzAP0Um88WcRGkZkzvRehzuEp6oySTCZohqWJhvM1xQde/ihFmP h5a9SWQ051tA/0yCGkjSvy4KTySxs0VMcf6/RWSAgk6pGbaomPF3JgFIac5bW6UOhoIR aacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xSPvBLVxXTk7r4uWb9GSydHFAj4ViQiiOpEJD7YvZqM=; b=mFYJDSF2GuWZIVg8pXQiCZaloBS7QPjcfhVQXnoMrlMxDphWiRVtgZ9guevFd1ulM3 h2C253MiltL5VDwwdFxrufq/yAviljFXDOWhVVW33jKd2Dm2qqzZcNqnDNwvnPkQQUby qOoqvV/xq6ipkrWatbrNXmFied4erUNS0/Wr0oM+tCLzlh9SMV/X1mU+dc205KCAYb2y xus4ODYbfnvR1MMA3em39TKvHU1/uImJPmX46Cx2uKIwsr/VY5fK97HexdJONOQHzK2V dzSURLv/iWZHK9CoVQqjvfrThUdA4HuhYOs/IhegkdqqWlBqhlBeUD1DwvDTyxNE7kMZ 0cqA== X-Gm-Message-State: AGi0PuYVFMSAOZvDJORIMOeoz6+G6JLZsvnCRm7Zf+rVzrfvTQ45HoXw 3hzooyKWTk1FhSvQ+C/oc+4= X-Google-Smtp-Source: APiQypIO0LHOpLrwPbAk/A6S3Mr6+az19yessXD75VrxMB9u640PipFFtRLBWK2axQvYqRJHAuHoVw== X-Received: by 2002:ac2:4c21:: with SMTP id u1mr394852lfq.99.1586458814856; Thu, 09 Apr 2020 12:00:14 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id e12sm20086369ljl.36.2020.04.09.12.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 12:00:14 -0700 (PDT) Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <7b2f8a7c-94f1-08d0-b0ce-c61f4eb0a436@gmail.com> Date: Thu, 9 Apr 2020 22:00:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-10-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > +static void tegra210_emc_debugfs_init(struct tegra210_emc *emc) > +{ > + struct device *dev = emc->dev; > + unsigned int i; > + int err; > + > + emc->debugfs.min_rate = ULONG_MAX; > + emc->debugfs.max_rate = 0; > + > + for (i = 0; i < emc->num_timings; i++) { > + if (emc->timings[i].rate * 1000UL < emc->debugfs.min_rate) > + emc->debugfs.min_rate = emc->timings[i].rate * 1000UL; > + > + if (emc->timings[i].rate * 1000UL > emc->debugfs.max_rate) > + emc->debugfs.max_rate = emc->timings[i].rate * 1000UL; > + } > + > + if (!emc->num_timings) { > + emc->debugfs.min_rate = clk_get_rate(emc->clk); > + emc->debugfs.max_rate = emc->debugfs.min_rate; > + } > + > + err = clk_set_rate_range(emc->clk, emc->debugfs.min_rate, > + emc->debugfs.max_rate); > + if (err < 0) { > + dev_err(dev, "failed to set rate range [%lu-%lu] for %pC\n", > + emc->debugfs.min_rate, emc->debugfs.max_rate, > + emc->clk); > + return; > + } > + > + emc->debugfs.root = debugfs_create_dir("emc", NULL); > + if (!emc->debugfs.root) { > + dev_err(dev, "failed to create debugfs directory\n"); > + return; > + } > + > + debugfs_create_file("available_rates", S_IRUGO, emc->debugfs.root, emc, > + &tegra210_emc_debug_available_rates_fops); > + debugfs_create_file("min_rate", S_IRUGO | S_IWUSR, emc->debugfs.root, > + emc, &tegra210_emc_debug_min_rate_fops); > + debugfs_create_file("max_rate", S_IRUGO | S_IWUSR, emc->debugfs.root, > + emc, &tegra210_emc_debug_max_rate_fops); I assume you used the checkpatch before sending the patches, no? I sent out a patch recently to make the permissions readable, please take a look if you haven't seen it yet. https://patchwork.ozlabs.org/patch/1254301/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8255C2BA19 for ; Thu, 9 Apr 2020 19:00:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EEA52087E for ; Thu, 9 Apr 2020 19:00:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GN0U9dPh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HzZx14fO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EEA52087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8x8HF9eJwn9BY2O7CS20DYz6w07OQzh0TUlHK7tY8CU=; b=GN0U9dPh5VHe77 mONh54Vw2ikihe+12wDpTVSjUeBn70KAot4vAcm4a9SS1/lvuvjBcpbdWfuK+re8iY0m78d/nyT5R 5Wga3rw8dzEZmLH5mSG2U7WVjBGSu+s+ff6XnnBqcO2pn6polctuHIdHMARYPj0g2lmyo7zXNIaCp eGtpcyEKr3dw9qSZKQlbjhCZMm7G3YghG/8a+4mXvpOTo4FDPrTPc6/dHFo2/MNMgGUsy8p+Zvves 7dd2Wcn5wowjWVlVY/ZiGalXpPByeGESviL4KhWMJH7Uistl9N5uEbw/xZHGFehNi7esnINIipLim ptHSQrBk5vuFVhKxC+3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMcPY-0001ER-7I; Thu, 09 Apr 2020 19:00:24 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMcPQ-0000rU-TS for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 19:00:18 +0000 Received: by mail-lf1-x142.google.com with SMTP id w145so486544lff.3 for ; Thu, 09 Apr 2020 12:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xSPvBLVxXTk7r4uWb9GSydHFAj4ViQiiOpEJD7YvZqM=; b=HzZx14fOthqThXVovSEdzT9xxI/iYxCiakr7ChDEkTRBPbeg+0FtTsefFhjKcZbYso 08oR6Rv5DR5KJG/uJO42ACFWlWAw+D2taHz/o03ai1SgRLwNOQ0Apvc+nzMplJ1rU8RN aHctEtXnwIhH5KRdLzylxrGAWrtuDctU8dbyJUhk9kw3NVGwzUw+Uz49grdCQrKslpTY 7bszUiajBg2cvJ7mkFzAP0Um88WcRGkZkzvRehzuEp6oySTCZohqWJhvM1xQde/ihFmP h5a9SWQ051tA/0yCGkjSvy4KTySxs0VMcf6/RWSAgk6pGbaomPF3JgFIac5bW6UOhoIR aacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xSPvBLVxXTk7r4uWb9GSydHFAj4ViQiiOpEJD7YvZqM=; b=eTKk0jryQeParlg5PuxZu4SkZpKEUdV/Xv6yg4+sBdmQGAOEVe+bVUdQYiihRBEhSU hK4JwiBZCbE0Z2G42MzDoWKa7vcomCLWij5G7CUwQnBJwJfl5qJP0ZEerHwgOOa0vVLR pqHhxKCcafUKckShoX2SQ516ZzkVRMICTAKXv3w8Wwvm7DTRjl5jhUXRfYHFG6f12zqz +4BX6fTxUYXkPoIMCiREr/3FfF7mYZZmsYTdlDe9xPsXdFoyzDJn7+gOQd0tTm5W2kqc IedE1+6FaE/31nSQNgbmpmfupMis5sHty+2j/VEzgncGzyuX322vnCoyG+wsyWlOF6gE T2+A== X-Gm-Message-State: AGi0PuYYTCIdpiE7HGsBppoCjuPi9qpX05rrDer/WhirOhwCvaBolY+f F5oVgDRJx84BtbLUnRm97mxuzBKp X-Google-Smtp-Source: APiQypIO0LHOpLrwPbAk/A6S3Mr6+az19yessXD75VrxMB9u640PipFFtRLBWK2axQvYqRJHAuHoVw== X-Received: by 2002:ac2:4c21:: with SMTP id u1mr394852lfq.99.1586458814856; Thu, 09 Apr 2020 12:00:14 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id e12sm20086369ljl.36.2020.04.09.12.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 12:00:14 -0700 (PDT) Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 To: Thierry Reding , Rob Herring References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <7b2f8a7c-94f1-08d0-b0ce-c61f4eb0a436@gmail.com> Date: Thu, 9 Apr 2020 22:00:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-10-thierry.reding@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_120017_079675_89840DC6 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDkuMDQuMjAyMCAyMDo1MiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4gK3N0YXRp YyB2b2lkIHRlZ3JhMjEwX2VtY19kZWJ1Z2ZzX2luaXQoc3RydWN0IHRlZ3JhMjEwX2VtYyAqZW1j KQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBlbWMtPmRldjsKPiArCXVuc2lnbmVkIGlu dCBpOwo+ICsJaW50IGVycjsKPiArCj4gKwllbWMtPmRlYnVnZnMubWluX3JhdGUgPSBVTE9OR19N QVg7Cj4gKwllbWMtPmRlYnVnZnMubWF4X3JhdGUgPSAwOwo+ICsKPiArCWZvciAoaSA9IDA7IGkg PCBlbWMtPm51bV90aW1pbmdzOyBpKyspIHsKPiArCQlpZiAoZW1jLT50aW1pbmdzW2ldLnJhdGUg KiAxMDAwVUwgPCBlbWMtPmRlYnVnZnMubWluX3JhdGUpCj4gKwkJCWVtYy0+ZGVidWdmcy5taW5f cmF0ZSA9IGVtYy0+dGltaW5nc1tpXS5yYXRlICogMTAwMFVMOwo+ICsKPiArCQlpZiAoZW1jLT50 aW1pbmdzW2ldLnJhdGUgKiAxMDAwVUwgPiBlbWMtPmRlYnVnZnMubWF4X3JhdGUpCj4gKwkJCWVt Yy0+ZGVidWdmcy5tYXhfcmF0ZSA9IGVtYy0+dGltaW5nc1tpXS5yYXRlICogMTAwMFVMOwo+ICsJ fQo+ICsKPiArCWlmICghZW1jLT5udW1fdGltaW5ncykgewo+ICsJCWVtYy0+ZGVidWdmcy5taW5f cmF0ZSA9IGNsa19nZXRfcmF0ZShlbWMtPmNsayk7Cj4gKwkJZW1jLT5kZWJ1Z2ZzLm1heF9yYXRl ID0gZW1jLT5kZWJ1Z2ZzLm1pbl9yYXRlOwo+ICsJfQo+ICsKPiArCWVyciA9IGNsa19zZXRfcmF0 ZV9yYW5nZShlbWMtPmNsaywgZW1jLT5kZWJ1Z2ZzLm1pbl9yYXRlLAo+ICsJCQkJIGVtYy0+ZGVi dWdmcy5tYXhfcmF0ZSk7Cj4gKwlpZiAoZXJyIDwgMCkgewo+ICsJCWRldl9lcnIoZGV2LCAiZmFp bGVkIHRvIHNldCByYXRlIHJhbmdlIFslbHUtJWx1XSBmb3IgJXBDXG4iLAo+ICsJCQllbWMtPmRl YnVnZnMubWluX3JhdGUsIGVtYy0+ZGVidWdmcy5tYXhfcmF0ZSwKPiArCQkJZW1jLT5jbGspOwo+ ICsJCXJldHVybjsKPiArCX0KPiArCj4gKwllbWMtPmRlYnVnZnMucm9vdCA9IGRlYnVnZnNfY3Jl YXRlX2RpcigiZW1jIiwgTlVMTCk7Cj4gKwlpZiAoIWVtYy0+ZGVidWdmcy5yb290KSB7Cj4gKwkJ ZGV2X2VycihkZXYsICJmYWlsZWQgdG8gY3JlYXRlIGRlYnVnZnMgZGlyZWN0b3J5XG4iKTsKPiAr CQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJZGVidWdmc19jcmVhdGVfZmlsZSgiYXZhaWxhYmxlX3Jh dGVzIiwgU19JUlVHTywgZW1jLT5kZWJ1Z2ZzLnJvb3QsIGVtYywKPiArCQkJICAgICZ0ZWdyYTIx MF9lbWNfZGVidWdfYXZhaWxhYmxlX3JhdGVzX2ZvcHMpOwo+ICsJZGVidWdmc19jcmVhdGVfZmls ZSgibWluX3JhdGUiLCBTX0lSVUdPIHwgU19JV1VTUiwgZW1jLT5kZWJ1Z2ZzLnJvb3QsCj4gKwkJ CSAgICBlbWMsICZ0ZWdyYTIxMF9lbWNfZGVidWdfbWluX3JhdGVfZm9wcyk7Cj4gKwlkZWJ1Z2Zz X2NyZWF0ZV9maWxlKCJtYXhfcmF0ZSIsIFNfSVJVR08gfCBTX0lXVVNSLCBlbWMtPmRlYnVnZnMu cm9vdCwKPiArCQkJICAgIGVtYywgJnRlZ3JhMjEwX2VtY19kZWJ1Z19tYXhfcmF0ZV9mb3BzKTsK CkkgYXNzdW1lIHlvdSB1c2VkIHRoZSBjaGVja3BhdGNoIGJlZm9yZSBzZW5kaW5nIHRoZSBwYXRj aGVzLCBubz8KCkkgc2VudCBvdXQgYSBwYXRjaCByZWNlbnRseSB0byBtYWtlIHRoZSBwZXJtaXNz aW9ucyByZWFkYWJsZSwgcGxlYXNlCnRha2UgYSBsb29rIGlmIHlvdSBoYXZlbid0IHNlZW4gaXQg eWV0LgoKaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC8xMjU0MzAxLwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=