From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E90C433E2 for ; Sat, 29 Aug 2020 00:12:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2095820838 for ; Sat, 29 Aug 2020 00:12:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="T0PTTM9e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2095820838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A99C318C2; Sat, 29 Aug 2020 02:12:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A99C318C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598659976; bh=iGeT3MSpUm0YvU4srxJW0ZPlUlckjmx6oZIiBQAaNbU=; h=From:Subject:To:References:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T0PTTM9e2OmhphV0kl+pFYeWyluCC+MlUcJcXaPcDIbsurZnXZCirPXKSmUtFW0WK HuVJtIvqcCrqfoyiXvqjCFgjN9ytdOmjlitDyeeVaMvpIzY7DRoN46z/RaKOAy7yoO zb9NGaaZ4mWOXk+5aRctoBiW76HbysQHk1q8rCXw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 162C2F80143; Sat, 29 Aug 2020 02:12:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0FAA5F8016F; Sat, 29 Aug 2020 02:12:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0536AF80105 for ; Sat, 29 Aug 2020 02:11:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0536AF80105 IronPort-SDR: ih+jyx23w7Ulh/QOdzVZa4U/vzk2leYkRNrXRWwExh45pMUX3NctfseOse62wvB+7FCgScsbq/ SOtQWbnisXvg== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="144440468" X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="144440468" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:54 -0700 IronPort-SDR: h4/orcg6Gn8nZ9ohrRYk+lZSm+43zkLVdgDI4N9Y2stHaHJZBEYbeRpB1m00xdjqKyRt5YQyWb VxfQI2pIm4Eg== X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="340050304" Received: from fvera1-mobl.amr.corp.intel.com (HELO [10.212.55.68]) ([10.212.55.68]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:52 -0700 From: Pierre-Louis Bossart Subject: Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Doug Anderson , Cheng-Yi Chiang References: <20200826110454.1811352-1-cychiang@chromium.org> <20200826110454.1811352-3-cychiang@chromium.org> Message-ID: <7b3bb666-c53e-e385-e153-1383f2831c2e@linux.intel.com> Date: Fri, 28 Aug 2020 19:11:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA Development Mailing List , Banajit Goswami , LKML , Rob Herring , Stephan Gerhold , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , tzungbi@chromium.org, Ajit Pandey , Tzung-Bi Shih , Andy Gross , Rohit kumar , Mark Brown , Srini Kandagatla , Dylan Reid , Bjorn Andersson , Linux ARM X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> +config SND_SOC_SC7180 >> + tristate "SoC Machine driver for SC7180 boards" >> + depends on SND_SOC_QCOM this depends is probably not necessary, the code is already in an if case. >> + select SND_SOC_QCOM_COMMON >> + select SND_SOC_LPASS_SC7180 >> + select SND_SOC_MAX98357A >> + select SND_SOC_RT5682 > > I haven't done any significant testing / review of your patch (I'm > mostly sound-clueless), but I believe that the above needs to be > "select SND_SOC_RT5682_I2C" atop the current top of the sound tree. > When I fix that I can confirm that I see the rt5682 probe on > sc7180-trogdor with Rob Clark's dts patch. Ack, no one should select SND_SOC_RT5682 directly in machine drivers. now that the code is split between I2C and SoundWire parts. There should probably be a depends on I2C as well? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7A7C433E6 for ; Sat, 29 Aug 2020 00:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6EE4207DA for ; Sat, 29 Aug 2020 00:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbgH2AM5 (ORCPT ); Fri, 28 Aug 2020 20:12:57 -0400 Received: from mga18.intel.com ([134.134.136.126]:24037 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbgH2AM4 (ORCPT ); Fri, 28 Aug 2020 20:12:56 -0400 IronPort-SDR: SlUZ12gOD/aVhSZ9C7qk9jQyBgNINfY/t+G1287Q5kZkl6/uIqYjnG+u+HmCtHBrJfbDAh32H1 RsPfmveC3cqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="144440466" X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="144440466" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:54 -0700 IronPort-SDR: h4/orcg6Gn8nZ9ohrRYk+lZSm+43zkLVdgDI4N9Y2stHaHJZBEYbeRpB1m00xdjqKyRt5YQyWb VxfQI2pIm4Eg== X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="340050304" Received: from fvera1-mobl.amr.corp.intel.com (HELO [10.212.55.68]) ([10.212.55.68]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:52 -0700 From: Pierre-Louis Bossart Subject: Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Doug Anderson , Cheng-Yi Chiang Cc: Taniya Das , ALSA Development Mailing List , Banajit Goswami , Takashi Iwai , Rohit kumar , Patrick Lai , Ajit Pandey , Tzung-Bi Shih , Andy Gross , Dylan Reid , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , tzungbi@chromium.org, Stephan Gerhold , linux-arm-msm , Rob Herring , Bjorn Andersson , Linux ARM , Liam Girdwood , LKML , Mark Brown , Srini Kandagatla References: <20200826110454.1811352-1-cychiang@chromium.org> <20200826110454.1811352-3-cychiang@chromium.org> Message-ID: <7b3bb666-c53e-e385-e153-1383f2831c2e@linux.intel.com> Date: Fri, 28 Aug 2020 19:11:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org >> +config SND_SOC_SC7180 >> + tristate "SoC Machine driver for SC7180 boards" >> + depends on SND_SOC_QCOM this depends is probably not necessary, the code is already in an if case. >> + select SND_SOC_QCOM_COMMON >> + select SND_SOC_LPASS_SC7180 >> + select SND_SOC_MAX98357A >> + select SND_SOC_RT5682 > > I haven't done any significant testing / review of your patch (I'm > mostly sound-clueless), but I believe that the above needs to be > "select SND_SOC_RT5682_I2C" atop the current top of the sound tree. > When I fix that I can confirm that I see the rt5682 probe on > sc7180-trogdor with Rob Clark's dts patch. Ack, no one should select SND_SOC_RT5682 directly in machine drivers. now that the code is split between I2C and SoundWire parts. There should probably be a depends on I2C as well? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E7DC433E2 for ; Sat, 29 Aug 2020 00:13:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3105A207DA for ; Sat, 29 Aug 2020 00:13:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cnic5Zn/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3105A207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1YQxsTBjQkHNuDecTUIoswXl8TL5jzuJQau5/64/Hec=; b=Cnic5Zn/ojDPVum4mh2RzmOS5 cEsmJEKs0huhaS/PWgZ3YEEfW8XSWQ0eMqetZFnNt/7abBaXW6ST/88WiQ85bxK/+h5PEaKuYX4Ur 5h1sBWR/zOtPfDpdQKMiy2NM4Dg23WezxGbWroHKrOqTnHo9Spu8mUh9L4b/Gl78EjhowKu+AI1n6 zORUpwD7iWmMWnI/VoSO0/Wxx8idQro3eEe0uk6+0EAX70hT3hJ1X/tiAlj1v/x3yN9dX2seCegqK 0A20vGSaePc+edPMzoSVAIlUWJegTFaxVnPHZxWEEO5B2HNlUfTzqqUYVcEZuC0qFb23EO3zgriPs Wzark0RMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBoTP-00029s-PH; Sat, 29 Aug 2020 00:11:59 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBoTM-00028J-T0 for linux-arm-kernel@lists.infradead.org; Sat, 29 Aug 2020 00:11:57 +0000 IronPort-SDR: Xgp9Ub3rloNVwNA5HLHM8js0CV/HUc5MkMHB+4/xJLUzu0z8EfvzNOEDtZVwfZASjpSlqs3mtZ cFt8mtbrJ8tw== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="174810336" X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="174810336" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:55 -0700 IronPort-SDR: h4/orcg6Gn8nZ9ohrRYk+lZSm+43zkLVdgDI4N9Y2stHaHJZBEYbeRpB1m00xdjqKyRt5YQyWb VxfQI2pIm4Eg== X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="340050304" Received: from fvera1-mobl.amr.corp.intel.com (HELO [10.212.55.68]) ([10.212.55.68]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 17:11:52 -0700 From: Pierre-Louis Bossart Subject: Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Doug Anderson , Cheng-Yi Chiang References: <20200826110454.1811352-1-cychiang@chromium.org> <20200826110454.1811352-3-cychiang@chromium.org> Message-ID: <7b3bb666-c53e-e385-e153-1383f2831c2e@linux.intel.com> Date: Fri, 28 Aug 2020 19:11:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_201157_104786_2B07BB79 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA Development Mailing List , Banajit Goswami , LKML , Rob Herring , Stephan Gerhold , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , tzungbi@chromium.org, Ajit Pandey , Tzung-Bi Shih , Andy Gross , Rohit kumar , Mark Brown , Srini Kandagatla , Dylan Reid , Bjorn Andersson , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> +config SND_SOC_SC7180 >> + tristate "SoC Machine driver for SC7180 boards" >> + depends on SND_SOC_QCOM this depends is probably not necessary, the code is already in an if case. >> + select SND_SOC_QCOM_COMMON >> + select SND_SOC_LPASS_SC7180 >> + select SND_SOC_MAX98357A >> + select SND_SOC_RT5682 > > I haven't done any significant testing / review of your patch (I'm > mostly sound-clueless), but I believe that the above needs to be > "select SND_SOC_RT5682_I2C" atop the current top of the sound tree. > When I fix that I can confirm that I see the rt5682 probe on > sc7180-trogdor with Rob Clark's dts patch. Ack, no one should select SND_SOC_RT5682 directly in machine drivers. now that the code is split between I2C and SoundWire parts. There should probably be a depends on I2C as well? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel