From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62CA3101B9 for ; Thu, 11 Sep 2025 10:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757586540; cv=none; b=K51Ek1Ysr3YCOB6dJT7E8qOZLADIExXMS96uO21l5m9JhfhOVI/pZOEUIqk+UNij+zneVIWHMVMmTXuELtaCviAdmiCsvYiUdrVrIzMBWwRvuWhM5gCv/Cul6oIpTZKnlgFTQCnTKVam4LOLEuA8Vo8VP44YCYJss/hQs6VH36w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757586540; c=relaxed/simple; bh=b1uC8Gnbw2d8hCGsPGSpLi4OmOxfJufpgp9Mcq3XYG0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=PiDIe67Sfao6rlb+H2itgY3UpeVytpmVgLAQFZxAjjTNnGA03XT7QPCBb4ZCQBkBH0zoAMKv9nG1b937LoLpkBl3LB9fLwovhqEgcIK5mwMER5oTpCPuCEziL6n9feFNgnTU7MmixUcqS7QBvgVPI4rBp2EOeGpV4i+0yCz6lQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PeUD/WK+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PeUD/WK+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B66DC4CEF1; Thu, 11 Sep 2025 10:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757586540; bh=b1uC8Gnbw2d8hCGsPGSpLi4OmOxfJufpgp9Mcq3XYG0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=PeUD/WK+/IZXpUtq9moidJq4YJZkCnMQf9KLNjQSggtTc/QKgLeW0WXaLFzuJ5nzi jBQWZux7PUyyFiHNuevKPBiMO1wFgIJW/4SYnpUPsxdHjtcVccS/stbxq2GYt7g+qc k/uwMFLQXvGP9fcDYKT7qecQyNkWaIzVA7FkCyLGROnGTlLKatIoZAGkHIuFUOPfMA h03t+Ys8BIErtt+XpO2oCCQYlZrUpkK2PUmKaqbU+sl/V4fDR5F3e4yrpaP6PBz7Bu iNnvfszCjsJJxxryX1V62LyD/AhYC1/iFlkK6ukstKW0AqxDDoFkyT/umNmzVvUBCm njwqWECIywZxA== Message-ID: <7b3db008-5813-408f-8f95-e59719def2f3@kernel.org> Date: Thu, 11 Sep 2025 12:28:57 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next 4/4] selftests: mptcp: pm: get server-side flag Content-Language: en-GB, fr-BE To: Geliang Tang , MPTCP Upstream References: <20250909-mptcp-pm-user-server-side-flag-v1-0-cb8e2b8d1c0c@kernel.org> <20250909-mptcp-pm-user-server-side-flag-v1-4-cb8e2b8d1c0c@kernel.org> <20639f7f4b2616afaa4c4e511a13aa8ad49c8d90.camel@kernel.org> <1f62d970-631e-4031-a386-2b1db50642fb@kernel.org> <0cbcf551-9839-436c-93bb-d7275a12a1a5@kernel.org> <51c4f038acf4a596bc9c90c32c9ab6dd74312b00.camel@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <51c4f038acf4a596bc9c90c32c9ab6dd74312b00.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Geliang, On 11/09/2025 12:05, Geliang Tang wrote: > On Thu, 2025-09-11 at 11:35 +0200, Matthieu Baerts wrote: >> Hi Geliang, >> >> On 11/09/2025 11:04, Geliang Tang wrote: >>> Hi Matt, >>> >>> On Thu, 2025-09-11 at 10:35 +0200, Matthieu Baerts wrote: >>>> Hi Geliang, >>>> >>>> On 11/09/2025 10:16, Geliang Tang wrote: >>>>> Hi Matt, >>>>> >>>>> On Tue, 2025-09-09 at 18:30 +0200, Matthieu Baerts (NGI0) >>>>> wrote: >>>>>> server-side info linked to the MPTCP connect/established >>>>>> events >>>>>> can >>>>>> now >>>>>> come from the flags, in addition to the dedicated attribute. >>>>>> >>>>>> The attribute is now deprecated -- in favour of the new flag, >>>>>> and >>>>>> will >>>>>> be removed later on. >>>>>> >>>>>> Print this info only once. >>>>>> >>>>>> Signed-off-by: Matthieu Baerts (NGI0) >>>>>> --- >>>>>>  tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 9 ++++++++- >>>>>>  1 file changed, 8 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c >>>>>> b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c >>>>>> index >>>>>> 93fea3442216c8fef43731a99c1d5710f234b150..d4981b76693bbddca74 >>>>>> 1694 >>>>>> 37a5 >>>>>> 40ad6294cf1d5 100644 >>>>>> --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c >>>>>> +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c >>>>>> @@ -2,6 +2,7 @@ >>>>>>   >>>>>>  #include >>>>>>  #include >>>>>> +#include >>>>>>  #include >>>>>>  #include >>>>>>  #include >>>>>> @@ -113,6 +114,8 @@ static int capture_events(int fd, int >>>>>> event_group) >>>>>>   error(1, errno, "could not join the " >>>>>> MPTCP_PM_EV_GRP_NAME " mcast group"); >>>>>>   >>>>>>   do { >>>>>> + bool server_side = false; >>>>>> + >>>>>>   FD_ZERO(&rfds); >>>>>>   FD_SET(fd, &rfds); >>>>>>   res_len = NLMSG_ALIGN(sizeof(struct >>>>>> nlmsghdr)) + >>>>>> @@ -187,18 +190,22 @@ static int capture_events(int fd, int >>>>>> event_group) >>>>>>   else if (attrs->rta_type == >>>>>> MPTCP_ATTR_ERROR) >>>>>>   fprintf(stderr, >>>>>> ",error:%u", >>>>>> *(__u8 *)RTA_DATA(attrs)); >>>>>>   else if (attrs->rta_type == >>>>>> MPTCP_ATTR_SERVER_SIDE) >>>>>> - fprintf(stderr, >>>>>> ",server_side:%u", *(__u8 *)RTA_DATA(attrs)); >>>>> >>>>> It is a little strange that server_side is displayed at the >>>>> end. It >>>>> changes the original display order.  It is better to display it >>>>> in >>>>> the >>>>> original position, but check whether the server_side flag is >>>>> false: >>>> >>>> I'm not sure to understand why it is strange: the output is read >>>> by >>>> scripts, the order should not matter, right? >>> >>> I mean the original display order of "./pm_nl_ctl events" is: >>> >>> type:1,token:2327950928,server_side:1,family:10,saddr6:::ffff:10.0. >>> 1.1, >>> daddr6:::ffff:10.0.1.2,sport:10000,dport:40004,loc_id:0,rem_id:0 >>> >>> With this patch, the order is changed: >>> >>> type:1,token:1072969578,family:10,saddr6:::ffff:10.0.1.1,daddr6:::f >>> fff: >>> 10.0.1.2,sport:10000,dport:42484,loc_id:0,rem_id:0,server_side:1 >>> >>> If an application still uses code like this to parse server_side, >>> an >>> error will occur. >>> >>> sscanf(str, "type:%u,token:%u,server_side:%u", >>>        &type, &token, &server_side); >>> >>> So it makes sense to keep the original order. But up to you. >> >> I hope no applications are doing that: this pm_nl_ctl tool lists the > > I do use this in BPF path manager selftests under development. Probably best to avoid that. Can you not split based on ',' (strtok*()) and take the values for the keys you are interested in? >> arguments in the order it receives it, but this order is set by the >> kernel and can change. In other words, this order is not fixed in >> stone. >> >> Plus this tool is for the selftests, I don't think other people are >> using it. 'ip mptcp' is probably used instead. And even they should >> not >> expect the order to be fixed. >> >> So I don't think we need to increase the complexity here if it is not >> needed. > > Sure. I have no comments then. Please add my tag for this set: > > Reviewed-by: Geliang Tang Thanks! (Please next time send this as a reply to the cover-letter, so the tag will be automatically propagated to each patch.) Now in our tree (feat. for net-next): New patches for t/upstream: - 419c5f213113: mptcp: pm: netlink: only add server-side attr when true - 7a32b2ee28a7: mptcp: pm: netlink: announce server-side flag - ed9ca7fac132: mptcp: pm: netlink: deprecate server-side attribute - 65cb7a9d4d5e: selftests: mptcp: pm: get server-side flag - Results: 9d5b2844a3ca..7b11ba96fa1d (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/d1dac2258ca371e5cfcd46487e28590da3162f9b/checks Cheers, Matt -- Sponsored by the NGI0 Core fund.