From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF532C77B73 for ; Mon, 5 Jun 2023 11:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6S1WA0dR4XCG8L0m0Vxp+w/T0WdedCmDKtxggoYK+C0=; b=jsCO+PIT8cs4NM joymnNtwx7nrgxkcjWi/6kPq7/oKr+LbyzTq6xeMJ5Iuo0++nAUadjmSqo0VX9onAfZYFzCVR6gBM +pxW8B1DGctuR6h+ntkDwY8kfL+PSzO2aBPwTzEHOJ3ImmZ3wk666XgdIVEDYI4Kw5f/4AbygeRIH 4UP5QiaofO4l1Fc6RYIII/gEpOSlwYtdWasSWJFhW3DeP90YTUIu24YP27OIEuoKg6RmjHlv68AS6 8r9VxHLgew+8WfjuRDQ0R76n7j6MeIk1LWXx02yoxzkfYuCxwaTr2aLLWuLtrTBro1Kb1M8yfU+zG PLJPS8TrgE3oV94iEpLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q68FY-00FGJk-2P; Mon, 05 Jun 2023 11:19:48 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q68FU-00FGIG-2m for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 11:19:46 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f5021faa16so5842693e87.2 for ; Mon, 05 Jun 2023 04:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685963982; x=1688555982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gmCHyHNSkjzU7AeM7yN45tWKNNye8v8VFhaj+USDU5o=; b=MBFSRoIKFCrvOMRVVFnJJb2K9ocu521ToRzTXzvI62o+0LPcXNAks0dU/IdUVrsMAV /fACbPvmw4QpwcJXavJqZS66vs1pYLlNuWcZBOs0K+dZwNNGgx0ya4BqcjoRYen1jI0X nVgKhD0sxC5eVDdvtmYDlCzbBfqFnr+NWhq+rol4yIE3Tna3JhCUr+qfp2iklswfmzA9 d1fRrw2+xnNzbwf3wZE0QHkb4AMJHPFxbSc8jSirie/1lvTTrDQX65yA5VP14cdJ7sOu TBqcN6YZZcZh4B9OWyQp7AiuOY0zbYkGhuezIDG6VIckSmY6tjCbdcFQIQX/8fkJf+NM 5rBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685963982; x=1688555982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gmCHyHNSkjzU7AeM7yN45tWKNNye8v8VFhaj+USDU5o=; b=hcFltrQvVIFUFdnrgixonsWcyx1q4kdIbxykoUsNd3SXvapURIVLzjIVtMWGJsTsXd 6xaZ58CuKSAVg4PawE/wdn6Y+t10dqvKPLbNC7stVHJkljzrnCkwate7gr5ERFObygHB lpkmbhIhux7MVZoWVNh3bJ7zmuBiPJ8O/FdHPr21QGljl0w/Pihz0zBnyXJi5vWUvGIN Krky7Qg3+3mLNqamKbD7pncxljiYxvAScBD4U/EK8Z+jdiyXo3nhjNGyFMseNk8BBobB wEBTkVJ9xsIhEqKeaLUxWz08r9jw1mN429plgBqRl2RW9as5jTed2C4aJ565pDjhRQtc JJOQ== X-Gm-Message-State: AC+VfDy1/OjFp7dzrueIuVLk2d1oDIe5gPXb9LUDVUSDZa0TYQH/XJJw fnw7gtenQrO16yW8gZlpgAs= X-Google-Smtp-Source: ACHHUZ67DucgVxScjuPHm3wgYW3tC8Ib6c/jifYVPlycpRIzXAmoBPppCARqsiRitqote6GovkSkbQ== X-Received: by 2002:ac2:599d:0:b0:4f3:8f3a:f98d with SMTP id w29-20020ac2599d000000b004f38f3af98dmr5312606lfn.45.1685963982153; Mon, 05 Jun 2023 04:19:42 -0700 (PDT) Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id c26-20020ac244ba000000b004f26f437ad8sm1095319lfm.53.2023.06.05.04.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 04:19:41 -0700 (PDT) Message-ID: <7b63ceb0-5e27-8a12-fa25-8fdccad4f5aa@gmail.com> Date: Mon, 5 Jun 2023 13:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/3] ARM: MR26: MR32: remove bogus nand-ecc-algo property Content-Language: en-US To: Christian Lamparter , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Florian Fainelli , Hauke Mehrtens , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <869354dba00f01d4e6bde897a44180ad1658389c.1685801691.git.chunkeey@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <869354dba00f01d4e6bde897a44180ad1658389c.1685801691.git.chunkeey@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_041944_925951_C836D82E X-CRM114-Status: GOOD ( 30.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy4wNi4yMDIzIDE2OjE2LCBDaHJpc3RpYW4gTGFtcGFydGVyIHdyb3RlOgo+IHwgYmNtNTMw MTUtbWVyYWtpLW1yMjYuZHRiOiBuYW5kLWNvbnRyb2xsZXJAMTgwMjgwMDA6Cj4gfCAgIG5hbmRA MDpuYW5kLWVjYy1hbGdvOjA6ICdodycgaXMgbm90IG9uZSBvZiBbJ2hhbW1pbmcnLCAnYmNoJywg J3JzJ10KPiB8IEZyb20gc2NoZW1hOiBEb2N1bWVudGF0aW9uL1suLi5dL25hbmQtY29udHJvbGxl ci55YW1sCj4gfCBiY201MzAxNi1tZXJha2ktbXIzMi5kdGI6IG5hbmQtY29udHJvbGxlckAxODAy ODAwMDoKPiB8ICAgbmFuZEAwOm5hbmQtZWNjLWFsZ286MDogJ2h3JyBpcyBub3Qgb25lIG9mIFsn aGFtbWluZycsICdiY2gnLCAncnMnXQo+IHwgRnJvbSBzY2hlbWE6IERvY3VtZW50YXRpb24vWy4u Ll0vbmFuZC1jb250cm9sbGVyLnlhbWwKPiAKPiBvcmlnaW5hbCBFQ0MgdmFsdWVzIGZvciB0aGVz ZSBvbGQgTWVyYWtpcyBhcmUgc2FkbHkgbm90Cj4gcHJvdmlkZWQgYnkgdGhlIHZlbmRvci4gSXQg bG9va3MgbGlrZSBNZXJha2kganVzdCBzdHVjawo+IHdpdGggd2hhdCBCcm9hZGNvbSdzIFNESyB3 YXMgZG9pbmcuLi4gd2hpY2ggbGVmdCBpdCB1cAo+IHRvIHRoZWlyIHByb3ByaWV0YXJ5IG5hbmQg ZHJpdmVyLgo+IAo+IEl0J3MgY2xlYXIgYXQgbGVhc3QgdGhhdCB0aGV5IHVzZWQgdGhlIGhhcmR3 YXJlJ3MgZWNjCj4gZW5naW5lLCBzbyB1cGRhdGUgdGhlIGRldmljZS10cmVlIGZpbGUgYWNjb3Jk aW5nbHkgdG8KPiBzcGVjaWZ5IHRoZSBuYW5kLWNvbnRyb2xsZXIgYXMgdGhlIGVjYy1lbmdpbmUu CgpJIGJlbGlldmUgdGhhdCBpbml0aWFsIHN0YXRlIGNhbiBiZSAic2V0dXAiIGF0IGhhcmR3YXJl IGxldmVsLiBJIGJlbGlldmUKQnJvYWRjb20ncyBib290bG9hZGVyIGFuZCB0aGVpciBTREsgZHJp dmVyIGp1c3QgcmVhZHMgY3VycmVudCBFQ0Mgc2V0dXAKKHdoaWNoIGdvZXMgZG93biB0byB0aGUg aGFyZHdhcmUgbGV2ZWwpLgoKWWVhcnMgYWdvIEkgcHJvcG9zZWQgY2hhbmdlIGZvciBicmNtbmFu ZCB0byBkbyB0aGUgc2FtZSAod2hpY2ggd2FzCmFwcGFyZW50bHkgYSBiYWQgaWRlYSk6CltQQVRD SF0gbXRkOiBicmNtbmFuZDogc2V0IGluaXRpYWwgRUNDIHBhcmFtcyBiYXNlZCBvbiBpbmZvIGZy b20gSFcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL3BpcGVybWFpbC9saW51eC1tdGQvMjAx Ni1GZWJydWFyeS8wNjUzMTQuaHRtbAoKVGhhdCBzYWlkIEkgdGhpbmsgaXQgc3RpbGwgc2hvdWxk IGJlIHBvc3NpYmxlIHRvIGRldGVybWluZSB3aGF0IGFsZ28gaXMKdXNlZCBhbmQgc3BlY2lmeSB0 aGF0IGluIERULgoKCj4gdGhpcyBwYXRjaCBhbHNvIHJlbW92ZXMgdGhlIHBhcnRpdGlvbiBpbmRl eCBudW1iZXJzCj4gZnJvbSB0aGUgTVIzMidzIHBhcnRpdGlvbiBub2RlLW5hbWVzIGFuZCBkb2Vz IHNvbWUKPiB3aGl0ZXNwYWNlIHJlbW92YWwgaW4gb3JkZXIgdG8gZml0IHRoZSBjb21tZW50IGFi b3V0Cj4gdGhlIHBhcnRpdGlvbiBvZGRpdGllcyBpbnRvIHRoZSAxMDAgY2hhcmFjdGVycyBwZXIK PiBsaW1pdC4KPiAKPiBGaXhlczogOTM1MzI3YTczNTUzICgiQVJNOiBkdHM6IEJDTTUzMDFYOiBB ZGQgRFQgZm9yIE1lcmFraSBNUjI2IikKPiBGaXhlczogZWM4OGE5YzM0NGQ5ICgiQVJNOiBCQ001 MzAxWDogQWRkIERUIGZvciBNZXJha2kgTVIzMiIpCj4gUmVwb3J0ZWQtYnk6IFJhZmHFgiBNacWC ZWNraSA8emFqZWM1QGdtYWlsLmNvbT4gKHZpYSBtYWlsKQo+IFNpZ25lZC1vZmYtYnk6IENocmlz dGlhbiBMYW1wYXJ0ZXIgPGNodW5rZWV5QGdtYWlsLmNvbT4KPiAKPiBtcjMyCj4gLS0tCj4gICBh cmNoL2FybS9ib290L2R0cy9iY201MzAxNS1tZXJha2ktbXIyNi5kdHMgfCA2OCArKysrKysrKyst LS0tLS0tLQo+ICAgYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMTYtbWVyYWtpLW1yMzIuZHRzIHwg ODggKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA4NiBpbnNlcnRp b25zKCspLCA3MCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9k dHMvYmNtNTMwMTUtbWVyYWtpLW1yMjYuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMTUt bWVyYWtpLW1yMjYuZHRzCj4gaW5kZXggYTJlZWU5YTFlNWE3Li45ZWE0ZmZjMWJiNzEgMTAwNjQ0 Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMTUtbWVyYWtpLW1yMjYuZHRzCj4gKysr IGIvYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMTUtbWVyYWtpLW1yMjYuZHRzCj4gQEAgLTksNyAr OSw2IEBACj4gICAvZHRzLXYxLzsKPiAgIAo+ICAgI2luY2x1ZGUgImJjbTQ3MDguZHRzaSIKPiAt I2luY2x1ZGUgImJjbTUzMDF4LW5hbmQtY3MwLWJjaDguZHRzaSIKPiAgICNpbmNsdWRlIDxkdC1i aW5kaW5ncy9sZWRzL2NvbW1vbi5oPgo+ICAgCj4gICAvIHsKPiBAQCAtNzMsNDEgKzcyLDUwIEBA ICZnbWFjMyB7Cj4gICAJc3RhdHVzID0gImRpc2FibGVkIjsKPiAgIH07Cj4gICAKPiAtJm5hbmRj cyB7Cj4gLQluYW5kLWVjYy1hbGdvID0gImh3IjsKPiArJm5hbmRfY29udHJvbGxlciB7Cj4gKwlu YW5kQDAgewo+ICsJCWNvbXBhdGlibGUgPSAiYnJjbSxuYW5kY3MiOwo+ICsJCXJlZyA9IDwwPjsK PiArCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkjc2l6ZS1jZWxscyA9IDwxPjsKPiAgIAo+ IC0JcGFydGl0aW9ucyB7Cj4gLQkJY29tcGF0aWJsZSA9ICJmaXhlZC1wYXJ0aXRpb25zIjsKPiAt CQkjYWRkcmVzcy1jZWxscyA9IDwweDE+Owo+IC0JCSNzaXplLWNlbGxzID0gPDB4MT47Cj4gKwkJ bmFuZC1lY2MtZW5naW5lID0gPCZuYW5kX2NvbnRyb2xsZXI+Owo+ICsJCW5hbmQtZWNjLXN0cmVu Z3RoID0gPDg+Owo+ICsJCW5hbmQtZWNjLXN0ZXAtc2l6ZSA9IDw1MTI+OwoKSWYgd2UgcmVhbGx5 IGNhbid0IGRldGVybWluZSBFQ0MgYWxnbyBtYXliZSB3ZSBjb3VsZCBzdGlsbCBoYXZlIHN0aCBs aWtlCmJjbTUzMDF4LW5hbmQtY3MwLUZPTy5kdHNpCnRvIG1hdGNoIG90aGVyIEVDQyBzZXR1cD8K ClRoYXQgd2F5IHlvdSBwcm9iYWJseSBhbHNvIHNob3VsZG4ndCBuZWVkICZuYW5kX2NvbnRyb2xs ZXIgaGVyZS4KCgo+ICAgCj4gLQkJcGFydGl0aW9uQDAgewo+IC0JCQlsYWJlbCA9ICJ1LWJvb3Qi Owo+IC0JCQlyZWcgPSA8MHgwIDB4MjAwMDAwPjsKPiAtCQkJcmVhZC1vbmx5Owo+IC0JCX07Cj4g KwkJcGFydGl0aW9ucyB7Cj4gKwkJCWNvbXBhdGlibGUgPSAiZml4ZWQtcGFydGl0aW9ucyI7Cj4g KwkJCSNhZGRyZXNzLWNlbGxzID0gPDB4MT47Cj4gKwkJCSNzaXplLWNlbGxzID0gPDB4MT47Cj4g ICAKPiAtCQlwYXJ0aXRpb25AMjAwMDAwIHsKPiAtCQkJbGFiZWwgPSAidS1ib290LWVudiI7Cj4g LQkJCXJlZyA9IDwweDIwMDAwMCAweDIwMDAwMD47Cj4gLQkJCS8qIGVtcHR5ICovCj4gLQkJfTsK PiArCQkJcGFydGl0aW9uQDAgewo+ICsJCQkJbGFiZWwgPSAidS1ib290IjsKPiArCQkJCXJlZyA9 IDwweDAgMHgyMDAwMDA+Owo+ICsJCQkJcmVhZC1vbmx5Owo+ICsJCQl9Owo+ICAgCj4gLQkJcGFy dGl0aW9uQDQwMDAwMCB7Cj4gLQkJCWxhYmVsID0gInUtYm9vdC1iYWNrdXAiOwo+IC0JCQlyZWcg PSA8MHg0MDAwMDAgMHgyMDAwMDA+Owo+IC0JCQkvKiBlbXB0eSAqLwo+IC0JCX07Cj4gKwkJCXBh cnRpdGlvbkAyMDAwMDAgewo+ICsJCQkJbGFiZWwgPSAidS1ib290LWVudiI7Cj4gKwkJCQlyZWcg PSA8MHgyMDAwMDAgMHgyMDAwMDA+Owo+ICsJCQkJLyogZW1wdHkgKi8KPiArCQkJfTsKPiAgIAo+ IC0JCXBhcnRpdGlvbkA2MDAwMDAgewo+IC0JCQlsYWJlbCA9ICJ1LWJvb3QtZW52LWJhY2t1cCI7 Cj4gLQkJCXJlZyA9IDwweDYwMDAwMCAweDIwMDAwMD47Cj4gLQkJCS8qIGVtcHR5ICovCj4gLQkJ fTsKPiArCQkJcGFydGl0aW9uQDQwMDAwMCB7Cj4gKwkJCQlsYWJlbCA9ICJ1LWJvb3QtYmFja3Vw IjsKPiArCQkJCXJlZyA9IDwweDQwMDAwMCAweDIwMDAwMD47Cj4gKwkJCQkvKiBlbXB0eSAqLwo+ ICsJCQl9Owo+ICAgCj4gLQkJcGFydGl0aW9uQDgwMDAwMCB7Cj4gLQkJCWxhYmVsID0gInViaSI7 Cj4gLQkJCXJlZyA9IDwweDgwMDAwMCAweDc3ODAwMDA+Owo+ICsJCQlwYXJ0aXRpb25ANjAwMDAw IHsKPiArCQkJCWxhYmVsID0gInUtYm9vdC1lbnYtYmFja3VwIjsKPiArCQkJCXJlZyA9IDwweDYw MDAwMCAweDIwMDAwMD47Cj4gKwkJCQkvKiBlbXB0eSAqLwo+ICsJCQl9Owo+ICsKPiArCQkJcGFy dGl0aW9uQDgwMDAwMCB7Cj4gKwkJCQlsYWJlbCA9ICJ1YmkiOwo+ICsJCQkJcmVnID0gPDB4ODAw MDAwIDB4Nzc4MDAwMD47Cj4gKwkJCX07Cj4gICAJCX07Cj4gICAJfTsKPiAgIH07Cj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2JjbTUzMDE2LW1lcmFraS1tcjMyLmR0cyBiL2FyY2gv YXJtL2Jvb3QvZHRzL2JjbTUzMDE2LW1lcmFraS1tcjMyLmR0cwo+IGluZGV4IGI2YTA2NmY5NDlh ZC4uYmNhMzliMzBhY2U4IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2JjbTUzMDE2 LW1lcmFraS1tcjMyLmR0cwo+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2JjbTUzMDE2LW1lcmFr aS1tcjMyLmR0cwo+IEBAIC05LDcgKzksNiBAQAo+ICAgL2R0cy12MS87Cj4gICAKPiAgICNpbmNs dWRlICJiY200NzA4LmR0c2kiCj4gLSNpbmNsdWRlICJiY201MzAxeC1uYW5kLWNzMC1iY2g4LmR0 c2kiCj4gICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvbGVkcy9jb21tb24uaD4KPiAgIAo+ICAgLyB7 Cj4gQEAgLTEyNCw0OSArMTIzLDU4IEBAICZwd20gewo+ICAgCXBpbmN0cmwtMCA9IDwmcGlubXV4 X3B3bT47Cj4gICB9Owo+ICAgCj4gLSZuYW5kY3Mgewo+IC0JbmFuZC1lY2MtYWxnbyA9ICJodyI7 Cj4gLQo+IC0JcGFydGl0aW9ucyB7Cj4gLQkJLyoKPiAtCQkgKiBUaGUgcGFydGl0aW9uIGF1dG9k ZXRlY3Rpb24gZG9lcyBub3Qgd29yayBmb3IgdGhpcyBkZXZpY2UuCj4gLQkJICogSXQgd2lsbCBv bmx5IGRldGVjdCB0aGUgIm52cmFtIiBwYXJ0aXRpb24gd2l0aCBhbiBpbmNvcnJlY3Qgc2l6ZS4K PiAtCQkgKglbICAgIDEuNzIxNjY3XSAxIGJjbTQ3eHhwYXJ0IHBhcnRpdGlvbnMgZm91bmQgb24g TVREIGRldmljZSBicmNtbmFuZC4wCj4gLQkJICoJWyAgICAxLjcyNzk2Ml0gQ3JlYXRpbmcgMSBN VEQgcGFydGl0aW9ucyBvbiAiYnJjbW5hbmQuMCI6Cj4gLQkJICoJWyAgICAxLjczMzExN10gMHgw MDAwMDA0MDAwMDAtMHgwMDAwMDgwMDAwMDAgOiAibnZyYW0iCj4gLQkJICovCj4gLQo+IC0JCWNv bXBhdGlibGUgPSAiZml4ZWQtcGFydGl0aW9ucyI7Cj4gLQkJI2FkZHJlc3MtY2VsbHMgPSA8MHgx PjsKPiAtCQkjc2l6ZS1jZWxscyA9IDwweDE+Owo+IC0KPiAtCQlwYXJ0aXRpb24wQDAgewo+IC0J CQlsYWJlbCA9ICJ1LWJvb3QiOwo+IC0JCQlyZWcgPSA8MHgwIDB4MTAwMDAwPjsKPiAtCQkJcmVh ZC1vbmx5Owo+IC0JCX07Cj4gKyZuYW5kX2NvbnRyb2xsZXIgewo+ICsJbmFuZEAwIHsKPiArCQlj b21wYXRpYmxlID0gImJyY20sbmFuZGNzIjsKPiArCQlyZWcgPSA8MD47Cj4gKwkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47Cj4gKwkJI3NpemUtY2VsbHMgPSA8MT47Cj4gICAKPiAtCQlwYXJ0aXRpb24x QDEwMDAwMCB7Cj4gLQkJCWxhYmVsID0gImJvb3RrZXJuZWwxIjsKPiAtCQkJcmVnID0gPDB4MTAw MDAwIDB4MzAwMDAwPjsKPiAtCQkJcmVhZC1vbmx5Owo+IC0JCX07Cj4gKwkJbmFuZC1lY2MtZW5n aW5lID0gPCZuYW5kX2NvbnRyb2xsZXI+Owo+ICsJCW5hbmQtZWNjLXN0cmVuZ3RoID0gPDg+Owo+ ICsJCW5hbmQtZWNjLXN0ZXAtc2l6ZSA9IDw1MTI+Owo+ICsKPiArCQlwYXJ0aXRpb25zIHsKPiAr CQkJLyoKPiArCQkJICogVGhlIHBhcnRpdGlvbiBhdXRvZGV0ZWN0aW9uIGRvZXMgbm90IHdvcmsg Zm9yIHRoaXMgZGV2aWNlLgo+ICsJCQkgKiBJdCB3aWxsIG9ubHkgZGV0ZWN0IHRoZSAibnZyYW0i IHBhcnRpdGlvbiB3aXRoIGFuIGluY29ycmVjdCBzaXplLgo+ICsJCQkgKglbIDEuNzIxNjY3XSAx IGJjbTQ3eHhwYXJ0IHBhcnRpdGlvbnMgZm91bmQgb24gTVREIGRldmljZSBicmNtbmFuZC4wCj4g KwkJCSAqCVsgMS43Mjc5NjJdIENyZWF0aW5nIDEgTVREIHBhcnRpdGlvbnMgb24gImJyY21uYW5k LjAiOgo+ICsJCQkgKglbIDEuNzMzMTE3XSAweDAwMDAwMDQwMDAwMC0weDAwMDAwODAwMDAwMCA6 ICJudnJhbSIKPiArCQkJICovCj4gKwo+ICsJCQljb21wYXRpYmxlID0gImZpeGVkLXBhcnRpdGlv bnMiOwo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwweDE+Owo+ICsJCQkjc2l6ZS1jZWxscyA9IDww eDE+Owo+ICsKPiArCQkJcGFydGl0aW9uQDAgewo+ICsJCQkJbGFiZWwgPSAidS1ib290IjsKPiAr CQkJCXJlZyA9IDwweDAgMHgxMDAwMDA+Owo+ICsJCQkJcmVhZC1vbmx5Owo+ICsJCQl9Owo+ICAg Cj4gLQkJcGFydGl0aW9uMkA0MDAwMDAgewo+IC0JCQlsYWJlbCA9ICJudnJhbSI7Cj4gLQkJCXJl ZyA9IDwweDQwMDAwMCAweDEwMDAwMD47Cj4gLQkJCXJlYWQtb25seTsKPiAtCQl9Owo+ICsJCQlw YXJ0aXRpb25AMTAwMDAwIHsKPiArCQkJCWxhYmVsID0gImJvb3RrZXJuZWwxIjsKPiArCQkJCXJl ZyA9IDwweDEwMDAwMCAweDMwMDAwMD47Cj4gKwkJCQlyZWFkLW9ubHk7Cj4gKwkJCX07Cj4gICAK PiAtCQlwYXJ0aXRpb24zQDUwMDAwMCB7Cj4gLQkJCWxhYmVsID0gImJvb3RrZXJuZWwyIjsKPiAt CQkJcmVnID0gPDB4NTAwMDAwIDB4MzAwMDAwPjsKPiAtCQkJcmVhZC1vbmx5Owo+IC0JCX07Cj4g KwkJCXBhcnRpdGlvbkA0MDAwMDAgewo+ICsJCQkJbGFiZWwgPSAibnZyYW0iOwo+ICsJCQkJcmVn ID0gPDB4NDAwMDAwIDB4MTAwMDAwPjsKPiArCQkJCXJlYWQtb25seTsKPiArCQkJfTsKPiAgIAo+ IC0JCXBhcnRpdGlvbjRAODAwMDAwIHsKPiAtCQkJbGFiZWwgPSAidWJpIjsKPiAtCQkJcmVnID0g PDB4ODAwMDAwIDB4Nzc4MDAwMD47Cj4gKwkJCXBhcnRpdGlvbkA1MDAwMDAgewo+ICsJCQkJbGFi ZWwgPSAiYm9vdGtlcm5lbDIiOwo+ICsJCQkJcmVnID0gPDB4NTAwMDAwIDB4MzAwMDAwPjsKPiAr CQkJCXJlYWQtb25seTsKPiArCQkJfTsKPiArCj4gKwkJCXBhcnRpdGlvbkA4MDAwMDAgewo+ICsJ CQkJbGFiZWwgPSAidWJpIjsKPiArCQkJCXJlZyA9IDwweDgwMDAwMCAweDc3ODAwMDA+Owo+ICsJ CQl9Owo+ICAgCQl9Owo+ICAgCX07Cj4gICB9OwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89D8C7EE24 for ; Mon, 5 Jun 2023 11:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232184AbjFELTs (ORCPT ); Mon, 5 Jun 2023 07:19:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232128AbjFELTq (ORCPT ); Mon, 5 Jun 2023 07:19:46 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4769DCD for ; Mon, 5 Jun 2023 04:19:44 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4f004cc54f4so5839336e87.3 for ; Mon, 05 Jun 2023 04:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685963982; x=1688555982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gmCHyHNSkjzU7AeM7yN45tWKNNye8v8VFhaj+USDU5o=; b=MBFSRoIKFCrvOMRVVFnJJb2K9ocu521ToRzTXzvI62o+0LPcXNAks0dU/IdUVrsMAV /fACbPvmw4QpwcJXavJqZS66vs1pYLlNuWcZBOs0K+dZwNNGgx0ya4BqcjoRYen1jI0X nVgKhD0sxC5eVDdvtmYDlCzbBfqFnr+NWhq+rol4yIE3Tna3JhCUr+qfp2iklswfmzA9 d1fRrw2+xnNzbwf3wZE0QHkb4AMJHPFxbSc8jSirie/1lvTTrDQX65yA5VP14cdJ7sOu TBqcN6YZZcZh4B9OWyQp7AiuOY0zbYkGhuezIDG6VIckSmY6tjCbdcFQIQX/8fkJf+NM 5rBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685963982; x=1688555982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gmCHyHNSkjzU7AeM7yN45tWKNNye8v8VFhaj+USDU5o=; b=AfWn2RqJmWVvDtHCU8WzxBifJYD7KGyyC0wicIkAEJndslzAX4jJEHndZUYWOSr/k5 mUWJNAtGGjHv2z124xD6kSUUDe1CkiFlozSnV6qV0hWGfQPg7gPSlsm4ABvUbPuGw6hd xEuvK0sx+KuUdYzyt+V2G1zLSoixRqCW2J35BlQCf4ubH4nf8H3BSv61NZwXawIvtKzr ro7t9EX5oTg9IMffH0e/aXGoggNmyYi076o1NLV2z/xRmCLwCKizNlijbWq64AEOo3rr n3m+SVEmb7qPnPov3RP+IuzWmERImSCUbA43o+eTlMEwmL0bScYiwxghP+90UiOZajvi x/ug== X-Gm-Message-State: AC+VfDwi79oLoROkpbE33gnY2k2aGMeFZpc3Aeeuypp1sDKsHZGJ9xZ7 y5RcQKlaD4esz9BQjCoQQBFDaTQLwuA= X-Google-Smtp-Source: ACHHUZ67DucgVxScjuPHm3wgYW3tC8Ib6c/jifYVPlycpRIzXAmoBPppCARqsiRitqote6GovkSkbQ== X-Received: by 2002:ac2:599d:0:b0:4f3:8f3a:f98d with SMTP id w29-20020ac2599d000000b004f38f3af98dmr5312606lfn.45.1685963982153; Mon, 05 Jun 2023 04:19:42 -0700 (PDT) Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id c26-20020ac244ba000000b004f26f437ad8sm1095319lfm.53.2023.06.05.04.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 04:19:41 -0700 (PDT) Message-ID: <7b63ceb0-5e27-8a12-fa25-8fdccad4f5aa@gmail.com> Date: Mon, 5 Jun 2023 13:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/3] ARM: MR26: MR32: remove bogus nand-ecc-algo property Content-Language: en-US To: Christian Lamparter , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Florian Fainelli , Hauke Mehrtens , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <869354dba00f01d4e6bde897a44180ad1658389c.1685801691.git.chunkeey@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <869354dba00f01d4e6bde897a44180ad1658389c.1685801691.git.chunkeey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3.06.2023 16:16, Christian Lamparter wrote: > | bcm53015-meraki-mr26.dtb: nand-controller@18028000: > | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] > | From schema: Documentation/[...]/nand-controller.yaml > | bcm53016-meraki-mr32.dtb: nand-controller@18028000: > | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] > | From schema: Documentation/[...]/nand-controller.yaml > > original ECC values for these old Merakis are sadly not > provided by the vendor. It looks like Meraki just stuck > with what Broadcom's SDK was doing... which left it up > to their proprietary nand driver. > > It's clear at least that they used the hardware's ecc > engine, so update the device-tree file accordingly to > specify the nand-controller as the ecc-engine. I believe that initial state can be "setup" at hardware level. I believe Broadcom's bootloader and their SDK driver just reads current ECC setup (which goes down to the hardware level). Years ago I proposed change for brcmnand to do the same (which was apparently a bad idea): [PATCH] mtd: brcmnand: set initial ECC params based on info from HW https://lists.infradead.org/pipermail/linux-mtd/2016-February/065314.html That said I think it still should be possible to determine what algo is used and specify that in DT. > this patch also removes the partition index numbers > from the MR32's partition node-names and does some > whitespace removal in order to fit the comment about > the partition oddities into the 100 characters per > limit. > > Fixes: 935327a73553 ("ARM: dts: BCM5301X: Add DT for Meraki MR26") > Fixes: ec88a9c344d9 ("ARM: BCM5301X: Add DT for Meraki MR32") > Reported-by: Rafał Miłecki (via mail) > Signed-off-by: Christian Lamparter > > mr32 > --- > arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 68 +++++++++-------- > arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 88 ++++++++++++---------- > 2 files changed, 86 insertions(+), 70 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts > index a2eee9a1e5a7..9ea4ffc1bb71 100644 > --- a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts > +++ b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts > @@ -9,7 +9,6 @@ > /dts-v1/; > > #include "bcm4708.dtsi" > -#include "bcm5301x-nand-cs0-bch8.dtsi" > #include > > / { > @@ -73,41 +72,50 @@ &gmac3 { > status = "disabled"; > }; > > -&nandcs { > - nand-ecc-algo = "hw"; > +&nand_controller { > + nand@0 { > + compatible = "brcm,nandcs"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <1>; > > - partitions { > - compatible = "fixed-partitions"; > - #address-cells = <0x1>; > - #size-cells = <0x1>; > + nand-ecc-engine = <&nand_controller>; > + nand-ecc-strength = <8>; > + nand-ecc-step-size = <512>; If we really can't determine ECC algo maybe we could still have sth like bcm5301x-nand-cs0-FOO.dtsi to match other ECC setup? That way you probably also shouldn't need &nand_controller here. > > - partition@0 { > - label = "u-boot"; > - reg = <0x0 0x200000>; > - read-only; > - }; > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > > - partition@200000 { > - label = "u-boot-env"; > - reg = <0x200000 0x200000>; > - /* empty */ > - }; > + partition@0 { > + label = "u-boot"; > + reg = <0x0 0x200000>; > + read-only; > + }; > > - partition@400000 { > - label = "u-boot-backup"; > - reg = <0x400000 0x200000>; > - /* empty */ > - }; > + partition@200000 { > + label = "u-boot-env"; > + reg = <0x200000 0x200000>; > + /* empty */ > + }; > > - partition@600000 { > - label = "u-boot-env-backup"; > - reg = <0x600000 0x200000>; > - /* empty */ > - }; > + partition@400000 { > + label = "u-boot-backup"; > + reg = <0x400000 0x200000>; > + /* empty */ > + }; > > - partition@800000 { > - label = "ubi"; > - reg = <0x800000 0x7780000>; > + partition@600000 { > + label = "u-boot-env-backup"; > + reg = <0x600000 0x200000>; > + /* empty */ > + }; > + > + partition@800000 { > + label = "ubi"; > + reg = <0x800000 0x7780000>; > + }; > }; > }; > }; > diff --git a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts > index b6a066f949ad..bca39b30ace8 100644 > --- a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts > +++ b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts > @@ -9,7 +9,6 @@ > /dts-v1/; > > #include "bcm4708.dtsi" > -#include "bcm5301x-nand-cs0-bch8.dtsi" > #include > > / { > @@ -124,49 +123,58 @@ &pwm { > pinctrl-0 = <&pinmux_pwm>; > }; > > -&nandcs { > - nand-ecc-algo = "hw"; > - > - partitions { > - /* > - * The partition autodetection does not work for this device. > - * It will only detect the "nvram" partition with an incorrect size. > - * [ 1.721667] 1 bcm47xxpart partitions found on MTD device brcmnand.0 > - * [ 1.727962] Creating 1 MTD partitions on "brcmnand.0": > - * [ 1.733117] 0x000000400000-0x000008000000 : "nvram" > - */ > - > - compatible = "fixed-partitions"; > - #address-cells = <0x1>; > - #size-cells = <0x1>; > - > - partition0@0 { > - label = "u-boot"; > - reg = <0x0 0x100000>; > - read-only; > - }; > +&nand_controller { > + nand@0 { > + compatible = "brcm,nandcs"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <1>; > > - partition1@100000 { > - label = "bootkernel1"; > - reg = <0x100000 0x300000>; > - read-only; > - }; > + nand-ecc-engine = <&nand_controller>; > + nand-ecc-strength = <8>; > + nand-ecc-step-size = <512>; > + > + partitions { > + /* > + * The partition autodetection does not work for this device. > + * It will only detect the "nvram" partition with an incorrect size. > + * [ 1.721667] 1 bcm47xxpart partitions found on MTD device brcmnand.0 > + * [ 1.727962] Creating 1 MTD partitions on "brcmnand.0": > + * [ 1.733117] 0x000000400000-0x000008000000 : "nvram" > + */ > + > + compatible = "fixed-partitions"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + > + partition@0 { > + label = "u-boot"; > + reg = <0x0 0x100000>; > + read-only; > + }; > > - partition2@400000 { > - label = "nvram"; > - reg = <0x400000 0x100000>; > - read-only; > - }; > + partition@100000 { > + label = "bootkernel1"; > + reg = <0x100000 0x300000>; > + read-only; > + }; > > - partition3@500000 { > - label = "bootkernel2"; > - reg = <0x500000 0x300000>; > - read-only; > - }; > + partition@400000 { > + label = "nvram"; > + reg = <0x400000 0x100000>; > + read-only; > + }; > > - partition4@800000 { > - label = "ubi"; > - reg = <0x800000 0x7780000>; > + partition@500000 { > + label = "bootkernel2"; > + reg = <0x500000 0x300000>; > + read-only; > + }; > + > + partition@800000 { > + label = "ubi"; > + reg = <0x800000 0x7780000>; > + }; > }; > }; > };