All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: "Bitterblue Smith" <rtl8821cerfe2@gmail.com>,
	"Алексей Смирнов" <debugger94@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Jes Sorensen" <Jes.Sorensen@gmail.com>
Subject: RE: Remove TL-WN722N V2 from untested devices
Date: Mon, 1 Sep 2025 02:51:10 +0000	[thread overview]
Message-ID: <7b8841cc3be54bdebc09522e44a39615@realtek.com> (raw)
In-Reply-To: <1830368c466c4b17999a7f2c76b7f6c8@realtek.com>

Ping-Ke Shih <pkshih@realtek.com> wrote:
> + Jes
> 
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> > On 25/08/2025 08:57, Ping-Ke Shih wrote:
> > > Алексей Смирнов <debugger94@gmail.com> wrote:
> > >> I have been using this Wi-Fi dongle for many years now and have had no
> > >> problems with it. The device is quite old and known, dumping its efuse to
> > >> the log and asking the user to send the results to Jes.Sorensen@gmail.com
> > >> on every boot makes little sense. Please apply:
> > >
> > > I'll rephrase commit message when I merge this:
> > >
> > > wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices
> > >
> > > This Wi-Fi dongle has been used for many years now and have had no problems
> > > with it. The device is quite old and known, dumping its efuse to the log and
> > > asking the user to send the results to Jes.Sorensen@gmail.com on every boot
> > > makes little sense.
> > >
> > > Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
> > > Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> > >
> > >>
> > >> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> index 831b5025c634..113e01df0902 100644
> > >> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
> > >>                         untested = 0;
> > >>                 break;
> > >>         case 0x2357:
> > >> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
> > >> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
> > >> || id->idProduct == 0x0135)
> > >>                         untested = 0;
> > >>                 break;
> > >>         case 0x0b05:
> > >
> >
> > I propose we simply remove the entire list of tested devices. It's not
> > particularly useful to tell people to report if a device works or not.
> > If it doesn't work they will report it anyway.
> 
> This untested flag was added since 2015 at first commit, but I wasn't here
> at that time. Jes, could you please comment this untested report of efuse
> is still useful now?
> 

I merged this patch ahead, and we may rely on Martin's patch [1] to get
efuse content, so after that patch gets merged, the 'untested' stuff
can be removed entirely.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20250826090015.1552939-1-martin.kaistra@linutronix.de/



  reply	other threads:[~2025-09-01  2:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  9:46 Remove TL-WN722N V2 from untested devices Алексей Смирнов
2025-08-25  5:57 ` Ping-Ke Shih
2025-08-25 11:55   ` Bitterblue Smith
2025-08-26  0:22     ` Ping-Ke Shih
2025-09-01  2:51       ` Ping-Ke Shih [this message]
2025-09-01  2:45 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b8841cc3be54bdebc09522e44a39615@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=debugger94@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.