From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7143CE8D6B for ; Mon, 17 Nov 2025 15:12:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 507B410E3BE; Mon, 17 Nov 2025 15:12:28 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id E66D710E3BE for ; Mon, 17 Nov 2025 15:12:26 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D5DD3FEC; Mon, 17 Nov 2025 07:12:18 -0800 (PST) Received: from [10.57.69.30] (unknown [10.57.69.30]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CD6DA3F66E; Mon, 17 Nov 2025 07:12:24 -0800 (PST) Message-ID: <7b885620-3af0-4b8a-9c94-fb9bbc8cd44d@arm.com> Date: Mon, 17 Nov 2025 15:12:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] drm/panthor: Relax a check in panthor_sched_pre_reset() To: Boris Brezillon , Liviu Dudau , =?UTF-8?Q?Adri=C3=A1n_Larumbe?= Cc: dri-devel@lists.freedesktop.org, Akash Goel , Karunika Choo , kernel@collabora.com References: <20251113103953.1519935-1-boris.brezillon@collabora.com> <20251113103953.1519935-7-boris.brezillon@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251113103953.1519935-7-boris.brezillon@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13/11/2025 10:39, Boris Brezillon wrote: > Groups are only moved out of the runnable lists when > panthor_group_stop() is called or when they run out of jobs. > What should not happen though is having one group added to one of > the runnable list after reset.in_progress has been set to true, but > that's not something we can easily check, so let's just drop the > WARN_ON() in panthor_sched_pre_reset(). > > v2: > - Adjust explanation in commit message > > Reviewed-by: Liviu Dudau > Signed-off-by: Boris Brezillon Ah, so if I wasn't so far behind on my emails I'd have spotted this updated version! ;) That commit message looks fine. Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index e74ca071159d..d121b794bd79 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2836,8 +2836,6 @@ void panthor_sched_pre_reset(struct panthor_device *ptdev) > * new jobs while we're resetting. > */ > for (i = 0; i < ARRAY_SIZE(sched->groups.runnable); i++) { > - /* All groups should be in the idle lists. */ > - drm_WARN_ON(&ptdev->base, !list_empty(&sched->groups.runnable[i])); > list_for_each_entry_safe(group, group_tmp, &sched->groups.runnable[i], run_node) > panthor_group_stop(group); > }