From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A285541737A for ; Tue, 7 Jul 2026 13:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431794; cv=none; b=WXwHewMfDaPOqJV/awX+aLoMp9g7hQIacQA//sEUGX/QX80W3trDkJaME2Aj/UftDPKXvcawaQ/ryDp8UeNY8PrHahYG59/Cq77+cHy0z3QCikxiWOeSu5BHjerDiyLAK60nQz1MJXXCP7PcLZSArwF+K8kb0k9BJCjdoMr9SjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431794; c=relaxed/simple; bh=vyggCS8/8Qv8n9WV96DxaxC/lL9XVH1s4J/vy2I3mts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SWpxlmaCi9EZSvKCUOaITkAWrLWuJNgRh1rsd+aSb6QhljSO2MPpk9YQwg4KwF3Qfl7CVuo8oTDSmm5MDy62BV/2qt6F0S6vrwlgev0m68zgZ0mY+3kZXTyj4mjWylKPi/PVCrsA20ZkA48fIhoCaRf6Rk2cVNnHnBagud26EsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UUxoE6FL; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UUxoE6FL" Message-ID: <7b8e9361-2fc9-4302-b055-3657b19d2272@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783431789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aG3X1ya+0km0oxyUXBPlwAFhN6sHcih76OASOC2zKKE=; b=UUxoE6FLRyeyv1pRizrkZgNqtZh3uKh/XEq7RJ2BMQuBd0kbp8ZYmBJwNMHYw2dnfgd2ZH EUwT0j+uGcd5/WypU+Je+HfGb3393ucPzyumfpBcVeILXhJr5kbzcS6phn+PeyaZs+mzJW SEBD+SxCmGJJni5tp4ROvMtCIDxVXig= Date: Tue, 7 Jul 2026 21:42:59 +0800 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v8 2/2] bpf: Reject programs with inlined helpers if JIT is not available To: Eduard Zingerman , Tiezhu Yang , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , KaFai Wan Cc: bpf@vger.kernel.org, loongarch@lists.linux.dev, Puranjay Mohan , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= References: <20260706040006.10331-1-yangtiezhu@loongson.cn> <20260706040006.10331-3-yangtiezhu@loongson.cn> <1c1738784ae321ed5c9dfa0aca6d0f483592713f.camel@gmail.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: <1c1738784ae321ed5c9dfa0aca6d0f483592713f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/7/7 17:27, Eduard Zingerman wrote: > On Tue, 2026-07-07 at 10:03 +0800, Leon Hwang wrote: [...] >> >> Vincent Thiberville reported an interpreter fallback issue for the >> internal BPF_ADDR_PERCPU insn [1]. > > As far as I understand, [1] is caused by map lookup helper inlining, Correct. > bpf_jit_inlines_helper_call() is unrelated this mechanism and only > covers that three helpers I listed above. Yes. > >> And, I was trying to fix assorted interpreter fallback issues [2]. >> >> I think it is worth fixing the interpreter fallback issue for the JIT >> inlineable helper. > > Meaning that you'd prefer the bpf_get_smp_processor_id() and co to > work correctly w/o JIT, do I understand you correctly? > Hmm, no. According to Alexei's comment [1], we should reject the helper by the way of this patch. [1] https://lore.kernel.org/bpf/DJN001X0S57Y.18CKUS4NDDQT1@gmail.com/ Thanks, Leon