All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
To: Richard Cheng <icheng@nvidia.com>, <jic23@kernel.org>,
	<dave@stgolabs.net>, <dave.jiang@intel.com>,
	<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
	<iweiny@kernel.org>
Cc: <ming.li@zohomail.com>, <kaihengf@nvidia.com>, <kobak@nvidia.com>,
	<newtonl@nvidia.com>, <kristinc@nvidia.com>, <mochs@nvidia.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] PCI: Return -ETIMEOUT when reset readiness polling expires
Date: Fri, 30 Oct 2026 16:04:16 -0500	[thread overview]
Message-ID: <7b94e71d-e582-436a-b2a3-2402fc92c773@amd.com> (raw)
In-Reply-To: <20260929020405.9724-3-icheng@nvidia.com>

On 9/28/2026 9:04 PM, Richard Cheng wrote:
> pci_dev_wait() return -ENOTTY when the device fails to become ready. The
> reset framekwork interprets this as an unsupported reset method and may

typo in framework

> try another method.
> 
> Return -ETIMEOUT to report the timeout and stop reset-method fallback.
> 
and -ETIMEOUT is missing the 'D'.

The sashiko report also brought up my first thought with this, which is that there may
be a device and/or driver that relies on this behavior. I'm *extremely* far from an expert
on PCI code though, so someone else will have to weigh in.

> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> ---
>  drivers/pci/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6461274bdbcf..d59a374a350d 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -1279,7 +1279,7 @@ static int pci_dev_wait(struct pci_dev *dev, char *reset_type, int timeout)
>  		if (delay > timeout) {
>  			pci_err(dev, "not ready %dms after %s; giving up\n",
>  				delay - 1, reset_type);
> -			return -ENOTTY;
> +			return -ETIMEDOUT;
>  		}
>  
>  		if (delay > PCI_RESET_WAIT) {


  parent reply	other threads:[~2026-10-30 21:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  2:04 [PATCH 0/4] PCI/CXL: Guard reset recovery against inaccessible devices Richard Cheng
2026-09-29  2:04 ` [PATCH 1/4] PCI: Reject all-ones responses in pci_dev_wait() Richard Cheng
2026-09-29  2:04 ` [PATCH 2/4] PCI: Return -ETIMEOUT when reset readiness polling expires Richard Cheng
2026-09-29  2:19   ` sashiko-bot
2026-10-30 21:04   ` Cheatham, Benjamin [this message]
2026-09-29  2:04 ` [PATCH 3/4] PCI: Skip state restoration when configuration is inaccessible Richard Cheng
2026-10-30 21:04   ` Cheatham, Benjamin
2026-09-29  2:04 ` [PATCH 4/4] cxl/pci: Guard decoder accesses after reset Richard Cheng
2026-10-30 17:34   ` Dave Jiang
2026-10-30  9:54 ` [PATCH 0/4] PCI/CXL: Guard reset recovery against inaccessible devices Richard Cheng
2026-10-30 21:04 ` Cheatham, Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b94e71d-e582-436a-b2a3-2402fc92c773@amd.com \
    --to=benjamin.cheatham@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=kaihengf@nvidia.com \
    --cc=kobak@nvidia.com \
    --cc=kristinc@nvidia.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=mochs@nvidia.com \
    --cc=newtonl@nvidia.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.