From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Westphal <fw@strlen.de>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
paulb@mellanox.com, vladbu@mellanox.com
Subject: Re: [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing
Date: Thu, 26 Sep 2019 11:15:09 -0700 [thread overview]
Message-ID: <7ba415ed-5332-b01e-8c2e-8e4e65e2d520@gmail.com> (raw)
In-Reply-To: <20190926180609.GB9938@breakpoint.cc>
On 9/26/19 11:06 AM, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>> +static inline void skb_ext_reset(struct sk_buff *skb)
>>> +{
>>> + if (skb->active_extensions) {
>>
>> This deserves an unlikely(skb->active_extensions) hint here ?
>
> unlikely() isn't used in the other helpers (e.g. skb_ext_{put,del,copy}
> either, should I add it there too?
>
At least in GRO paths unlikely() makes sense.
For other paths it might not be the case.
prev parent reply other threads:[~2019-09-26 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 14:18 [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing Florian Westphal
2019-09-26 17:24 ` Eric Dumazet
2019-09-26 18:06 ` Florian Westphal
2019-09-26 18:15 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba415ed-5332-b01e-8c2e-8e4e65e2d520@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
--cc=steffen.klassert@secunet.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.