All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladimir Zapolskiy <vz@mleia.com>,
	Leonardo Felipe Takao Hirata <leo.fthirata@gmail.com>,
	tglx@linutronix.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: Convert nxp,lpc3220-mic.txt to yaml format
Date: Wed, 26 Feb 2025 11:14:55 +0100	[thread overview]
Message-ID: <7ba7cf93-e40d-433d-bba5-c43ce8510ae9@kernel.org> (raw)
In-Reply-To: <29ce9b9b-3993-4b88-a201-5d67050d53ae@mleia.com>

On 26/02/2025 10:41, Vladimir Zapolskiy wrote:
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - nxp,lpc3220-mic
>> +      - nxp,lpc3220-sic
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupt-controller: true
>> +
>> +  '#interrupt-cells':
>> +    const: 2
>> +
>> +  interrupts:
>> +    items:
>> +      - description:
>> +          IRQ number.
> 
> For sake of better understanding SIC1 and SIC2 interrupt controllers
> are chained to MIC, that's why there is 'interrupts' property present,
> and here 0/1 interrupt values are for regular IRQ, 30/31 are for fast IRQ.
> 
> Also please add here
> 
>    minItems: 2
>    maxItems: 2
> 
> I believe that the 'interrupts' property can be just left without any
> given description, or just give a simple description like
> 
>    IRQ and FIQ outputs of sub interrupt controllers to the main interrupt controller
If they are obvious, e.g. maxItems: 2 would be enough, but I understand
that these are distinctive interrupts from dedicated blocks - 1 and 2 -
so they should be listed.
- description: IRQ/FIO of SIC1 (or whatever name is here better)
- description: IRQ/FIO of SIC2

Best regards,
Krzysztof

  reply	other threads:[~2025-02-26 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  1:09 [PATCH v2] dt-bindings: interrupt-controller: Convert nxp,lpc3220-mic.txt to yaml format Leonardo Felipe Takao Hirata
2025-02-26  8:32 ` Krzysztof Kozlowski
2025-02-26  9:41 ` Vladimir Zapolskiy
2025-02-26 10:14   ` Krzysztof Kozlowski [this message]
2025-02-26 13:28     ` Leonardo Felipe Takao Hirata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ba7cf93-e40d-433d-bba5-c43ce8510ae9@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.fthirata@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@linutronix.de \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.