Re: [PATCH v3 4/4] riscv: dts: starfive: remove duplicate itb entries

[E Shattow <e@freeshell.de>]

On 2/21/25 01:58, Heinrich Schuchardt wrote:
> As binman already creates nodes based on CONFIG_OF_LIST we don't need to
> add extra nodes.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org> # StarFIve VisionFive 2
> ---
> v3:
> 	no change
> v2:
> 	no change
> ---
>  .../dts/starfive-visionfive2-binman.dtsi      | 76 -------------------
>  1 file changed, 76 deletions(-)
> 
> diff --git a/arch/riscv/dts/starfive-visionfive2-binman.dtsi b/arch/riscv/dts/starfive-visionfive2-binman.dtsi
> index 4cce001e80d..05787bdb92d 100644
> --- a/arch/riscv/dts/starfive-visionfive2-binman.dtsi
> +++ b/arch/riscv/dts/starfive-visionfive2-binman.dtsi
> @@ -13,82 +13,6 @@
>  };
>  
>  &binman {
> -	itb {
> -		fit {
> -			images {
> -				fdt-jh7110-milkv-mars {
> -					description = "jh7110-milkv-mars";
> -					load = <0x40400000>;
> -					compression = "none";
> -
> -					blob-ext {
> -						filename = "dts/upstream/src/riscv/starfive/jh7110-milkv-mars.dtb";
> -					};
> -				};
> -
> -				fdt-jh7110-pine64-star64 {
> -					description = "jh7110-pine64-star64";
> -					load = <0x40400000>;
> -					compression = "none";
> -
> -					blob-ext {
> -						filename = "dts/upstream/src/riscv/starfive/jh7110-pine64-star64.dtb";
> -					};
> -				};
> -
> -				fdt-jh7110-starfive-visionfive-2-v1.2a {
> -					description = "jh7110-starfive-visionfive-2-v1.2a";
> -					load = <0x40400000>;
> -					compression = "none";
> -
> -					blob-ext {
> -						filename = "dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb";
> -					};
> -				};
> -
> -				fdt-jh7110-starfive-visionfive-2-v1.3b {
> -					description = "jh7110-starfive-visionfive-2-v1.3b";
> -					load = <0x40400000>;
> -					compression = "none";
> -
> -					blob-ext {
> -						filename = "dts/upstream/src/riscv/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb";
> -					};
> -				};
> -			};
> -
> -			configurations {
> -				conf-jh7110-milkv-mars {
> -					description = "jh7110-milkv-mars";
> -					firmware = "opensbi";
> -					loadables = "uboot";
> -					fdt = "fdt-jh7110-milkv-mars";
> -				};
> -
> -				conf-jh7110-pine64-star64 {
> -					description = "jh7110-pine64-star64";
> -					firmware = "opensbi";
> -					loadables = "uboot";
> -					fdt = "fdt-jh7110-pine64-star64";
> -				};
> -
> -				conf-jh7110-starfive-visionfive-2-v1.2a {
> -					description = "jh7110-starfive-visionfive-2-v1.2a";
> -					firmware = "opensbi";
> -					loadables = "uboot";
> -					fdt = "fdt-jh7110-starfive-visionfive-2-v1.2a";
> -				};
> -
> -				conf-jh7110-starfive-visionfive-2-v1.3b {
> -					description = "jh7110-starfive-visionfive-2-v1.3b";
> -					firmware = "opensbi";
> -					loadables = "uboot";
> -					fdt = "fdt-jh7110-starfive-visionfive-2-v1.3b";
> -				};
> -			};
> -		};
> -	};
> -
>  	spl-img {
>  		filename = "spl/u-boot-spl.bin.normal.out";
>  

Reviewed-by: E Shattow <e@freeshell.de>