All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: gregkh@linuxfoundation.org, brauner@kernel.org, josef@toxicpanda.com
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v5.14.y] fuse: verify {g,u}id mount options correctly
Date: Mon, 29 Jul 2024 14:34:19 -0500	[thread overview]
Message-ID: <7bab7fee-6795-4795-821d-788b324f15db@redhat.com> (raw)
In-Reply-To: <2468c31e-f861-4e72-ba5a-66768d468e44@redhat.com>

On 7/29/24 2:30 PM, Eric Sandeen wrote:
> commit 049584807f1d797fc3078b68035450a9769eb5c3 upstream.
> 
> As was done in
> 0200679fc795 ("tmpfs: verify {g,u}id mount options correctly")
> we need to validate that the requested uid and/or gid is representable in
> the filesystem's idmapping.
> 
> Cribbing from the above commit log,
> 
> The contract for {g,u}id mount options and {g,u}id values in general set
> from userspace has always been that they are translated according to the
> caller's idmapping. In so far, fuse has been doing the correct thing.
> But since fuse is mountable in unprivileged contexts it is also
> necessary to verify that the resulting {k,g}uid is representable in the
> namespace of the superblock.
> 
> Fixes: c30da2e981a7 ("fuse: convert to use the new mount API")
> Cc: stable@vger.kernel.org # 5.4+
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> ---
> 
> (compile-tested only)

Sorry, I lied, I compile-tested this patch with the dependency added.
Ignore this one, moving too quickly. :(

-Eric


  reply	other threads:[~2024-07-29 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29  7:52 FAILED: patch "[PATCH] fuse: verify {g,u}id mount options correctly" failed to apply to 5.10-stable tree gregkh
2024-07-29 19:30 ` [PATCH v5.14.y] fuse: verify {g,u}id mount options correctly Eric Sandeen
2024-07-29 19:34   ` Eric Sandeen [this message]
2024-07-29 19:38 ` [PATCH V2 " Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bab7fee-6795-4795-821d-788b324f15db@redhat.com \
    --to=sandeen@redhat.com \
    --cc=brauner@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=josef@toxicpanda.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.