From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21BE6C4167B for ; Wed, 29 Nov 2023 18:46:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4A6BBDF1; Wed, 29 Nov 2023 19:46:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4A6BBDF1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701283591; bh=FN4I76ZU7Cwagn6Bgl8OaeZ+LRU0T1R0zOgimIt+bG4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=PBbhMcF3n+FNbVgJJQl3uEjln1N582x7KvqTFq2diBLI68I5fH7+z+2TNfhM7qpR3 V2YnTnWhymY5y87k/NisN1xyLfnklmh+Ye9XscWywMk+aqNnoim4EAZ8FbuWc3UX8f pY64Mm2eqhwP81SA2bkmtAyx7lujPe3gGf5r/6m8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 39857F8056F; Wed, 29 Nov 2023 19:45:59 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5025CF80254; Wed, 29 Nov 2023 19:45:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 32300F80236; Wed, 29 Nov 2023 19:45:53 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1AFF6F8007E for ; Wed, 29 Nov 2023 19:45:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1AFF6F8007E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Ef+f+pvD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701283546; x=1732819546; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FN4I76ZU7Cwagn6Bgl8OaeZ+LRU0T1R0zOgimIt+bG4=; b=Ef+f+pvDe/UXQW9GRhlTaAsgjsYUUc7KjFvYn2l8W+pmvgLcJTGifGji HAE+ocEh79rBd9XBxG2MkQNvKslXkC38WZe199YzIZttyDH4ZYQPwgyKu dSEN9xOa8bWUEM4BvioQjFJyxzR9Fcnwc4zXeTv7zx2u5V/veVpbE79FB ZQKUG6Hp9vIUR7cIusgQ9yN8FbJjexGl1QpQ08ELKjiLQAjo/dhAxT9wc kfQNYtMOcVCT7N7SHY3YirYPWe/v51HbMEEf+Xy4AiGbao2/Ua+k22s9R 6RIlKoZmUCgJH7ZNKemT0qUJRMmbXpAnOz7JFf+hpBr+RWF2v+FCaRTL3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="383602785" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="383602785" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 10:45:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="942421659" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="942421659" Received: from caw1-mobl1.amr.corp.intel.com (HELO [10.255.229.136]) ([10.255.229.136]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 10:45:41 -0800 Message-ID: <7bae01ac-a0de-47d9-9bd3-6bdfc48e02c1@linux.intel.com> Date: Wed, 29 Nov 2023 10:39:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] ASoC: Intel: soc-acpi-intel-tgl-match: add cs42l43 and cs56l56 support Content-Language: en-US To: Richard Fitzgerald , Peter Ujfalusi , lgirdwood@gmail.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com, cezary.rojewski@intel.com, yung-chuan.liao@linux.intel.com, ckeepax@opensource.cirrus.com, yong.zhi@intel.com, chao.song@linux.intel.com References: <20231127133448.18449-1-peter.ujfalusi@linux.intel.com> <20231127133448.18449-7-peter.ujfalusi@linux.intel.com> <9660e9df-2061-4b2c-ba59-5e6f8a61f07d@opensource.cirrus.com> <6038c9fa-8cb1-46e1-b856-d759a3f990b3@opensource.cirrus.com> <5e9b0b69-6108-4909-90e8-257c13c2d886@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZAOWTDLIEMI4OGHRIG4LVSRKKDYBYYCC X-Message-ID-Hash: ZAOWTDLIEMI4OGHRIG4LVSRKKDYBYYCC X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >>>>>> +        .name_prefix = "cs35l56-8" >>>>> >>>>> Can these prefixes be "AMPn" to match the CS35L41, CS35L51 and >>>>> CS35L56-hda driver? This prefix is used to find the matching firmware >>>>> files and our naming convention for these has been cs35lxx-xxxx-ampn >>>>> >>>>> Is there anything that depends on the prefixes being "cs35l56-n" ? >>>> >>>> IIRC this name_prefix is just used for the codec_conf and hence for >>>> control names/UCM. At some point userspace/driver need to know if amp5 >>>> is left or right. >>>> >>>> We can certainly align on conventions but the values set in this ACPI >>>> match table will not be used for firmware download - different scope. >>>> >>> >>> They are used for our firmware download. Each amp can have its own >>> unique firmware file. The ALSA prefix is used to identify which firmware >>> file to load to which amp. >> >> The prefix will only be used when the card is created, specifically for >> control names. >> The firmware should be selected and downloaded when the device shows up >> on the bus. >> Card creation and device enumeration/initialization happen on different >> timelines, if the machine driver is "blacklisted" or unbound I am not >> sure what happens. >> >> There is a dependency between machine driver probe and codec firmware >> download that I am not able to follow, can you please elaborate? >> > > The codec driver has to choose which firmware to load from under > /lib/firmware. It does this using a combination of SSID (to identify the > target product), the ALSA prefix string (to identify which amp) and > in some systems a GPIO on the motherboard to select between different > models of speaker when they have multiple suppliers. This results in a > firmware name like: > > cs35l56--dsp1-misc-[-]- > > You can see this if you look in the linux-firmware repo under cirrus/ > for cs35l41 firmware files (though the ALSA PREFIX section in those > cases is not "AMPn" because they are not SDCA parts with rotation, > they have a fixed left/right assignment.) > > We have to be careful of the length of the prefix. The 44 characters of > an ALSA control name get eaten up very quickly when we start creating > fully-qualified names for controls published by the firmware. So "AMPn" > was nice because it was descriptive enough but only uses 5 characters > of the 44. > > Having said that, I've calculated that we have enough characters (just) > to use a prefix of "cs35l56-n". If there's a reason why that is > necessary/desirable for SOF or SoundWire then we could do that. But we'd > intended to use "AMPn" prefixes. > > We just need to decide whether to go with "AMPn". Or switch to using > "cs35l56-n" for the ALSA prefix (the therefore the qualifier at the end > of the firmware filename). Yes we have similar issues with control names in topology, the limit is hit very quickly. I think you missed my point though that the ALSA prefix is only set when the card is created, which can be sometime after the firmware needs to be downloaded. I guess you could pick the firmware in the component probe, which happens during the card creation, but that could be sub-optimal. Given the download times you want the download to proceed as early as possible.