From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 39/40] drm/i915/execlists: Refactor out can_merge_rq() Date: Thu, 27 Sep 2018 12:32:54 +0100 Message-ID: <7bc14636-6a36-7c40-5f4e-48ade30a5ba9@linux.intel.com> References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-39-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA1CF6E0DC for ; Thu, 27 Sep 2018 11:33:01 +0000 (UTC) In-Reply-To: <20180919195544.1511-39-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA5LzIwMTggMjA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgbmV4dCBw YXRjaCwgd2UgYWRkIGFub3RoZXIgdXNlciB0aGF0IHdhbnRzIHRvIGNoZWNrIHdoZXRoZXIKPiBy ZXF1ZXN0cyBjYW4gYmUgbWVyZ2UgaW50byBhIHNpbmdsZSBIVyBleGVjdXRpb24sIGFuZCBpbiB0 aGUgZnV0dXJlIHdlCj4gd2FudCB0byBhZGQgbW9yZSBjb25kaXRpb25zIHVuZGVyIHdoaWNoIHJl cXVlc3RzIGZyb20gdGhlIHNhbWUgY29udGV4dAo+IGNhbm5vdCBiZSBtZXJnZS4gSW4gcHJlcGFy YXRpb24sIGV4dHJhY3Qgb3V0IGNhbl9tZXJnZV9ycSgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAxMiArKysrKysrKysrLS0KPiAgIDEgZmlsZSBjaGFu Z2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5jCj4gaW5kZXggYmU3ZGJkZDdmYzJjLi42NzljZTUyMWJlMTYgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC00NzgsNiArNDc4LDE1IEBAIHN0YXRpYyBib29sIGNh bl9tZXJnZV9jdHgoY29uc3Qgc3RydWN0IGludGVsX2NvbnRleHQgKnByZXYsCj4gICAJcmV0dXJu IHRydWU7Cj4gICB9Cj4gICAKPiArc3RhdGljIGJvb2wgY2FuX21lcmdlX3JxKGNvbnN0IHN0cnVj dCBpOTE1X3JlcXVlc3QgKnByZXYsCj4gKwkJCSBjb25zdCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpu ZXh0KQo+ICt7Cj4gKwlpZiAoIWNhbl9tZXJnZV9jdHgocHJldi0+aHdfY29udGV4dCwgbmV4dC0+ aHdfY29udGV4dCkpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCXJldHVybiB0cnVlOwoKTm90 IGp1c3QgcmV0dXJuIGNhbl9tZXJnZV9jdHgoLi4pID8KClJlZ2FyZHMsCgpUdnJ0a28KCj4gK30K PiArCj4gICBzdGF0aWMgdm9pZCBwb3J0X2Fzc2lnbihzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9y dCwgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICB7Cj4gICAJR0VNX0JVR19PTihycSA9PSBw b3J0X3JlcXVlc3QocG9ydCkpOwo+IEBAIC02MzksOCArNjQ4LDcgQEAgc3RhdGljIHZvaWQgZXhl Y2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQkJICog c2Vjb25kIHJlcXVlc3QsIGFuZCBzbyB3ZSBuZXZlciBuZWVkIHRvIHRlbGwgdGhlCj4gICAJCQkg KiBoYXJkd2FyZSBhYm91dCB0aGUgZmlyc3QuCj4gICAJCQkgKi8KPiAtCQkJaWYgKGxhc3QgJiYK PiAtCQkJICAgICFjYW5fbWVyZ2VfY3R4KHJxLT5od19jb250ZXh0LCBsYXN0LT5od19jb250ZXh0 KSkgewo+ICsJCQlpZiAobGFzdCAmJiAhY2FuX21lcmdlX3JxKHJxLCBsYXN0KSkgewo+ICAgCQkJ CS8qCj4gICAJCQkJICogSWYgd2UgYXJlIG9uIHRoZSBzZWNvbmQgcG9ydCBhbmQgY2Fubm90Cj4g ICAJCQkJICogY29tYmluZSB0aGlzIHJlcXVlc3Qgd2l0aCB0aGUgbGFzdCwgdGhlbiB3ZQo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK