All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asim Shankar <asimshankar@gmail.com>
To: netdev@oss.sgi.com
Cc: devik@cdi.cz, Thomas Graf <tgraf@suug.ch>
Subject: [PATCH 2.6.11.7] sch_htb: Drop packet when direct queue is full
Date: Thu, 21 Apr 2005 18:02:55 -0500	[thread overview]
Message-ID: <7bca1cb505042116022f64a87e@mail.gmail.com> (raw)
In-Reply-To: <20050421215440.GL577@postel.suug.ch>

htb_enqueue(): Free skb and return NET_XMIT_DROP if a packet is
destined for the direct_queue but the direct_queue is full. (Before
this: erroneously returned NET_XMIT_SUCCESS even though the packet was
not enqueued)

Signed-off-by: Asim Shankar <asimshankar@gmail.com>

--- linux-2.6.11.7/net/sched/sch_htb.c.orig 2005-04-21 17:40:05.305709014 -0500
+++ linux-2.6.11.7/net/sched/sch_htb.c 2005-04-21 17:35:27.872624173 -0500
@@ -717,6 +717,10 @@ static int htb_enqueue(struct sk_buff *s
if (q->direct_queue.qlen < q->direct_qlen) {
    __skb_queue_tail(&q->direct_queue, skb);
    q->direct_pkts++;
+ } else {
+     kfree_skb(skb);
+     sch->qstats.drops++;
+     return NET_XMIT_DROP;
}
#ifdef CONFIG_NET_CLS_ACT
     } else if (!cl) {

  reply	other threads:[~2005-04-21 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-21 19:21 BUG: HTB? Asim Shankar
2005-04-21 19:56 ` Thomas Graf
2005-04-21 20:41   ` [PATCH] - sch_htb: Drop packet when direct queue overflows Asim Shankar
2005-04-21 21:54     ` Thomas Graf
2005-04-21 23:02       ` Asim Shankar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-04-25 19:15 [PATCH 2.6.11.7] sch_htb: Drop packet when direct queue is full Asim Shankar
2005-04-28 19:04 ` David S. Miller
2005-04-29 17:35   ` Asim Shankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bca1cb505042116022f64a87e@mail.gmail.com \
    --to=asimshankar@gmail.com \
    --cc=devik@cdi.cz \
    --cc=netdev@oss.sgi.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.